Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
test(control-api): read Secret values back from data, not write-only stringData
Diego Zacarias61b1423749d0
diff --git a/control-api/package-lock.json b/control-api/package-lock.jsonindex ea36133be..4847ffa76 100644--- a/control-api/package-lock.json+++ b/control-api/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-api",- "version": "0.1.640",+ "version": "0.1.641","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-api",- "version": "0.1.640",+ "version": "0.1.641","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/grok-provider-attempt-contract": "file:../packages/grok-provider-attempt-contract",diff --git a/control-api/package.json b/control-api/package.jsonindex f26ce09b6..26cc03598 100644--- a/control-api/package.json+++ b/control-api/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-api",- "version": "0.1.640",+ "version": "0.1.641","description": "Internal Clerum control plane REST API + UI for managing CRDs and secrets","main": "dist/main.js","engines": {diff --git a/control-api/test/routes.adminRemoteMcp.test.ts b/control-api/test/routes.adminRemoteMcp.test.tsindex e86731c6d..8680b7f6e 100644--- a/control-api/test/routes.adminRemoteMcp.test.ts+++ b/control-api/test/routes.adminRemoteMcp.test.ts@@ -225,10 +225,18 @@ describe('POST /admin/mcp-servers/remote (install saga)', () => {expect(res.status).toBe(201)expect(res.body.clientMode).toBe('confidential')+ // getSecret returns the base64 `data` map (K8s materializes write-only+ // stringData into data on apply), so decode before comparing plaintext.const secret = (await gw.getSecret('slack-remote-oauth-client', NS)) as {- stringData?: Record<string, string>+ data?: Record<string, string>}- expect(secret.stringData).toEqual({ client_id: 'client-abc', client_secret: 'shhh-secret' })+ const decoded = Object.fromEntries(+ Object.entries(secret.data ?? {}).map(([k, v]) => [+ k,+ Buffer.from(v, 'base64').toString('utf8'),+ ])+ )+ expect(decoded).toEqual({ client_id: 'client-abc', client_secret: 'shhh-secret' })const cr = (await gw.getResource('mcpservers', 'slack-remote', NS)) as {spec: { oauth: Record<string, unknown> }diff --git a/control-api/test/routes.registryInstall.oauth.test.ts b/control-api/test/routes.registryInstall.oauth.test.tsindex a76dbb80d..86a0bc0f6 100644--- a/control-api/test/routes.registryInstall.oauth.test.ts+++ b/control-api/test/routes.registryInstall.oauth.test.ts@@ -180,11 +180,13 @@ describe('POST /admin/registry/install — OAuth (S1-U2/U3)', () => {key: 'client_secret',})- // Managed Secret created with canonical keys.+ // Managed Secret created with canonical keys. K8s (and MockGateway,+ // faithfully) materializes write-only stringData into the base64 `data` map+ // on apply, so the read-back exposes the keys under `data`, not stringData.const secret = (await gw.getSecret('my-gmail-oauth-client', 'mcp-server')) as {- stringData?: Record<string, string>+ data?: Record<string, string>}- expect(Object.keys(secret.stringData ?? {}).sort()).toEqual(['client_id', 'client_secret'])+ expect(Object.keys(secret.data ?? {}).sort()).toEqual(['client_id', 'client_secret'])})it('never echoes client_id/client_secret values in the response body', async () => {@@ -682,10 +684,11 @@ describe('generic carril install (S3-B4)', () => {name: 'my-idp-oauth-client',key: 'client_secret',})+ // Read-back exposes keys under the base64 `data` map (stringData is write-only).const secret = (await gw.getSecret('my-idp-oauth-client', 'mcp-server')) as {- stringData?: Record<string, string>+ data?: Record<string, string>}- expect(Object.keys(secret.stringData ?? {}).sort()).toEqual(['client_id', 'client_secret'])+ expect(Object.keys(secret.data ?? {}).sort()).toEqual(['client_id', 'client_secret'])const subject = resolveServerOAuthSubject({ spec: server.spec })expect(subject?.decl.secretSource).toEqual({