Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

docs(e2e): correct the reason the model option is keyed by testid

Alfredo Lopez649f4d9ab39a
diff --git a/tests/e2e/playwright/desktop/codex-subscription-approved-tools.spec.ts b/tests/e2e/playwright/desktop/codex-subscription-approved-tools.spec.ts
index b21bca0f6..911e1846c 100644
--- a/tests/e2e/playwright/desktop/codex-subscription-approved-tools.spec.ts
+++ b/tests/e2e/playwright/desktop/codex-subscription-approved-tools.spec.ts
@@ -125,9 +125,10 @@ async function openAgentChat(desktop: Page, scenario: Scenario) {
await desktop.getByRole('button', { name: 'Model — Select model', exact: true }).click()
// The menu labels an option with the allowlist entry's displayName and
// falls back to the model id when there is none (ModelSelector.tsx:276).
- // The Codex allowlist carries no displayName, so the id is what renders.
- // Keying on the testid (ModelSelector.tsx:269) anchors this to the same
- // id the Control UI step bound, instead of to a label nothing defines.
+ // Which of the two renders depends on catalog metadata this test does not
+ // own: the deterministic upstream serves a display_name of its own. Keying
+ // on the testid (ModelSelector.tsx:269) anchors this to the same id the
+ // Control UI step bound, instead of to a label sourced outside this spec.
const modelOption = desktop.getByTestId(`model-option-${scenario.modelName}`)
await expect(modelOption).toHaveCount(1)
await modelOption.click()
diff --git a/tests/e2e/playwright/package-lock.json b/tests/e2e/playwright/package-lock.json
index e6d559457..a13bb13e1 100644
--- a/tests/e2e/playwright/package-lock.json
+++ b/tests/e2e/playwright/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-playwright-tests",
- "version": "0.1.61",
+ "version": "0.1.62",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-playwright-tests",
- "version": "0.1.61",
+ "version": "0.1.62",
"devDependencies": {
"@playwright/test": "^1.50.0",
"@types/node": "^22.0.0",
diff --git a/tests/e2e/playwright/package.json b/tests/e2e/playwright/package.json
index d831cabd2..df6aab448 100644
--- a/tests/e2e/playwright/package.json
+++ b/tests/e2e/playwright/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-playwright-tests",
- "version": "0.1.61",
+ "version": "0.1.62",
"private": true,
"description": "Playwright E2E tests for Control UI and Desktop App",
"scripts": {