Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
feat(control-api): accept and echo replaceInviter on control admin invitations
Jose Gabriel Ramirez Encinas690a4efaed90
diff --git a/control-api/package-lock.json b/control-api/package-lock.jsonindex b18e36f6c..ea36133be 100644--- a/control-api/package-lock.json+++ b/control-api/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-api",- "version": "0.1.639",+ "version": "0.1.640","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-api",- "version": "0.1.639",+ "version": "0.1.640","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/grok-provider-attempt-contract": "file:../packages/grok-provider-attempt-contract",diff --git a/control-api/package.json b/control-api/package.jsonindex 770c65c01..f26ce09b6 100644--- a/control-api/package.json+++ b/control-api/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-api",- "version": "0.1.639",+ "version": "0.1.640","description": "Internal Clerum control plane REST API + UI for managing CRDs and secrets","main": "dist/main.js","engines": {diff --git a/control-api/src/routes/admin/controlAdmins.ts b/control-api/src/routes/admin/controlAdmins.tsindex 3e18e995c..9259e6dd7 100644--- a/control-api/src/routes/admin/controlAdmins.ts+++ b/control-api/src/routes/admin/controlAdmins.ts@@ -263,7 +263,14 @@ export function createAdminControlAdminsRouter(): Router {return}- const invitation = await createControlAdminInvitation(email, invitedByAdminId)+ const replaceInviterInput: unknown = req.body?.replaceInviter+ if (replaceInviterInput !== undefined && typeof replaceInviterInput !== 'boolean') {+ res.status(400).json({ error: 'replaceInviter must be a boolean' })+ return+ }+ const invitation = await createControlAdminInvitation(email, invitedByAdminId, {+ replaceInviter: replaceInviterInput === true,+ })if ('error' in invitation) {res.status(409).json({ error: invitation.error })return@@ -319,6 +326,7 @@ export function createAdminControlAdminsRouter(): Router {status: invitation.status,expiresAt: invitation.expiresAt.toISOString(),createdAt: invitation.createdAt.toISOString(),+ replaceInviter: invitation.replaceInviter,},})} catch (error) {diff --git a/control-api/test/routes.adminControlAdmins.test.ts b/control-api/test/routes.adminControlAdmins.test.tsindex b5a877d22..696265d9d 100644--- a/control-api/test/routes.adminControlAdmins.test.ts+++ b/control-api/test/routes.adminControlAdmins.test.ts@@ -61,6 +61,28 @@ vi.mock()vi.mock('../src/middleware/controlUIAuth.js', () => uiAuth)+const directorySvc = vi.hoisted(() => ({+ createSilentInvitationForTeams: vi.fn(),+ revokePendingInvitation: vi.fn(),+}))+vi.mock('../src/services/directory/index.js', async importOriginal => ({+ ...(await importOriginal<typeof import('../src/services/directory/index.js')>()),+ ...directorySvc,+}))++function storedInvitation(replaceInviter: boolean) {+ return {+ id: '11111111-1111-4111-8111-111111111111',+ email: '[email protected]',+ status: 'pending' as const,+ expiresAt: new Date('2026-09-28T10:00:00.000Z'),+ createdAt: new Date('2026-09-26T10:00:00.000Z'),+ acceptedAt: null,+ replaceInviter,+ invitedByAdminId: 'current-admin-id',+ }+}+function createTestApp() {const app = express()app.use(express.json())@@ -84,6 +106,7 @@ describe('routes/adminControlAdmins', () => {Object.values(controlAdminInvitationRegistrationSvc).forEach(fn => fn.mockReset())Object.values(operatorLinkSvc).forEach(fn => fn.mockReset())Object.values(uiAuth).forEach(fn => fn.mockClear())+ Object.values(directorySvc).forEach(fn => fn.mockReset())})it('deletes another admin', async () => {@@ -255,4 +278,80 @@ describe('routes/adminControlAdmins', () => {expect(res.body).toEqual({ error: 'desktop_user_retired' })})++ it('stores replaceInviter and echoes the stored flag on the 201 body', async () => {+ adminSvc.createControlAdminInvitation.mockResolvedValue(storedInvitation(true))+ directorySvc.createSilentInvitationForTeams.mockResolvedValue({+ id: 'desktop-invitation-id',+ team_id: null,+ teams: [],+ })+ controlAdminInvitationRegistrationSvc.registerAndSendControlAdminInvitation.mockResolvedValue(+ undefined+ )++ const res = await request(createTestApp())+ .post('/admin/control-admin-invitations')+ .send({ email: '[email protected]', createDesktopAccess: true, replaceInviter: true })+ .expect(201)++ expect(adminSvc.createControlAdminInvitation).toHaveBeenCalledWith(+ '[email protected]',+ 'current-admin-id',+ { replaceInviter: true }+ )+ expect(res.body).toEqual({+ invitation: {+ id: '11111111-1111-4111-8111-111111111111',+ email: '[email protected]',+ status: 'pending',+ expiresAt: '2026-09-28T10:00:00.000Z',+ createdAt: '2026-09-26T10:00:00.000Z',+ replaceInviter: true,+ },+ })+ })++ it('defaults replaceInviter to false when the body omits it', async () => {+ adminSvc.createControlAdminInvitation.mockResolvedValue(storedInvitation(false))+ controlAdminInvitationRegistrationSvc.registerAndSendControlAdminInvitation.mockResolvedValue(+ undefined+ )++ const res = await request(createTestApp())+ .post('/admin/control-admin-invitations')+ .send({ email: '[email protected]' })+ .expect(201)++ expect(adminSvc.createControlAdminInvitation).toHaveBeenCalledWith(+ '[email protected]',+ 'current-admin-id',+ { replaceInviter: false }+ )+ expect(res.body.invitation.replaceInviter).toBe(false)+ })++ it('echoes what was stored, not what was requested', async () => {+ adminSvc.createControlAdminInvitation.mockResolvedValue(storedInvitation(false))+ controlAdminInvitationRegistrationSvc.registerAndSendControlAdminInvitation.mockResolvedValue(+ undefined+ )++ const res = await request(createTestApp())+ .post('/admin/control-admin-invitations')+ .send({ email: '[email protected]', replaceInviter: true })+ .expect(201)++ expect(res.body.invitation.replaceInviter).toBe(false)+ })++ it('rejects a non-boolean replaceInviter before creating anything', async () => {+ const res = await request(createTestApp())+ .post('/admin/control-admin-invitations')+ .send({ email: '[email protected]', replaceInviter: 'true' })+ .expect(400)++ expect(res.body).toEqual({ error: 'replaceInviter must be a boolean' })+ expect(adminSvc.createControlAdminInvitation).not.toHaveBeenCalled()+ })})