Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(frontend): r6-b2 use row action menus

Josué6f207dbaa4a6
diff --git a/control-ui/app/outputs/page.tsx b/control-ui/app/outputs/page.tsx
index 2cc9959bc..4d21f4dde 100644
--- a/control-ui/app/outputs/page.tsx
+++ b/control-ui/app/outputs/page.tsx
@@ -6,6 +6,7 @@ import { DataTable, TableHeaderCell, useTableSort } from '@clerum/frontend-table
import { CONTROL_ROUTES } from '@constants/routes'
import { AuthGate } from '../../components/AuthGate'
import { DashboardLayout } from '../../components/DashboardLayout'
+import { RowActionsMenu } from '../../components/RowActionsMenu'
import { SectionSearchInput } from '../../components/SectionSearchInput'
import { IconOutputs } from '../../components/Sidebar/icons'
import { SkeletonTableRows } from '../../components/SkeletonTableRows'
@@ -165,6 +166,41 @@ function OutputsPageContent() {
const showInitialLoading = loading && !hasLoaded
const visibleOutputsCount = filteredWorkflowOutputs.length + filteredChatArtifacts.length
+ async function downloadWorkflowOutput(output: WorkflowOutputRow) {
+ const url = getWorkflowRunArtifactDownloadUrl(
+ output.namespace,
+ output.recipeName,
+ output.runId,
+ output.fileName
+ )
+ const resp = await fetch(url, { credentials: 'include' })
+ if (!resp.ok) {
+ setError(`${resp.status}: ${await resp.text()}`)
+ return
+ }
+ const blobUrl = URL.createObjectURL(await resp.blob())
+ const link = document.createElement('a')
+ link.href = blobUrl
+ link.download = `${output.runId.slice(0, 8)}-${output.fileName}`
+ link.click()
+ URL.revokeObjectURL(blobUrl)
+ }
+
+ async function downloadChatArtifact(artifact: ChatArtifactOutputRow) {
+ const url = getHostArtifactDownloadUrl(artifact.hostRef, artifact.fileName)
+ const resp = await fetch(url, { credentials: 'include' })
+ if (!resp.ok) {
+ setError(`${resp.status}: ${await resp.text()}`)
+ return
+ }
+ const blobUrl = URL.createObjectURL(await resp.blob())
+ const link = document.createElement('a')
+ link.href = blobUrl
+ link.download = artifact.fileName
+ link.click()
+ URL.revokeObjectURL(blobUrl)
+ }
+
return (
<DashboardLayout>
<div className="cu-card cu-card--viewport-fill" style={{ marginBottom: '1.25rem' }}>
@@ -267,7 +303,7 @@ function OutputsPageContent() {
onSort={() => workflowSort.sortBy(key)}
/>
))}
- <TableHeaderCell label="Action" />
+ <TableHeaderCell label="Actions" />
</tr>
</thead>
<tbody>
@@ -299,34 +335,18 @@ function OutputsPageContent() {
<td style={{ fontSize: 13, color: 'var(--cu-text-muted)' }}>
{output.completedAt ? new Date(output.completedAt).toLocaleString() : '—'}
</td>
- <td>
- <button
- className="cu-btn cu-btn--sm cu-btn--toolbar"
- onClick={async () => {
- const url = getWorkflowRunArtifactDownloadUrl(
- output.namespace,
- output.recipeName,
- output.runId,
- output.fileName
- )
- const resp = await fetch(url, {
- credentials: 'include',
- })
- if (!resp.ok) {
- setError(`${resp.status}: ${await resp.text()}`)
- return
- }
- const blob = await resp.blob()
- const blobUrl = URL.createObjectURL(blob)
- const link = document.createElement('a')
- link.href = blobUrl
- link.download = `${output.runId.slice(0, 8)}-${output.fileName}`
- link.click()
- URL.revokeObjectURL(blobUrl)
- }}
- >
- Download
- </button>
+ <td className="cu-table__cell-actions">
+ <RowActionsMenu
+ ariaLabel={`Actions for workflow artifact ${output.fileName}`}
+ horizontalTrigger
+ actions={[
+ {
+ key: 'download',
+ label: 'Download',
+ onClick: () => void downloadWorkflowOutput(output),
+ },
+ ]}
+ />
</td>
</tr>
))}
@@ -369,7 +389,7 @@ function OutputsPageContent() {
onSort={() => artifactSort.sortBy(key)}
/>
))}
- <TableHeaderCell label="Action" />
+ <TableHeaderCell label="Actions" />
</tr>
</thead>
<tbody>
@@ -403,32 +423,18 @@ function OutputsPageContent() {
? new Date(artifact.createdAt).toLocaleString()
: '—'}
</td>
- <td>
- <button
- className="cu-btn cu-btn--sm cu-btn--toolbar"
- onClick={async () => {
- const url = getHostArtifactDownloadUrl(
- artifact.hostRef,
- artifact.fileName
- )
- const resp = await fetch(url, {
- credentials: 'include',
- })
- if (!resp.ok) {
- setError(`${resp.status}: ${await resp.text()}`)
- return
- }
- const blob = await resp.blob()
- const blobUrl = URL.createObjectURL(blob)
- const link = document.createElement('a')
- link.href = blobUrl
- link.download = artifact.fileName
- link.click()
- URL.revokeObjectURL(blobUrl)
- }}
- >
- Download
- </button>
+ <td className="cu-table__cell-actions">
+ <RowActionsMenu
+ ariaLabel={`Actions for desktop artifact ${artifact.fileName}`}
+ horizontalTrigger
+ actions={[
+ {
+ key: 'download',
+ label: 'Download',
+ onClick: () => void downloadChatArtifact(artifact),
+ },
+ ]}
+ />
</td>
</tr>
))}
diff --git a/control-ui/components/RegistryApiKeysPanel.tsx b/control-ui/components/RegistryApiKeysPanel.tsx
index b58f5130d..0766b220a 100644
--- a/control-ui/components/RegistryApiKeysPanel.tsx
+++ b/control-ui/components/RegistryApiKeysPanel.tsx
@@ -17,6 +17,7 @@ import { useConfirmDialog } from './ConfirmDialog'
import CreateApiKeyModal from './CreateApiKeyModal'
import type { RegistryApiKeysPanelProps } from './RegistryApiKeysPanel.types'
import RevealApiKeyModal from './RevealApiKeyModal'
+import { RowActionsMenu } from './RowActionsMenu'
import { SectionLoadingSkeleton } from './SectionLoadingSkeleton'
import { TableHeaderRow } from './TableHeaderRow'
import type { TableHeaderColumn } from './TableHeaderRow/types'
@@ -254,15 +255,19 @@ export default function RegistryApiKeysPanel({ embedded = false }: RegistryApiKe
<td title={k.created_at}>{fmtTime(k.created_at, '—')}</td>
<td>{fmtExpiry(k.expires_at)}</td>
<td>{fmtTime(k.last_used_at, 'Never used')}</td>
- <td>
- <Button
- type="button"
- variant="danger"
- size="sm"
- onClick={() => void handleRevoke(k)}
- >
- Revoke
- </Button>
+ <td className="cu-table__cell-actions">
+ <RowActionsMenu
+ ariaLabel={`Actions for API key ${k.key_prefix}`}
+ horizontalTrigger
+ actions={[
+ {
+ key: 'revoke',
+ label: 'Revoke',
+ danger: true,
+ onClick: () => void handleRevoke(k),
+ },
+ ]}
+ />
</td>
</tr>
))}
diff --git a/control-ui/components/__tests__/OutputsPage.test.tsx b/control-ui/components/__tests__/OutputsPage.test.tsx
index 4faf8817f..194a47c03 100644
--- a/control-ui/components/__tests__/OutputsPage.test.tsx
+++ b/control-ui/components/__tests__/OutputsPage.test.tsx
@@ -2,7 +2,11 @@ import type React from 'react'
import { afterEach, describe, expect, it, vi } from 'vitest'
import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
import OutputsPage from '../../app/outputs/page'
-import { getAdminOutputsOverview, getWorkflowRunArtifactDownloadUrl } from '../../lib/api'
+import {
+ getAdminOutputsOverview,
+ getHostArtifactDownloadUrl,
+ getWorkflowRunArtifactDownloadUrl,
+} from '../../lib/api'
const navigationState = vi.hoisted(() => ({
params: {} as { tab?: string },
@@ -63,6 +67,7 @@ vi.mock('../../lib/api', () => ({
}))
const mockGetAdminOutputsOverview = vi.mocked(getAdminOutputsOverview)
+const mockGetHostArtifactDownloadUrl = vi.mocked(getHostArtifactDownloadUrl)
const mockGetWorkflowRunArtifactDownloadUrl = vi.mocked(getWorkflowRunArtifactDownloadUrl)
afterEach(() => {
@@ -130,7 +135,8 @@ describe('OutputsPage', () => {
render(<OutputsPage />)
expect(await screen.findByText('report.md')).toBeInTheDocument()
- fireEvent.click(screen.getByText('Download'))
+ fireEvent.click(screen.getByRole('button', { name: 'Actions for workflow artifact report.md' }))
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Download' }))
await waitFor(() =>
expect(mockGetWorkflowRunArtifactDownloadUrl).toHaveBeenCalledWith(
@@ -145,4 +151,48 @@ describe('OutputsPage', () => {
})
expect(click).toHaveBeenCalled()
})
+
+ it('downloads desktop artifacts through the far-right action menu', async () => {
+ navigationState.params = { tab: 'desktop-app-artifacts' }
+ mockGetAdminOutputsOverview.mockResolvedValue({
+ chatArtifacts: [
+ {
+ hostRef: 'host-1',
+ fileName: 'transcript.txt',
+ format: 'txt',
+ sizeBytes: 18,
+ createdAt: '2026-05-12T00:00:02.000Z',
+ },
+ ],
+ workflowOutputs: [],
+ })
+ mockGetHostArtifactDownloadUrl.mockReturnValue('http://localhost/host-artifact')
+ const fetchMock = vi.fn().mockResolvedValue(new Response('artifact', { status: 200 }))
+ vi.stubGlobal('fetch', fetchMock)
+ Object.defineProperty(URL, 'createObjectURL', {
+ configurable: true,
+ value: vi.fn(() => 'blob:artifact'),
+ })
+ Object.defineProperty(URL, 'revokeObjectURL', {
+ configurable: true,
+ value: vi.fn(),
+ })
+ const click = vi.spyOn(HTMLAnchorElement.prototype, 'click').mockImplementation(() => {})
+
+ render(<OutputsPage />)
+
+ expect(await screen.findByText('transcript.txt')).toBeInTheDocument()
+ fireEvent.click(
+ screen.getByRole('button', { name: 'Actions for desktop artifact transcript.txt' })
+ )
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Download' }))
+
+ await waitFor(() =>
+ expect(mockGetHostArtifactDownloadUrl).toHaveBeenCalledWith('host-1', 'transcript.txt')
+ )
+ expect(fetchMock).toHaveBeenCalledWith('http://localhost/host-artifact', {
+ credentials: 'include',
+ })
+ expect(click).toHaveBeenCalled()
+ })
})
diff --git a/control-ui/components/__tests__/RegistryApiKeysPanel.test.tsx b/control-ui/components/__tests__/RegistryApiKeysPanel.test.tsx
index 83f9bcabc..d49d2d0cc 100644
--- a/control-ui/components/__tests__/RegistryApiKeysPanel.test.tsx
+++ b/control-ui/components/__tests__/RegistryApiKeysPanel.test.tsx
@@ -151,7 +151,8 @@ describe('RegistryApiKeysPanel', () => {
.mockResolvedValueOnce({ org: 'acme', keys: [] })
vi.mocked(api.revokeRegistryApiKey).mockResolvedValue(undefined)
render(<RegistryApiKeysPanel />)
- fireEvent.click(await screen.findByRole('button', { name: /revoke/i }))
+ fireEvent.click(await screen.findByRole('button', { name: 'Actions for API key efrk_abc' }))
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Revoke' }))
await waitFor(() => {
expect(api.revokeRegistryApiKey).toHaveBeenCalledWith('k1')
expect(api.listRegistryApiKeys).toHaveBeenCalledTimes(2)
@@ -171,7 +172,8 @@ describe('RegistryApiKeysPanel', () => {
Object.assign(new Error('not found'), { status: 404 })
)
render(<RegistryApiKeysPanel />)
- fireEvent.click(await screen.findByRole('button', { name: /revoke/i }))
+ fireEvent.click(await screen.findByRole('button', { name: 'Actions for API key efrk_abc' }))
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Revoke' }))
await waitFor(() => {
expect(api.listRegistryApiKeys).toHaveBeenCalledTimes(2)
})
diff --git a/control-ui/e2e/qa-recorder-marketplace-api-keys.spec.ts b/control-ui/e2e/qa-recorder-marketplace-api-keys.spec.ts
index 40696aa53..25cba6cdf 100644
--- a/control-ui/e2e/qa-recorder-marketplace-api-keys.spec.ts
+++ b/control-ui/e2e/qa-recorder-marketplace-api-keys.spec.ts
@@ -96,7 +96,8 @@ test.describe('optional QA recorder: Control UI marketplace API keys', () => {
// Revoke from the row, confirming via the danger dialog.
const row = page.locator('table.cu-table tr', { hasText: description })
- await row.getByRole('button', { name: 'Revoke', exact: true }).click()
+ await row.getByRole('button', { name: /Actions for API key/ }).click()
+ await page.getByRole('menuitem', { name: 'Revoke', exact: true }).click()
const confirmDialog = page.getByRole('alertdialog', { name: 'Revoke API key' })
await expect(confirmDialog).toBeVisible({ timeout: 20_000 })
await confirmDialog.getByRole('button', { name: 'Revoke', exact: true }).click()
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 2895399da..da62f094b 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.503",
+ "version": "0.1.504",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.503",
+ "version": "0.1.504",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-table-system": "file:../packages/frontend-table-system",
diff --git a/control-ui/package.json b/control-ui/package.json
index 2d737826c..bbc48fdea 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.503",
+ "version": "0.1.504",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",