Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(mcp-host): keep a year in parentheses, and a moment before March 1900, as text in XLSX
marcoteb7475bdf49cf9
diff --git a/mcp-host/src/workflow/__tests__/internalTools.xlsx.values.test.ts b/mcp-host/src/workflow/__tests__/internalTools.xlsx.values.test.tsindex c2fd6f4d9..4c36f2592 100644--- a/mcp-host/src/workflow/__tests__/internalTools.xlsx.values.test.ts+++ b/mcp-host/src/workflow/__tests__/internalTools.xlsx.values.test.ts@@ -460,6 +460,31 @@ describe('signs, identifiers and text left as sent', () => {)})+ it('keeps a year in parentheses as text, and reads a grouped quantity as negative', async () => {+ const { ws } = await oneSheet([+ ['Value', 'Amount'],+ ['(2024)', '(1,500)'],+ ['(1850)', '(2,024)'],+ ])+ expect(ws.getCell('A2').value).toBe('(2024)')+ expect(ws.getCell('A3').value).toBe('(1850)')+ expect(ws.getCell('B2').value).toBe(-1500)+ expect(ws.getCell('B3').value).toBe(-2024)+ })++ it('applies a time zone before the 1900 check, and refuses an offset no zone has', async () => {+ const { ws } = await oneSheet([+ ['When'],+ ['1900-03-01T01:00+05:00'],+ ['2026-05-01T10:00+99:99'],+ ['2026-05-01T10:00+14:00'],+ ])+ // 1900-02-28T20:00 UTC: Excel would show a day that never existed.+ expect(ws.getCell('A2').value).toBe('1900-03-01T01:00+05:00')+ expect(ws.getCell('A3').value).toBe('2026-05-01T10:00+99:99')+ expect((ws.getCell('A4').value as Date).toISOString()).toBe('2026-04-30T20:00:00.000Z')+ })+it('writes identifier columns without thousands separators', async () => {const headers = ['Invoice No.',diff --git a/mcp-host/src/workflow/xlsxCells.ts b/mcp-host/src/workflow/xlsxCells.tsindex edc464f82..16f809054 100644--- a/mcp-host/src/workflow/xlsxCells.ts+++ b/mcp-host/src/workflow/xlsxCells.ts@@ -118,7 +118,10 @@ function parseNumberText(text: string): ParsedNumber | 'ambiguous' | undefined {const inner = parseNumberText(accounting[1].trim())if (inner === undefined || inner === 'ambiguous') return innerconst digits = accounting[1].replace(/\D/g, '').length- if (!inner.currency && !inner.percent && !/[.,]/.test(accounting[1]) && digits < 3) {+ const bare = !inner.currency && !inner.percent && !/[.,]/.test(accounting[1])+ // A short count is a note marker, and a bare year such as "(2024)" a date+ // in text; accounting writes a quantity of thousands with its grouping.+ if (bare && (digits < 3 || (digits === 4 && inner.value >= 1800 && inner.value < 2200))) {return undefined}return { ...inner, value: -inner.value, written: -inner.written }@@ -178,9 +181,6 @@ function parseDateText(text: string): ParsedDate | undefined {const [year, month, day] = [Number(m[1]), Number(m[2]), Number(m[3])]const [hour, minute, second] = [Number(m[4] ?? 0), Number(m[5] ?? 0), Number(m[6] ?? 0)]if (month < 1 || month > 12 || hour > 23 || minute > 59 || second > 59) return undefined- // Excel counts a 29 February 1900 that never existed, so the serial of any- // earlier date shows one day late; those dates stay text.- if (year < 1900 || (year === 1900 && month < 3)) return undefinedconst ms = m[7] ? Math.round(Number(`0.${m[7]}`) * 1000) : 0let time = Date.UTC(year, month - 1, day, hour, minute, second, ms)const check = new Date(time)@@ -188,10 +188,17 @@ function parseDateText(text: string): ParsedDate | undefined {let offsetMinutes = 0if (m[8] && m[8] !== 'Z') {const digits = m[8].replace(':', '')- offsetMinutes = Number(digits.slice(1, 3)) * 60 + Number(digits.slice(3, 5) || 0)+ const [hours, minutes] = [Number(digits.slice(1, 3)), Number(digits.slice(3, 5) || 0)]+ // UTC offsets run from -12:00 to +14:00; anything else is not a time zone.+ if (hours > 14 || minutes > 59) return undefined+ offsetMinutes = hours * 60 + minutesif (digits[0] === '-') offsetMinutes = -offsetMinutestime -= offsetMinutes * 60_000}+ // Excel counts a 29 February 1900 that never existed, so the serial of any+ // earlier moment shows one day late; those dates stay text. Checked once the+ // offset is applied, since that is the moment the cell holds.+ if (time < Date.UTC(1900, 2, 1)) return undefinedreturn {date: new Date(time),time: m[4] !== undefined,