Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(control-api): r1-b1 fail closed on limiter backend loss
Josué74f63b69064a
diff --git a/control-api/package-lock.json b/control-api/package-lock.jsonindex 42e274bd2..f535df78c 100644--- a/control-api/package-lock.json+++ b/control-api/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-api",- "version": "0.1.633",+ "version": "0.1.634","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-api",- "version": "0.1.633",+ "version": "0.1.634","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/grok-provider-attempt-contract": "file:../packages/grok-provider-attempt-contract",diff --git a/control-api/package.json b/control-api/package.jsonindex 69a52a844..a6d907f97 100644--- a/control-api/package.json+++ b/control-api/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-api",- "version": "0.1.633",+ "version": "0.1.634","description": "Internal Clerum control plane REST API + UI for managing CRDs and secrets","main": "dist/main.js","engines": {diff --git a/control-api/src/routes/external/entityChanges.routes.ts b/control-api/src/routes/external/entityChanges.routes.tsindex 15a912760..9e3b2b8a8 100644--- a/control-api/src/routes/external/entityChanges.routes.ts+++ b/control-api/src/routes/external/entityChanges.routes.ts@@ -33,6 +33,7 @@ export function createExternalEntityChangesRouter(): Router {rateLimitMiddleware({bucketType: 'external_user',maxPerMinute: config.approvalRlExternalPerMin,+ onBackendUnavailable: 'closed',getBucketKey: req => {const claims = (req as ExternalAuthedRequest).externalAuthreturn claims ? `user:${claims.userId}:entity-changes` : nulldiff --git a/control-api/test/routes.externalEntityChanges.rateLimit.test.ts b/control-api/test/routes.externalEntityChanges.rateLimit.test.tsnew file mode 100644index 000000000..ee0c8a089--- /dev/null+++ b/control-api/test/routes.externalEntityChanges.rateLimit.test.ts@@ -0,0 +1,63 @@+import { describe, expect, it, vi } from 'vitest'+import type { Router } from 'express'++type LimiterOptions = {+ bucketType: string+ maxPerMinute: number+ onBackendUnavailable: 'process-memory' | 'closed'+}++const captured = vi.hoisted(() => [] as LimiterOptions[])++vi.mock('../src/config.js', () => ({+ config: {+ approvalRlExternalClientIpPerMin: 100,+ approvalRlExternalEdgePerMin: 100,+ approvalRlExternalPerMin: 60,+ },+}))+vi.mock('../src/middleware/externalClientIdentity.js', () => ({+ createExternalClientRateLimiters: () => [],+}))+vi.mock('../src/middleware/externalSessionAuth.js', () => ({+ isCurrentExternalSession: vi.fn(),+ requireValidExternalSessionToken: (_req: unknown, _res: unknown, next: () => void) => next(),+}))+vi.mock('../src/middleware/rateLimitMiddleware.js', () => ({+ rateLimitMiddleware: (options: LimiterOptions) => {+ captured.push(options)+ const middleware = ((_req: unknown, _res: unknown, next: () => void) => next()) as ((+ ...args: unknown[]+ ) => void) & { limiterOptions: LimiterOptions }+ middleware.limiterOptions = options+ return middleware+ },+}))+vi.mock('../src/routes/entityChangeStream.js', () => ({+ parseRequestedEntityChangeCursor: () => null,+ streamEntityChanges: vi.fn(),+}))++const { createExternalEntityChangesRouter } =+ await import('../src/routes/external/entityChanges.routes.js')++type RouteLayer = {+ route?: { path: string; methods: Record<string, boolean>; stack: Array<{ handle: unknown }> }+}++describe('external entity-change stream rate-limit policy', () => {+ it('fails closed when the shared rate-limit backend cannot count the user request', () => {+ const router: Router = createExternalEntityChangesRouter()+ const route = (router.stack as RouteLayer[]).find(+ layer => layer.route?.path === '/external/entity-changes/stream'+ )?.route+ expect(route).toBeDefined()+ expect(captured).toHaveLength(1)+ expect(captured[0]).toMatchObject({+ bucketType: 'external_user',+ maxPerMinute: 60,+ onBackendUnavailable: 'closed',+ })+ expect(route?.stack.some(layer => 'limiterOptions' in (layer.handle as object))).toBe(true)+ })+})