Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(workflow-recipes): delete the legacy name in the finalizer list (R4-L4)

Alfredo Lopez75f96bcc7500
diff --git a/workflow-recipes/package-lock.json b/workflow-recipes/package-lock.json
index 9ab501f3f..691d6a4c3 100644
--- a/workflow-recipes/package-lock.json
+++ b/workflow-recipes/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "workload-recipes-controller",
- "version": "0.1.446",
+ "version": "0.1.447",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "workload-recipes-controller",
- "version": "0.1.446",
+ "version": "0.1.447",
"license": "SEE LICENSE IN LICENSE",
"dependencies": {
"@aws-sdk/client-s3": "^3.1009.0",
diff --git a/workflow-recipes/package.json b/workflow-recipes/package.json
index db95d22d0..9b0263977 100644
--- a/workflow-recipes/package.json
+++ b/workflow-recipes/package.json
@@ -1,6 +1,6 @@
{
"name": "workload-recipes-controller",
- "version": "0.1.446",
+ "version": "0.1.447",
"description": "Workload Recipes Controller (WRC) - WorkloadRecipe lifecycle management and MCP server interface",
"main": "dist/main.js",
"engines": {
diff --git a/workflow-recipes/src/workflow/workflowReconciler.ts b/workflow-recipes/src/workflow/workflowReconciler.ts
index caae3a1e5..3aee38c43 100644
--- a/workflow-recipes/src/workflow/workflowReconciler.ts
+++ b/workflow-recipes/src/workflow/workflowReconciler.ts
@@ -3403,7 +3403,7 @@ export class WorkflowReconciler {
* | mid-run retry (this) | applied | kept if live | kept | kept | kept |
* | legacy retry | untouched | untouched | untouched | untouched | deleted, backoff |
* | terminal teardown | kept | kept | kept | kept | kept |
- * | finalizer | deleted | deleted | deleted | deleted | only if labeled |
+ * | finalizer | deleted | deleted | deleted | deleted | deleted |
*
* Table A, what each writer publishes (`networkPolicyMarkerConditions`).
* The facts are A (apply: `converged | pending`), P (prune: `converged |
@@ -3458,8 +3458,8 @@ export class WorkflowReconciler {
* that policy may open; that policy is outside the run-lane catalog. It
* deletes no run-lane policy. The finalizer deletes a fixed list of run-lane
* names and sweeps by the recipe labels in the sandbox and mcp-server
- * namespaces; the legacy policy has no name-based delete there and goes only
- * if it carries those labels.
+ * namespaces; the legacy policy predates those labels and is deleted by
+ * name in the mcp-server namespace.
*
* reconcile(), and so its prune, also runs while the run's pods are live:
* the WRC falls through to it for a run in `initializing` or `recovering`,
@@ -4451,8 +4451,9 @@ export class WorkflowReconciler {
// NP-02: wf-mcp-host-ingress lives in mcpServerNamespace, not sandboxNamespace.
// NP-03: now one NP per mcp-server (named `wf-mcp-ingress-${mcpServerName}`).
// List-by-label is the cleanest cleanup — all managed NPs have recipe label.
- const mcpServerNpNames: string[] = [] // legacy single-NP name no longer used;
- // per-mcp-server NPs are deleted via label selector below.
+ // Per-mcp-server NPs are deleted via label selector below. The legacy
+ // internet policy predates those labels, so it is deleted by name (R4-L4).
+ const mcpServerNpNames: string[] = [`${recipeName}-mcp-servers-egress-internet`]
const mcpNs = this.deps.config.mcpServerNamespace
const cleanupTasks: Array<{ label: string; run: () => Promise<void> }> = [