Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(desktop): r1-m5 derive complete access sources in test fixtures

M771b94c4c328
diff --git a/desktop-app/ui/src/gfs/__tests__/GfsGrantList.test.tsx b/desktop-app/ui/src/gfs/__tests__/GfsGrantList.test.tsx
index cde00ca7f..0cb8c8322 100644
--- a/desktop-app/ui/src/gfs/__tests__/GfsGrantList.test.tsx
+++ b/desktop-app/ui/src/gfs/__tests__/GfsGrantList.test.tsx
@@ -7,6 +7,7 @@ import type {
GfsInheritedAccessItem,
GfsShareListItem,
} from '../delegation.types'
+import { mergeInheritedAccessItem } from '../inheritedAccessMerge'
/**
* "Who has access" list (Manage modal). Rows resolve host subjects to agent
@@ -225,15 +226,16 @@ describe('GfsGrantList', () => {
subject: { type: 'user', id: 'user-2' },
permissions: ['read', 'write'],
inheritedFrom: ['team-docs'],
- sources: [
+ sources: mergeInheritedAccessItem(
+ null,
{
- resourceId: 'folder-1',
- name: 'team-docs',
+ subject: { type: 'user', id: 'user-2' },
permissions: ['read', 'write'],
grantId: 'parent-grant-1',
shareIds: [],
},
- ],
+ { resourceId: 'folder-1', name: 'team-docs' }
+ ).sources,
...overrides,
})
diff --git a/desktop-app/ui/src/gfs/__tests__/inheritedAccessMerge.prop.test.ts b/desktop-app/ui/src/gfs/__tests__/inheritedAccessMerge.prop.test.ts
index d173785d7..3372c1709 100644
--- a/desktop-app/ui/src/gfs/__tests__/inheritedAccessMerge.prop.test.ts
+++ b/desktop-app/ui/src/gfs/__tests__/inheritedAccessMerge.prop.test.ts
@@ -197,13 +197,12 @@ describe('inheritedAccessMerge properties', () => {
const comparisons = [leftRank < rightRank, leftRank === rightRank, leftRank > rightRank]
expect(comparisons.filter(Boolean)).toHaveLength(1)
- const toSource = (permissions: string[]): GfsInheritedAccessSource => ({
- resourceId: 'r',
- name: 'r',
- permissions,
- grantId: null,
- shareIds: [],
- })
+ const toSource = (permissions: string[]): GfsInheritedAccessSource =>
+ mergeInheritedAccessItem(
+ null,
+ { subject: { type: 'user', id: 'member' }, permissions, grantId: null, shareIds: [] },
+ { resourceId: 'r', name: 'r' }
+ ).sources[0]!
const forward = strongestInheritedSource([toSource(left), toSource(right)])
const backward = strongestInheritedSource([toSource(right), toSource(left)])
expect(roleRank(forward?.permissions ?? [])).toBe(roleRank(backward?.permissions ?? []))
@@ -218,13 +217,19 @@ describe('inheritedAccessMerge properties', () => {
distinctFoldersArb,
fc.array(permissionsArb, { minLength: 1, maxLength: 8 }),
(folders, permissionSets) => {
- const sources: GfsInheritedAccessSource[] = folders.map((folder, index) => ({
- resourceId: folder.resourceId,
- name: folder.name,
- permissions: permissionSets[index % permissionSets.length]!,
- grantId: null,
- shareIds: [],
- }))
+ const sources: GfsInheritedAccessSource[] = folders.map(
+ (folder, index) =>
+ mergeInheritedAccessItem(
+ null,
+ {
+ subject: { type: 'user', id: 'member' },
+ permissions: permissionSets[index % permissionSets.length]!,
+ grantId: null,
+ shareIds: [],
+ },
+ folder
+ ).sources[0]!
+ )
const permissions = [...new Set(sources.flatMap(source => source.permissions))]
const item = { permissions, sources }
const editorSources = sources.filter(source => isEditorPermissions(source.permissions))