Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(frontend-components): search selectable item labels

Josué7c26ed98c4f6
diff --git a/packages/frontend-components/src/edit/MultiSelectActionDialog.tsx b/packages/frontend-components/src/edit/MultiSelectActionDialog.tsx
index 6b6e0cf6a..10a41242c 100644
--- a/packages/frontend-components/src/edit/MultiSelectActionDialog.tsx
+++ b/packages/frontend-components/src/edit/MultiSelectActionDialog.tsx
@@ -30,10 +30,14 @@ export function MultiSelectActionDialog({
const normalizedQuery = query.trim().toLocaleLowerCase()
const visibleItems = useMemo(
() =>
- items.filter(
- item =>
- !normalizedQuery || (item.searchText ?? '').toLocaleLowerCase().includes(normalizedQuery)
- ),
+ items.filter(item => {
+ const labelText =
+ typeof item.label === 'string' || typeof item.label === 'number'
+ ? String(item.label)
+ : item.id
+ const searchableText = (item.searchText ?? labelText).toLocaleLowerCase()
+ return !normalizedQuery || searchableText.includes(normalizedQuery)
+ }),
[items, normalizedQuery]
)
const selected = new Set(selectedIds)
diff --git a/packages/frontend-components/src/edit/__tests__/EditPrimitives.test.tsx b/packages/frontend-components/src/edit/__tests__/EditPrimitives.test.tsx
index 2fd2f7182..27931384f 100644
--- a/packages/frontend-components/src/edit/__tests__/EditPrimitives.test.tsx
+++ b/packages/frontend-components/src/edit/__tests__/EditPrimitives.test.tsx
@@ -213,6 +213,7 @@ describe('MultiSelectActionDialog', () => {
const items = [
{ id: 'alpha', label: 'Alpha', description: 'First option', searchText: 'first alpha' },
{ id: 'beta', label: 'Beta', searchText: 'second beta', disabled: true },
+ { id: 'gamma', label: 'Gamma' },
] as const
it('filters accessible options, keeps disabled items immutable, and acts only on selected IDs', async () => {
@@ -323,4 +324,23 @@ describe('MultiSelectActionDialog', () => {
expect(within(dialog).getByRole('button', { name: 'Apply' })).toBeDisabled()
expect(onAction).not.toHaveBeenCalled()
})
+
+ it('searches a plain text label when an explicit search adapter is omitted', async () => {
+ const user = userEvent.setup()
+ render(
+ <MultiSelectActionDialog
+ actionLabel="Apply"
+ items={[{ id: 'gamma', label: 'Gamma' }]}
+ onAction={vi.fn()}
+ onDismiss={vi.fn()}
+ onSelectedIdsChange={vi.fn()}
+ open
+ selectedIds={[]}
+ title="Choose records"
+ />
+ )
+ const dialog = await screen.findByRole('dialog', { name: 'Choose records' })
+ await user.type(within(dialog).getByRole('searchbox', { name: 'Search items' }), 'Gamma')
+ expect(within(dialog).getByRole('checkbox', { name: 'Gamma' })).toBeInTheDocument()
+ })
})