Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

refactor(frontend): retire legacy table patterns

Josué812f5b50d740
diff --git a/control-ui/app/globals.css b/control-ui/app/globals.css
index 447729271..4c2b02f71 100644
--- a/control-ui/app/globals.css
+++ b/control-ui/app/globals.css
@@ -62,7 +62,7 @@
--cu-create-action-min-width: 8.5rem;
--cu-create-flow-min-height: calc(100vh - 7rem);
--cu-toast-top-offset: calc(var(--cu-space-5) * 3.5);
- --cu-expandable-body-bg: #000000;
+ --cu-preview-body-bg: #000000;
/* ---- Typography ---------------------------------------------------- */
/* Derived from control-ui's own de-facto usage, so adopting the scale is
@@ -163,7 +163,7 @@
--cu-auth-bg-edge: rgba(var(--cu-edge-rgb), 0.28);
--cu-selection-bg: rgba(var(--cu-accent-rgb), 0.3);
--cu-selection-text: var(--cu-brand-dark-blue);
- --cu-expandable-body-bg: var(--cu-bg);
+ --cu-preview-body-bg: var(--cu-bg);
}
*,
@@ -2005,50 +2005,59 @@ textarea.cu-input {
margin-bottom: var(--cu-space-5);
}
-.cu-expandable-table {
- table-layout: fixed;
-}
-
.cu-connectors-table-wrap,
.cu-marketplace-table-wrap {
container-type: inline-size;
}
.cu-connectors-table {
- min-width: 48rem;
- --cu-expandable-inset-left: calc(3rem + 0.85rem);
- --cu-expandable-inset-right: max(7rem, calc(55% - 21rem));
+ min-width: 88rem;
}
.cu-connectors-table th:nth-child(1),
.cu-connectors-table td:nth-child(1) {
- width: 3rem;
+ width: 12rem;
}
.cu-connectors-table th:nth-child(2),
.cu-connectors-table td:nth-child(2) {
- width: 45%;
- max-width: 45%;
+ width: 18rem;
+ max-width: 18rem;
}
.cu-connectors-table th:nth-child(3),
.cu-connectors-table td:nth-child(3) {
- width: 8rem;
+ width: 7rem;
}
.cu-connectors-table th:nth-child(4),
.cu-connectors-table td:nth-child(4) {
- width: 10rem;
+ width: 15rem;
}
.cu-connectors-table th:nth-child(5),
.cu-connectors-table td:nth-child(5) {
- width: max(7rem, calc(55% - 21rem));
- text-align: right;
+ width: 15rem;
}
-.cu-connectors-table td:nth-child(5) .cu-table-actions {
- justify-content: flex-end;
+.cu-connectors-table th:nth-child(6),
+.cu-connectors-table td:nth-child(6) {
+ width: 10rem;
+}
+
+.cu-connectors-table th:nth-child(7),
+.cu-connectors-table td:nth-child(7),
+.cu-connectors-table th:nth-child(8),
+.cu-connectors-table td:nth-child(8),
+.cu-connectors-table th:nth-child(9),
+.cu-connectors-table td:nth-child(9) {
+ width: 7rem;
+}
+
+.cu-connectors-table th:nth-child(10),
+.cu-connectors-table td:nth-child(10) {
+ width: 4rem;
+ text-align: right;
}
.cu-guardrails-table-wrap {
@@ -2100,133 +2109,19 @@ textarea.cu-input {
width: 3rem;
}
-.cu-expandable-row__name,
+.cu-table__cell-name,
.cu-installed-plugin__name {
color: var(--cu-text);
font-weight: 600;
}
-.cu-expandable-row__chevron {
- color: var(--cu-text-muted);
- text-align: center;
-}
-
-.cu-expandable-row__chevron svg {
- display: block;
- margin: auto;
- transition: transform var(--cu-control-transition);
- transform: rotate(0deg);
-}
-
-.cu-expandable-row__chevron svg.is-expanded {
- transform: rotate(90deg);
-}
-
-.cu-expandable-detail-row > td {
- padding: 0;
- background: var(--cu-expandable-body-bg);
-}
-
-.cu-table tbody .cu-expandable-detail-row:hover > td {
- background: var(--cu-expandable-body-bg);
-}
-
-.cu-expandable-detail {
+.cu-detail-summary {
display: flex;
gap: var(--cu-space-5);
- padding: var(--cu-space-4) var(--cu-expandable-inset-right, var(--cu-space-5)) var(--cu-space-4)
- var(--cu-expandable-inset-left, var(--cu-space-5));
-}
-
-.cu-connector-detail .cu-expandable-detail__fields {
- flex: 1 1 auto;
- width: 100%;
- max-width: none;
-}
-
-.cu-connector-detail .cu-expandable-detail__description {
- flex: 0 0 100%;
- width: 100%;
- max-width: none;
- margin-bottom: 0;
-}
-
-.cu-connector-detail .cu-expandable-field,
-.cu-connector-detail .cu-expandable-field > .cu-link {
- text-align: left;
-}
-
-.cu-connector-detail .cu-expandable-field > .cu-link {
- max-width: 100%;
-}
-
-.cu-connector-detail__metadata {
- display: grid;
- grid-template-columns: repeat(auto-fit, minmax(10rem, 1fr));
- flex: 0 0 100%;
- gap: var(--cu-space-4);
- min-width: 0;
-}
-
-.cu-connector-copyable-value {
- display: flex;
- align-items: center;
- gap: var(--cu-space-1);
- width: 100%;
- min-width: 0;
-}
-
-.cu-connector-copyable-value > .cu-expandable-field__code {
- display: block;
- min-width: 0;
- overflow: hidden;
- text-overflow: ellipsis;
- white-space: nowrap;
-}
-
-.cu-connector-copyable-value__button {
- width: 1.75rem;
- height: 1.75rem;
- flex: 0 0 auto;
-}
-
-.cu-connector-access-field {
- gap: var(--cu-space-2);
-}
-
-.cu-connector-access-grid {
- width: 100%;
- grid-template-columns: repeat(auto-fit, minmax(10rem, 1fr));
-}
-
-.cu-connector-context-access__list li {
- align-items: center;
-}
-
-.cu-connector-context-access__name {
- flex: 1 1 auto;
-}
-
-.cu-connector-context-access__name > .cu-link {
- display: block;
- max-width: 100%;
- overflow: hidden;
- text-overflow: ellipsis;
- white-space: nowrap;
-}
-
-.cu-connector-context-access__remove {
- width: var(--cu-space-5);
- height: var(--cu-space-5);
- flex: 0 0 auto;
-}
-
-.cu-connector-context-access__add {
- width: 100%;
- margin-top: auto;
+ padding: var(--cu-space-4) var(--cu-space-5);
}
-.cu-expandable-detail__fields {
+.cu-detail-summary__fields {
display: flex;
flex: 1 1 50%;
flex-wrap: wrap;
@@ -2235,7 +2130,7 @@ textarea.cu-input {
min-width: 0;
}
-.cu-expandable-field {
+.cu-detail-field {
display: flex;
flex: 1 1 10rem;
min-width: 0;
@@ -2244,21 +2139,19 @@ textarea.cu-input {
gap: var(--cu-space-1);
}
-.cu-expandable-field--wide {
+.cu-detail-field--wide {
flex-basis: 100%;
}
-.cu-marketplace-detail .cu-expandable-field,
-.cu-marketplace-row-detail .cu-expandable-field {
+.cu-marketplace-detail .cu-detail-field {
flex: 0 0 auto;
}
-.cu-marketplace-detail .cu-expandable-detail__fields,
-.cu-marketplace-row-detail .cu-expandable-detail__fields {
+.cu-marketplace-detail .cu-detail-summary__fields {
gap: var(--cu-space-4);
}
-.cu-expandable-field__label {
+.cu-detail-field__label {
color: var(--cu-text-muted);
font-size: 0.7rem;
font-weight: 600;
@@ -2266,30 +2159,14 @@ textarea.cu-input {
text-transform: uppercase;
}
-/* Previous-versions list inside an expanded owned-entry row: keep the label and
- each version/Install line spaced so adjacent Install buttons don't touch. */
-.cu-marketplace-versions {
- display: flex;
- flex: 1 1 auto;
- flex-direction: column;
- gap: var(--cu-space-3);
- min-width: 0;
- max-width: 28rem;
-}
-
-.cu-marketplace-versions .cu-table-actions {
- align-items: center;
- gap: var(--cu-space-4);
-}
-
-.cu-expandable-field__code,
+.cu-detail-field__code,
.cu-code-text {
color: var(--cu-text-soft);
font-family: ui-monospace, SFMono-Regular, Menlo, Monaco, Consolas, monospace;
overflow-wrap: anywhere;
}
-.cu-expandable-detail__description {
+.cu-detail-summary__description {
flex: 1 1 50%;
max-width: 50%;
margin: 0;
@@ -2298,7 +2175,7 @@ textarea.cu-input {
white-space: pre-wrap;
}
-.cu-expandable-tags {
+.cu-detail-tags {
display: flex;
flex-wrap: wrap;
align-items: center;
@@ -2435,11 +2312,11 @@ textarea.cu-input {
}
@media (max-width: 768px) {
- .cu-expandable-detail {
+ .cu-detail-summary {
flex-direction: column;
}
- .cu-expandable-detail__description {
+ .cu-detail-summary__description {
order: -1;
width: 100%;
max-width: none;
@@ -2447,15 +2324,12 @@ textarea.cu-input {
}
@container (max-width: 48rem) {
- .cu-connector-detail .cu-expandable-detail__fields,
- .cu-marketplace-row-detail .cu-expandable-detail__fields {
+ .cu-marketplace-detail .cu-detail-summary__fields {
flex-direction: column;
flex-wrap: nowrap;
}
- .cu-connector-detail .cu-expandable-detail__description,
- .cu-connector-detail .cu-expandable-field,
- .cu-marketplace-row-detail .cu-expandable-field {
+ .cu-marketplace-detail .cu-detail-field {
flex: 0 0 auto;
width: 100%;
}
@@ -2640,60 +2514,49 @@ textarea.cu-input {
}
.cu-marketplace-table {
- min-width: 52rem;
- --cu-expandable-inset-left: calc(3rem + 0.85rem);
- --cu-expandable-inset-right: 4.75rem;
+ min-width: 74rem;
}
.cu-marketplace-table th:nth-child(1),
.cu-marketplace-table td:nth-child(1) {
- width: 3rem;
+ width: 14rem;
+}
+
+.cu-marketplace-table th:nth-child(2),
+.cu-marketplace-table td:nth-child(2) {
+ width: 18rem;
+ max-width: 18rem;
}
.cu-marketplace-table th:nth-child(3),
.cu-marketplace-table td:nth-child(3) {
- width: 7rem;
+ width: 8rem;
}
.cu-marketplace-table th:nth-child(4),
.cu-marketplace-table td:nth-child(4) {
- width: 7rem;
+ width: 12rem;
}
.cu-marketplace-table th:nth-child(5),
.cu-marketplace-table td:nth-child(5) {
- width: 4.75rem;
-}
-
-.cu-marketplace-actions {
- flex-wrap: nowrap;
- justify-content: flex-start;
-}
-
-.cu-marketplace-action-cell {
- padding-inline: var(--cu-space-1);
- white-space: nowrap;
-}
-
-.cu-marketplace-table td.cu-marketplace-action-cell:nth-last-child(2) {
- padding-right: 0.15rem;
-}
-
-.cu-marketplace-table td.cu-marketplace-action-cell:last-child {
- padding-left: 0.15rem;
+ width: 7rem;
}
-.cu-marketplace-table td:nth-child(4) {
- text-align: center;
+.cu-marketplace-table th:nth-child(6),
+.cu-marketplace-table td:nth-child(6) {
+ width: 9rem;
}
-.cu-marketplace-table td:nth-child(4) .cu-btn {
- max-width: 100%;
- padding-inline: var(--cu-space-1);
+.cu-marketplace-table th:nth-child(7),
+.cu-marketplace-table td:nth-child(7) {
+ width: 7rem;
}
-.cu-marketplace-table td:nth-child(5) {
- text-align: left;
+.cu-marketplace-table th:nth-child(8),
+.cu-marketplace-table td:nth-child(8) {
+ width: 4rem;
+ text-align: right;
}
.cu-marketplace-detail__overview {
@@ -2710,12 +2573,12 @@ textarea.cu-input {
width: 100%;
}
-.cu-marketplace-detail__overview > .cu-expandable-detail__fields {
+.cu-marketplace-detail__overview > .cu-detail-summary__fields {
flex: 0 0 auto;
width: 100%;
}
-.cu-marketplace-detail__description-block > .cu-expandable-detail__description {
+.cu-marketplace-detail__description-block > .cu-detail-summary__description {
order: 0;
width: 100%;
max-width: none;
@@ -9607,20 +9470,6 @@ textarea.cu-input {
font-weight: var(--cu-font-weight-bold);
}
-.cu-row-actions {
- display: flex;
- justify-content: flex-end;
- gap: 0.15rem;
-}
-
-.cu-row-actions--wrap {
- flex-wrap: wrap;
-}
-
-.cu-row-actions--nowrap {
- flex-wrap: nowrap;
-}
-
.cu-nowrap {
white-space: nowrap;
}
@@ -12605,7 +12454,7 @@ button.cu-gfs-tree__button:focus-visible,
max-height: 100%;
display: block;
border-radius: var(--cu-radius-sm);
- background: var(--cu-expandable-body-bg);
+ background: var(--cu-preview-body-bg);
}
.cu-gfs-markdown-preview-dialog__body {
diff --git a/control-ui/app/guardrails/[name]/page.tsx b/control-ui/app/guardrails/[name]/page.tsx
index 1979d3d00..18fe68487 100644
--- a/control-ui/app/guardrails/[name]/page.tsx
+++ b/control-ui/app/guardrails/[name]/page.tsx
@@ -231,14 +231,14 @@ export default function GuardrailDetailPage() {
<StatusBadge status={hook.status} />
</Row>
<Row label={target.kind}>
- <strong className="cu-expandable-field__code">{target.value}</strong>
+ <strong className="cu-detail-field__code">{target.value}</strong>
</Row>
<Row label="Path">{spec.path || '/'}</Row>
<Row label="Lifecycle points">{(spec.lifecyclePoints || []).join(', ') || '—'}</Row>
<Row label="Fail mode">{spec.failMode || '—'}</Row>
<Row label="Capabilities">
{spec.capabilities && spec.capabilities.length > 0 ? (
- <span className="cu-expandable-tags">
+ <span className="cu-detail-tags">
{spec.capabilities.map(c => (
<span key={c} className="cu-registry-tag">
{c}
@@ -250,7 +250,7 @@ export default function GuardrailDetailPage() {
)}
</Row>
<Row label="Observed digest">
- <strong className="cu-expandable-field__code">
+ <strong className="cu-detail-field__code">
{hook.status?.observedDigest || '—'}
</strong>
</Row>
@@ -295,7 +295,7 @@ export default function GuardrailDetailPage() {
>
<td>{a.name}</td>
<td>
- <span className="cu-expandable-tags">
+ <span className="cu-detail-tags">
{a.phases.map(p => (
<span key={p} className="cu-registry-tag">
{PHASE_LABEL[p] || p}
diff --git a/control-ui/app/registry/entries/[name]/[version]/page.tsx b/control-ui/app/registry/entries/[name]/[version]/page.tsx
index 97c4c3868..86b0b32bc 100644
--- a/control-ui/app/registry/entries/[name]/[version]/page.tsx
+++ b/control-ui/app/registry/entries/[name]/[version]/page.tsx
@@ -320,20 +320,20 @@ function RegistryEntryDetailContent() {
) : entry ? (
<div className="cu-card">
<div className="cu-card__body cu-marketplace-detail">
- <div className="cu-expandable-detail cu-marketplace-detail__overview">
+ <div className="cu-detail-summary cu-marketplace-detail__overview">
<div className="cu-marketplace-detail__description-block">
- <span className="cu-expandable-field__label">Description</span>
- <p className="cu-expandable-detail__description">
+ <span className="cu-detail-field__label">Description</span>
+ <p className="cu-detail-summary__description">
{entry.description || 'No description provided.'}
</p>
</div>
- <div className="cu-expandable-detail__fields">
- <div className="cu-expandable-field">
- <span className="cu-expandable-field__label">Version</span>
+ <div className="cu-detail-summary__fields">
+ <div className="cu-detail-field">
+ <span className="cu-detail-field__label">Version</span>
<span className="cu-code-text">{entry.version}</span>
</div>
- <div className="cu-expandable-field">
- <span className="cu-expandable-field__label">Visibility</span>
+ <div className="cu-detail-field">
+ <span className="cu-detail-field__label">Visibility</span>
{entry.visibility ? (
<span
className={`cu-registry-chip cu-registry-chip--visibility-${entry.visibility}`}
@@ -344,19 +344,19 @@ function RegistryEntryDetailContent() {
<span className="cu-muted">—</span>
)}
</div>
- <div className="cu-expandable-field">
+ <div className="cu-detail-field">
<span>{entry.category || 'Uncategorized'}</span>
</div>
- <div className="cu-expandable-field">
- <span className="cu-expandable-field__label">Type</span>
+ <div className="cu-detail-field">
+ <span className="cu-detail-field__label">Type</span>
<span className="cu-registry-type-meta">
{entry.server_mode
? `${entry.server_mode}${entry.transport ? ` / ${entry.transport}` : ''}`
: entry.recipe_type || '—'}
</span>
</div>
- <div className="cu-expandable-field">
- <span className="cu-expandable-field__label">Trust</span>
+ <div className="cu-detail-field">
+ <span className="cu-detail-field__label">Trust</span>
<span
className="cu-registry-chip"
style={{
@@ -368,8 +368,8 @@ function RegistryEntryDetailContent() {
{entry.trust_level.toUpperCase()}
</span>
</div>
- <div className="cu-expandable-field">
- <span className="cu-expandable-field__label">Verification</span>
+ <div className="cu-detail-field">
+ <span className="cu-detail-field__label">Verification</span>
<span
className={`cu-registry-chip cu-registry-chip--quality-${entry.quality_tier}`}
>
@@ -377,9 +377,9 @@ function RegistryEntryDetailContent() {
</span>
</div>
{entry.tags.length > 0 && (
- <div className="cu-expandable-field">
- <span className="cu-expandable-field__label">Tags</span>
- <div className="cu-expandable-tags">
+ <div className="cu-detail-field">
+ <span className="cu-detail-field__label">Tags</span>
+ <div className="cu-detail-tags">
{entry.tags.map(tag => (
<span key={tag} className="cu-registry-tag">
{tag}
diff --git a/control-ui/components/ContextTable.tsx b/control-ui/components/ContextTable.tsx
index 21e91557b..ade4dcd8d 100644
--- a/control-ui/components/ContextTable.tsx
+++ b/control-ui/components/ContextTable.tsx
@@ -170,7 +170,7 @@ export function ContextTable({
aria-label={`Open context ${name}`}
>
<td>
- <span className="cu-expandable-row__name">{displayName}</span>
+ <span className="cu-table__cell-name">{displayName}</span>
</td>
<td className="cu-table__cell-subtle">{name}</td>
<td className="cu-registry-description" title={item.spec?.description || '—'}>
diff --git a/control-ui/components/GuardrailHooksTable.tsx b/control-ui/components/GuardrailHooksTable.tsx
index 03a6d637a..7401e732a 100644
--- a/control-ui/components/GuardrailHooksTable.tsx
+++ b/control-ui/components/GuardrailHooksTable.tsx
@@ -219,7 +219,7 @@ export function GuardrailHooksTable({
aria-label={`View guardrail ${name}`}
>
<td>
- <span className="cu-expandable-row__name">{name}</span>
+ <span className="cu-table__cell-name">{name}</span>
</td>
<td>{lifecycle ? lifecycle : <span className="cu-muted">—</span>}</td>
<td>
diff --git a/control-ui/components/HostTable.tsx b/control-ui/components/HostTable.tsx
index af00c5687..053f5024d 100644
--- a/control-ui/components/HostTable.tsx
+++ b/control-ui/components/HostTable.tsx
@@ -283,7 +283,7 @@ export function HostTable({
aria-label={`Open agent ${name}`}
>
<td>
- <span className="cu-expandable-row__name">{displayName}</span>
+ <span className="cu-table__cell-name">{displayName}</span>
</td>
<td className="cu-table__cell-subtle">{name}</td>
<td>
diff --git a/control-ui/components/McpServerTable.tsx b/control-ui/components/McpServerTable.tsx
index ca808a14c..e60cdfcf0 100644
--- a/control-ui/components/McpServerTable.tsx
+++ b/control-ui/components/McpServerTable.tsx
@@ -336,7 +336,7 @@ export function McpServerTable({
{detailContent ? <div className="cu-card__body">{detailContent}</div> : null}
{isInitialLoad ? (
<div className="eft-table-viewport cu-table-wrap cu-connectors-table-wrap">
- <DataTable className="eft-table cu-table cu-table--header-band cu-expandable-table cu-connectors-table">
+ <DataTable className="eft-table cu-table cu-table--header-band cu-connectors-table">
<thead>
<TableHeaderRow columns={columns} />
</thead>
@@ -351,7 +351,7 @@ export function McpServerTable({
</div>
) : (
<div className="eft-table-viewport cu-table-wrap cu-connectors-table-wrap">
- <DataTable className="eft-table cu-table cu-table--header-band cu-expandable-table cu-connectors-table">
+ <DataTable className="eft-table cu-table cu-table--header-band cu-connectors-table">
<thead>
<TableHeaderRow columns={columns} />
</thead>
diff --git a/control-ui/components/RegistryCatalog.tsx b/control-ui/components/RegistryCatalog.tsx
index 3796024e8..40aa5acfa 100644
--- a/control-ui/components/RegistryCatalog.tsx
+++ b/control-ui/components/RegistryCatalog.tsx
@@ -326,7 +326,7 @@ export default function RegistryCatalog() {
/>
<MarketplaceTabs active="connectors" />
<div className="eft-table-viewport cu-table-wrap cu-marketplace-table-wrap">
- <DataTable className="eft-table cu-table cu-table--header-band cu-expandable-table cu-marketplace-table">
+ <DataTable className="eft-table cu-table cu-table--header-band cu-marketplace-table">
<thead>
<TableHeaderRow columns={columns} />
</thead>
diff --git a/control-ui/components/RowActions/index.tsx b/control-ui/components/RowActions/index.tsx
deleted file mode 100644
index ebd98c32d..000000000
--- a/control-ui/components/RowActions/index.tsx
+++ /dev/null
@@ -1,62 +0,0 @@
-'use client'
-
-import { IconChevronRight } from '@components/icons'
-import { Button } from '@components/ui'
-import { cn } from '@lib/cn'
-import { RowActionsMenu } from '../RowActionsMenu'
-import type { RowAction, RowActionKind, RowActionsProps } from './types'
-
-const KIND_ORDER: RowActionKind[] = ['utility', 'edit', 'destructive', 'inspect']
-
-/** Kinds that stay one click away even when the row overflows. */
-const ALWAYS_INLINE: RowActionKind[] = ['destructive', 'inspect']
-
-function byKind(a: RowAction, b: RowAction) {
- return KIND_ORDER.indexOf(a.kind) - KIND_ORDER.indexOf(b.kind)
-}
-
-/**
- * The single row-action surface for route tables. It fixes the order and the
- * affordance vocabulary and leaves the set of actions to the caller, because
- * rows legitimately differ: a file row has more operations than a plugin row,
- * and an unpriced model row cannot be deleted at all.
- */
-export function RowActions({ actions, className, overflowAfter = 3 }: RowActionsProps) {
- const ordered = actions.filter(action => !action.hidden).sort(byKind)
- const overflows = ordered.length > overflowAfter
-
- const collapsed = overflows ? ordered.filter(action => !ALWAYS_INLINE.includes(action.kind)) : []
- const inline = overflows ? ordered.filter(action => ALWAYS_INLINE.includes(action.kind)) : ordered
-
- return (
- <div className={cn('cu-row-actions', className)}>
- {collapsed.length > 0 ? (
- <RowActionsMenu
- ariaLabel="More actions"
- actions={collapsed.map(action => ({
- key: action.key,
- label: action.label,
- onClick: action.onSelect,
- disabled: action.disabled,
- }))}
- />
- ) : null}
- {inline.map(action => {
- const destructive = action.kind === 'destructive'
- return (
- <Button
- key={action.key}
- aria-label={action.label}
- disabled={action.disabled}
- icon
- onClick={action.onSelect}
- toolbar={!destructive}
- variant={destructive ? 'ghost-danger' : 'secondary'}
- >
- {action.kind === 'inspect' ? <IconChevronRight width={16} height={16} /> : action.icon}
- </Button>
- )
- })}
- </div>
- )
-}
diff --git a/control-ui/components/RowActions/types.ts b/control-ui/components/RowActions/types.ts
deleted file mode 100644
index 0185d034f..000000000
--- a/control-ui/components/RowActions/types.ts
+++ /dev/null
@@ -1,32 +0,0 @@
-import type { ReactNode } from 'react'
-
-/**
- * Row actions are ordered by kind, never by array position, so every route
- * table presents the same vocabulary in the same place:
- *
- * - `utility` non-mutating helpers (copy, download)
- * - `edit` opens an editor for the row
- * - `destructive` removes the row
- * - `inspect` opens the row's detail view; always the right-edge chevron
- */
-export type RowActionKind = 'utility' | 'edit' | 'destructive' | 'inspect'
-
-export type RowAction = {
- key: string
- kind: RowActionKind
- /** Required. Becomes the button's `aria-label`, and its text once overflowed. */
- label: string
- /** Omit for `inspect`: the chevron is supplied so every table opens details alike. */
- icon?: ReactNode
- onSelect: () => void
- disabled?: boolean
- /** Lets a row drop an affordance it cannot support in its current state. */
- hidden?: boolean
-}
-
-export type RowActionsProps = {
- actions: RowAction[]
- /** Beyond this many buttons, non-destructive/non-inspect actions collapse into a kebab. */
- overflowAfter?: number
- className?: string
-}
diff --git a/control-ui/components/__tests__/ContextTable.test.tsx b/control-ui/components/__tests__/ContextTable.test.tsx
index d46d208bd..ed240da13 100644
--- a/control-ui/components/__tests__/ContextTable.test.tsx
+++ b/control-ui/components/__tests__/ContextTable.test.tsx
@@ -50,7 +50,7 @@ describe('ContextTable', () => {
/>
)
- expect(screen.getAllByText('business')[0]).toHaveClass('cu-expandable-row__name')
+ expect(screen.getAllByText('business')[0]).toHaveClass('cu-table__cell-name')
expect(screen.getByText('Business context')).toHaveClass('cu-registry-description')
expect(container.querySelectorAll('thead th')).toHaveLength(5)
expect(screen.queryByRole('button', { name: 'business' })).not.toBeInTheDocument()
@@ -59,7 +59,7 @@ describe('ContextTable', () => {
it('renders the identifier (metadata.name) when displayName is blank/whitespace (R4-M1 / R1-L4)', () => {
// A displayName written out-of-band as whitespace (' ') must fall back to
// the identifier, not render a blank label. dev restructured the cell to a
- // non-link span (cu-expandable-row__name), so assert the observable rendered
+ // non-link span, so assert the observable rendered
// name text (T4), not a button role and not the intermediate spec value.
render(
<ContextTable
@@ -80,7 +80,7 @@ describe('ContextTable', () => {
)
// The visible name span renders the identifier, not a blank/whitespace label.
- expect(screen.getAllByText('business')[0]).toHaveClass('cu-expandable-row__name')
+ expect(screen.getAllByText('business')[0]).toHaveClass('cu-table__cell-name')
})
it('does not open a context from the row actions kebab', () => {
diff --git a/control-ui/components/__tests__/RowActions.test.tsx b/control-ui/components/__tests__/RowActions.test.tsx
deleted file mode 100644
index f36cd98ab..000000000
--- a/control-ui/components/__tests__/RowActions.test.tsx
+++ /dev/null
@@ -1,90 +0,0 @@
-import { afterEach, describe, expect, it, vi } from 'vitest'
-import { cleanup, render, screen } from '@testing-library/react'
-import { RowActions } from '../RowActions'
-import type { RowAction, RowActionKind } from '../RowActions/types'
-
-afterEach(cleanup)
-
-function action(key: string, kind: RowActionKind, label: string): RowAction {
- return { key, kind, label, icon: <span aria-hidden="true" />, onSelect: vi.fn() }
-}
-
-function labels() {
- return screen.getAllByRole('button').map(button => button.getAttribute('aria-label'))
-}
-
-describe('RowActions', () => {
- it('orders actions by kind, not by array order', () => {
- render(
- <RowActions
- overflowAfter={4}
- actions={[
- action('open', 'inspect', 'Open'),
- action('delete', 'destructive', 'Delete'),
- action('copy', 'utility', 'Copy'),
- action('edit', 'edit', 'Edit'),
- ]}
- />
- )
-
- expect(labels()).toEqual(['Copy', 'Edit', 'Delete', 'Open'])
- })
-
- it('omits hidden actions so a row can drop an affordance it cannot support', () => {
- render(
- <RowActions
- actions={[
- action('edit', 'edit', 'Edit'),
- { ...action('delete', 'destructive', 'Delete'), hidden: true },
- ]}
- />
- )
-
- expect(labels()).toEqual(['Edit'])
- })
-
- it('collapses all but destructive and inspect once past the overflow threshold', () => {
- render(
- <RowActions
- overflowAfter={3}
- actions={[
- action('copy', 'utility', 'Copy'),
- action('download', 'utility', 'Download'),
- action('edit', 'edit', 'Edit'),
- action('delete', 'destructive', 'Delete'),
- action('open', 'inspect', 'Open'),
- ]}
- />
- )
-
- // Delete stays reachable in one click; the rest move behind the kebab.
- expect(labels()).toEqual(['More actions', 'Delete', 'Open'])
- expect(screen.getByRole('button', { name: 'More actions' })).toHaveAttribute(
- 'aria-haspopup',
- 'menu'
- )
- })
-
- it('keeps every action inline when it fits within the threshold', () => {
- render(
- <RowActions
- overflowAfter={3}
- actions={[
- action('copy', 'utility', 'Copy'),
- action('edit', 'edit', 'Edit'),
- action('delete', 'destructive', 'Delete'),
- ]}
- />
- )
-
- expect(labels()).toEqual(['Copy', 'Edit', 'Delete'])
- })
-
- it('supplies the chevron for inspect so every table opens details the same way', () => {
- render(
- <RowActions actions={[{ key: 'open', kind: 'inspect', label: 'Open', onSelect: vi.fn() }]} />
- )
-
- expect(screen.getByRole('button', { name: 'Open' }).querySelector('svg')).toBeInTheDocument()
- })
-})
diff --git a/control-ui/e2e/qa-recorder-connector-rotation-demo.spec.ts b/control-ui/e2e/qa-recorder-connector-rotation-demo.spec.ts
index 67cbf3e0a..a54bbddc0 100644
--- a/control-ui/e2e/qa-recorder-connector-rotation-demo.spec.ts
+++ b/control-ui/e2e/qa-recorder-connector-rotation-demo.spec.ts
@@ -85,14 +85,13 @@ test.describe('demo: Control UI credential-rotation journey', () => {
await humanPause(page)
})
- await test.step('expand the connector row and open its Edit screen', async () => {
- const expandBtn = page.getByRole('button', { name: `Expand connector ${connectorName}` })
- await expect(expandBtn).toBeVisible({ timeout: 30_000 })
- await humanClick(page, expandBtn)
- await humanClick(
- page,
- page.getByRole('button', { name: `Edit connector ${connectorName}` })
- )
+ await test.step('open the connector detail screen from its row menu', async () => {
+ const actions = page.getByRole('button', {
+ name: `Actions for connector ${connectorName}`,
+ })
+ await expect(actions).toBeVisible({ timeout: 30_000 })
+ await humanClick(page, actions)
+ await humanClick(page, page.getByRole('menuitem', { name: 'View details' }))
await expect(
page.getByRole('heading', { name: `Edit Connector: ${connectorName}`, exact: true })
).toBeVisible({ timeout: 20_000 })
diff --git a/control-ui/e2e/qa-recorder-connectors.spec.ts b/control-ui/e2e/qa-recorder-connectors.spec.ts
index e65f3a80c..751c368b5 100644
--- a/control-ui/e2e/qa-recorder-connectors.spec.ts
+++ b/control-ui/e2e/qa-recorder-connectors.spec.ts
@@ -16,7 +16,7 @@ import {
// URL stays `/connectors` while app/mcp-servers/page.tsx renders <McpServerTable>.
// We assert the page shell (TablePanelHeader subtitle + panel title), which
// renders identically for the loading, populated, and empty states, then
-// best-effort expand the first connector row when one is present.
+// best-effort open the first connector row when one is present.
test.describe('optional QA recorder: Control UI connectors journey', () => {
test('records login and the connectors inventory page', async ({ page }, testInfo) => {
@@ -40,12 +40,13 @@ test.describe('optional QA recorder: Control UI connectors journey', () => {
// Panel title is "Connectors" while loading/empty, or "Connectors (N)" once populated.
await expect(page.locator('.cu-panel-title').filter({ hasText: /^Connectors/ })).toBeVisible()
- // Best-effort: if at least one connector row rendered, expand the first one to
- // exercise the detail panel. Guarded so the journey still passes on an empty inventory.
- const expandFirst = page.getByRole('button', { name: /^Expand connector / }).first()
- if (await expandFirst.isVisible({ timeout: 2_000 }).catch(() => false)) {
- await expandFirst.click()
- await expect(page.locator('.cu-connector-detail').first()).toBeVisible({
+ // Best-effort: if at least one connector rendered, use its row menu to open the
+ // dedicated detail/edit screen. Guarded so the journey still passes when empty.
+ const actions = page.getByRole('button', { name: /^Actions for connector / }).first()
+ if (await actions.isVisible({ timeout: 2_000 }).catch(() => false)) {
+ await actions.click()
+ await page.getByRole('menuitem', { name: 'View details' }).click()
+ await expect(page.getByRole('heading', { name: /^Edit Connector:/ })).toBeVisible({
timeout: 10_000,
})
}
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 0f597b5f1..aa2e26028 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.479",
+ "version": "0.1.480",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.479",
+ "version": "0.1.480",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-table-system": "file:../packages/frontend-table-system",
diff --git a/control-ui/package.json b/control-ui/package.json
index 31cb91d5a..98a1f95c6 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.479",
+ "version": "0.1.480",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",
diff --git a/packages/frontend-table-system/styles.css b/packages/frontend-table-system/styles.css
index fc08ab3c2..f9fc779b2 100644
--- a/packages/frontend-table-system/styles.css
+++ b/packages/frontend-table-system/styles.css
@@ -114,6 +114,9 @@
table-layout: auto;
width: 100%;
}
+.eft-table--wide {
+ min-width: 42rem;
+}
.eft-table thead th {
background: var(--eft-surface-muted);
border-bottom: 1px solid var(--eft-border);
diff --git a/profile-ui/app/globals.css b/profile-ui/app/globals.css
index db4ab8932..8b81a2644 100644
--- a/profile-ui/app/globals.css
+++ b/profile-ui/app/globals.css
@@ -1178,44 +1178,6 @@ code {
gap: 1rem;
}
-.members-table-wrap {
- width: 100%;
- overflow-x: auto;
- border: 1px solid var(--cu-border-subtle);
- border-radius: var(--cu-radius-sm);
-}
-
-.members-table {
- width: 100%;
- min-width: 42rem;
- border-collapse: collapse;
- font-size: 0.9rem;
-}
-
-.members-table th,
-.members-table td {
- padding: 0.75rem;
- border-bottom: 1px solid var(--cu-border-subtle);
- text-align: left;
- vertical-align: middle;
-}
-
-.members-table th {
- color: var(--cu-text-muted);
- font-size: 0.75rem;
- font-weight: 600;
- letter-spacing: 0.04em;
- text-transform: uppercase;
-}
-
-.members-table tbody tr:last-child td {
- border-bottom: 0;
-}
-
-.members-table tr[data-selected='true'] td {
- background: var(--cu-bg-elevated);
-}
-
.cu-btn__content {
display: inline-flex;
align-items: center;
diff --git a/profile-ui/app/members/[userId]/page.tsx b/profile-ui/app/members/[userId]/page.tsx
index 71c306b37..78bc51f35 100644
--- a/profile-ui/app/members/[userId]/page.tsx
+++ b/profile-ui/app/members/[userId]/page.tsx
@@ -221,8 +221,8 @@ export default function MemberDetailsPage() {
</p>
</div>
</div>
- <div className="eft-table-viewport members-table-wrap">
- <DataTable className="eft-table members-table">
+ <div className="eft-table-viewport">
+ <DataTable className="eft-table eft-table--wide">
<thead>
<tr>
<th>Team</th>
diff --git a/profile-ui/app/members/invite/page.tsx b/profile-ui/app/members/invite/page.tsx
index 281b93ee3..ff8a8a77e 100644
--- a/profile-ui/app/members/invite/page.tsx
+++ b/profile-ui/app/members/invite/page.tsx
@@ -273,8 +273,8 @@ function PermissionTable({
onRoleChange: (team: ManageableTeam, role: Role) => void
}) {
return (
- <div className="eft-table-viewport members-table-wrap">
- <DataTable className="eft-table members-table">
+ <div className="eft-table-viewport">
+ <DataTable className="eft-table eft-table--wide">
<thead>
<tr>
<th>Team</th>
diff --git a/profile-ui/app/members/page.tsx b/profile-ui/app/members/page.tsx
index 0055d679f..0218cca51 100644
--- a/profile-ui/app/members/page.tsx
+++ b/profile-ui/app/members/page.tsx
@@ -195,8 +195,8 @@ export default function MembersPage() {
<h2 className="section-title">Pending invitations</h2>
</div>
</div>
- <div className="eft-table-viewport members-table-wrap">
- <DataTable className="eft-table members-table">
+ <div className="eft-table-viewport">
+ <DataTable className="eft-table eft-table--wide">
<thead>
<tr>
<TableHeaderCell
@@ -259,8 +259,8 @@ export default function MembersPage() {
{state !== 'loading' ? (
<section className="section members-section">
- <div className="eft-table-viewport members-table-wrap">
- <DataTable className="eft-table members-table">
+ <div className="eft-table-viewport">
+ <DataTable className="eft-table eft-table--wide">
<thead>
<tr>
<TableHeaderCell
diff --git a/profile-ui/package-lock.json b/profile-ui/package-lock.json
index 385694665..d2e6cca97 100644
--- a/profile-ui/package-lock.json
+++ b/profile-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-profile-ui",
- "version": "0.1.127",
+ "version": "0.1.128",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-profile-ui",
- "version": "0.1.127",
+ "version": "0.1.128",
"dependencies": {
"@clerum/desktop-app-links": "file:../packages/desktop-app-links",
"@clerum/frontend-table-system": "file:../packages/frontend-table-system",
diff --git a/profile-ui/package.json b/profile-ui/package.json
index 66cf3f57a..e61f44139 100644
--- a/profile-ui/package.json
+++ b/profile-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-profile-ui",
- "version": "0.1.127",
+ "version": "0.1.128",
"private": true,
"scripts": {
"dev": "next dev",