Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(frontend): default empty table copy and bounded descriptions
Josué81792d0cec43
diff --git a/control-ui/components/TableEmptyRow/types.ts b/control-ui/components/TableEmptyRow/types.tsindex 63d7b4b97..2665606bb 100644--- a/control-ui/components/TableEmptyRow/types.ts+++ b/control-ui/components/TableEmptyRow/types.ts@@ -3,7 +3,7 @@ import type { ReactNode } from 'react'export type TableEmptyRowProps = {/** Number of columns to span. Must match the table's header row. */colSpan: number- message: ReactNode+ message?: ReactNode/** Offer this when the empty state is the result of a filter the user can undo. */action?: {label: stringdiff --git a/control-ui/components/TokenBudgetTable.tsx b/control-ui/components/TokenBudgetTable.tsxindex 5cd1e2500..b5b70b117 100644--- a/control-ui/components/TokenBudgetTable.tsx+++ b/control-ui/components/TokenBudgetTable.tsx@@ -158,11 +158,7 @@ export function TokenBudgetTable({) : filteredItems.length === 0 ? (<TableStateRowcolSpan={columns.length}- message={- normalizedSearch- ? 'No budgets match this search.'- : 'No token budgets defined yet. Create one to start tracking spend against a limit.'- }+ message={normalizedSearch ? 'No budgets match this search.' : undefined}/>) : (budgetSort.sortedRows.map((budget: TokenBudget) => (diff --git a/control-ui/components/__tests__/FrontendComponents.test.tsx b/control-ui/components/__tests__/FrontendComponents.test.tsxindex 1d0024831..adacedeff 100644--- a/control-ui/components/__tests__/FrontendComponents.test.tsx+++ b/control-ui/components/__tests__/FrontendComponents.test.tsx@@ -5,6 +5,8 @@ import {RowActionMenu,TableHeaderCell,TableRow,+ TableStateRow,+ TruncatedText,stableSortRows,} from '@clerum/frontend-components'@@ -88,6 +90,28 @@ describe('shared frontend components', () => {expect(onNavigate).toHaveBeenCalledTimes(2)})+ it('defaults empty table copy and exposes full truncated text', () => {+ const longDescription =+ 'This description is deliberately long enough to exceed the shared default bounded text length for table descriptions.'++ render(+ <DataTable>+ <tbody>+ <TableStateRow colSpan={2} />+ <tr>+ <td>+ <TruncatedText value={longDescription} />+ </td>+ </tr>+ </tbody>+ </DataTable>+ )++ expect(screen.getByText('No data')).toBeInTheDocument()+ expect(screen.getByText(/default bounde\.\.\./)).toBeInTheDocument()+ expect(screen.getByRole('tooltip')).toHaveTextContent(longDescription)+ })+it('opens one accessible action menu and executes its destructive action', () => {const onDelete = vi.fn()render(diff --git a/control-ui/package-lock.json b/control-ui/package-lock.jsonindex 01a43a1a2..19a211c46 100644--- a/control-ui/package-lock.json+++ b/control-ui/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-ui",- "version": "0.1.512",+ "version": "0.1.513","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-ui",- "version": "0.1.512",+ "version": "0.1.513","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/frontend-components": "file:../packages/frontend-components",diff --git a/control-ui/package.json b/control-ui/package.jsonindex c6cd16773..b6cde36f2 100644--- a/control-ui/package.json+++ b/control-ui/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-ui",- "version": "0.1.512",+ "version": "0.1.513","private": true,"scripts": {"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",diff --git a/docs/agents/frontend-style-rules.md b/docs/agents/frontend-style-rules.mdindex 163d67561..601a75f09 100644--- a/docs/agents/frontend-style-rules.md+++ b/docs/agents/frontend-style-rules.md@@ -106,7 +106,12 @@ application guidance that must be combined with this shared document.columns to size flexibly. Put secondary metadata such as descriptions,emails, providers, aliases, or namespaces in accurately named columns ratherthan stacking it under a primary label. Truncate bounded, non-critical text- only when its complete value remains accessibly available.+ only when its complete value remains accessibly available; use the shared+ bounded-text primitive for table descriptions unless a domain-specific+ control owns the full-value affordance.+- Let shared table empty states default to `No data`. Override that copy only+ when a search/filter, loading/error state, or domain-specific next action+ changes what the user needs to know.- Make ordinary record rows navigate to their dedicated detail route. Do notuse inline master/detail expansion for normal record tables; reserveexpansion or hierarchy for a genuinely specialized tree, file, permission,diff --git a/packages/frontend-components/src/index.tsx b/packages/frontend-components/src/index.tsxindex df148736c..7f839ced5 100644--- a/packages/frontend-components/src/index.tsx+++ b/packages/frontend-components/src/index.tsx@@ -9,6 +9,7 @@ import {type ThHTMLAttributes,useCallback,useEffect,+ useId,useLayoutEffect,useMemo,useRef,@@ -237,12 +238,12 @@ export function TableStateRow({action,colSpan,kind = 'empty',- message,+ message = 'No data',}: {action?: ReactNodecolSpan: numberkind?: 'loading' | 'empty' | 'error'- message: ReactNode+ message?: ReactNode}) {return (<tr>@@ -259,6 +260,37 @@ export function TableStateRow({)}+export function TruncatedText({+ className,+ maxLength = 80,+ value,+}: {+ className?: string+ maxLength?: number+ value: string | null | undefined+}) {+ const text = String(value || '').trim()+ const display = text || '-'+ const isTruncated = text.length > maxLength+ const visible = isTruncated ? `${text.slice(0, maxLength).trimEnd()}...` : display+ const tooltipId = useId()++ return (+ <span+ aria-describedby={isTruncated ? tooltipId : undefined}+ className={classNames('eft-truncated-text', className)}+ tabIndex={isTruncated ? 0 : undefined}+ >+ <span className="eft-truncated-text__value">{visible}</span>+ {isTruncated ? (+ <span className="eft-truncated-text__tooltip" id={tooltipId} role="tooltip">+ {text}+ </span>+ ) : null}+ </span>+ )+}+export type RowAction = {key: stringlabel: stringdiff --git a/packages/frontend-components/styles.css b/packages/frontend-components/styles.cssindex 6f25f718b..72f24a6c0 100644--- a/packages/frontend-components/styles.css+++ b/packages/frontend-components/styles.css@@ -211,6 +211,44 @@display: block;margin-top: 0.5rem;}+.eft-truncated-text {+ display: inline-block;+ max-width: 100%;+ min-width: 0;+ position: relative;+}+.eft-truncated-text__value {+ display: inline-block;+ max-width: 100%;+ overflow: hidden;+ text-overflow: ellipsis;+ vertical-align: bottom;+ white-space: nowrap;+}+.eft-truncated-text__tooltip {+ background: var(--eft-surface);+ border: 1px solid var(--eft-border);+ border-radius: 0.5rem;+ box-shadow: 0 0.75rem 2rem rgba(0, 0, 0, 0.35);+ color: var(--eft-text);+ display: none;+ font-size: 0.8125rem;+ left: 0;+ line-height: 1.45;+ max-width: min(28rem, 70vw);+ overflow-wrap: anywhere;+ padding: 0.625rem 0.75rem;+ position: absolute;+ text-align: left;+ top: calc(100% + 0.375rem);+ white-space: normal;+ width: max-content;+ z-index: 1000;+}+.eft-truncated-text:hover .eft-truncated-text__tooltip,+.eft-truncated-text:focus-within .eft-truncated-text__tooltip {+ display: block;+}.eft-row-actions {display: inline-flex;position: relative;