Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

refactor(control-ui): r3-l5 name connector callback onOpen

Josué81ba89ddf21c
diff --git a/control-ui/app/mcp-servers/page.tsx b/control-ui/app/mcp-servers/page.tsx
index 5d502bbfe..defc22a21 100644
--- a/control-ui/app/mcp-servers/page.tsx
+++ b/control-ui/app/mcp-servers/page.tsx
@@ -416,7 +416,7 @@ export default function McpServersPage() {
onRemoveFromAgents={removeConnectorFromAgents}
updatingAgentAccessKey={updatingAgentAccessKey}
onDelete={handleDelete}
- onEdit={server => router.push(CONTROL_ROUTES.connectors.detail(server.name))}
+ onOpen={server => router.push(CONTROL_ROUTES.connectors.detail(server.name))}
deletingKey={deletingKey}
onRefresh={loadAll}
onCreate={() => router.push(CONTROL_ROUTES.connectors.new)}
diff --git a/control-ui/components/McpServerTable.tsx b/control-ui/components/McpServerTable.tsx
index 5a1b70e52..dc24b88a5 100644
--- a/control-ui/components/McpServerTable.tsx
+++ b/control-ui/components/McpServerTable.tsx
@@ -95,7 +95,7 @@ export function McpServerTable({
onRemoveFromAgents,
updatingAgentAccessKey,
onDelete,
- onEdit,
+ onOpen,
deletingKey,
onRefresh,
onCreate,
@@ -354,9 +354,9 @@ export function McpServerTable({
const agentAccessBusy = updatingAgentAccessKey === key
return (
<TableRow
- className={onEdit ? 'cu-table__row cu-table__row--clickable' : undefined}
+ className={onOpen ? 'cu-table__row cu-table__row--clickable' : undefined}
key={key}
- onNavigate={onEdit ? () => onEdit({ namespace, name }) : undefined}
+ onNavigate={onOpen ? () => onOpen({ namespace, name }) : undefined}
>
<td>{name}</td>
<td className="cu-registry-description">
@@ -379,12 +379,12 @@ export function McpServerTable({
<RowActionsMenu
ariaLabel={`Actions for connector ${name}`}
actions={[
- ...(onEdit
+ ...(onOpen
? [
{
key: 'view',
label: 'View details',
- onClick: () => onEdit({ namespace, name }),
+ onClick: () => onOpen({ namespace, name }),
},
]
: []),
diff --git a/control-ui/components/McpServerTable.types.ts b/control-ui/components/McpServerTable.types.ts
index 5d9dc6e1b..fcc41fe2c 100644
--- a/control-ui/components/McpServerTable.types.ts
+++ b/control-ui/components/McpServerTable.types.ts
@@ -79,7 +79,7 @@ export type McpServerTableProps = {
onRemoveFromAgents?: (server: ServerRef, binding: ConnectorAgentBinding) => Promise<void>
updatingAgentAccessKey?: string | null
onDelete?: (server: ServerRef) => Promise<void>
- onEdit?: (server: ServerRef) => void
+ onOpen?: (server: ServerRef) => void
deletingKey?: string | null
onRefresh?: () => void
onCreate?: () => void
diff --git a/control-ui/components/__tests__/McpServerTable.test.tsx b/control-ui/components/__tests__/McpServerTable.test.tsx
index b31ebcc06..91457ff6a 100644
--- a/control-ui/components/__tests__/McpServerTable.test.tsx
+++ b/control-ui/components/__tests__/McpServerTable.test.tsx
@@ -326,15 +326,15 @@ describe('McpServerTable — connector access summaries', () => {
})
it('keeps connector endpoints searchable after removing the visible endpoint column', () => {
- const onEdit = vi.fn()
- render(<McpServerTable items={[makeItem({ name: 'airtable-server' })]} onEdit={onEdit} />)
+ const onOpen = vi.fn()
+ render(<McpServerTable items={[makeItem({ name: 'airtable-server' })]} onOpen={onOpen} />)
expect(screen.queryByRole('columnheader', { name: /Endpoint/i })).toBeNull()
fireEvent.change(screen.getByLabelText('Search connectors'), {
target: { value: 'brave-search.mcp-server' },
})
expect(screen.getByText('airtable-server')).toBeInTheDocument()
- expect(onEdit).not.toHaveBeenCalled()
+ expect(onOpen).not.toHaveBeenCalled()
})
it('renders an empty access state when no principals are mapped', () => {
@@ -516,11 +516,11 @@ describe('McpServerTable — agent membership', () => {
// ─────────────────────────────────────────────────────────────────────────────
describe('McpServerTable — row actions kebab', () => {
it('exposes Edit and Remove via a single kebab menu per row and routes the click to the matching handler', async () => {
- const onEdit = vi.fn()
+ const onOpen = vi.fn()
const onDelete = vi.fn().mockResolvedValue(undefined)
const items = [makeItem({ name: 'airtable-server' })]
- render(<McpServerTable items={items} onEdit={onEdit} onDelete={onDelete} />)
+ render(<McpServerTable items={items} onOpen={onOpen} onDelete={onDelete} />)
const trigger = screen.getByRole('button', { name: 'Actions for connector airtable-server' })
fireEvent.click(trigger)
@@ -530,7 +530,7 @@ describe('McpServerTable — row actions kebab', () => {
expect(deleteItem).toHaveClass('eft-row-actions__item--danger')
fireEvent.click(editItem)
- expect(onEdit).toHaveBeenCalledWith({ namespace: 'mcp-server', name: 'airtable-server' })
+ expect(onOpen).toHaveBeenCalledWith({ namespace: 'mcp-server', name: 'airtable-server' })
expect(onDelete).not.toHaveBeenCalled()
fireEvent.click(trigger)
@@ -546,7 +546,7 @@ describe('McpServerTable — row actions kebab', () => {
render(
<McpServerTable
items={items}
- onEdit={vi.fn()}
+ onOpen={vi.fn()}
onDelete={onDelete}
deletingKey="mcp-server/airtable-server"
/>
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 473e3b73e..1aac446d9 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.648",
+ "version": "0.1.649",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.648",
+ "version": "0.1.649",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index 503c70112..ac83997b3 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.648",
+ "version": "0.1.649",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",