Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(frontend-components): reset multi-select search on open
Josué88f5a9fc8d22
diff --git a/packages/frontend-components/src/edit/MultiSelectActionDialog.tsx b/packages/frontend-components/src/edit/MultiSelectActionDialog.tsxindex 10a41242c..fe4551a5b 100644--- a/packages/frontend-components/src/edit/MultiSelectActionDialog.tsx+++ b/packages/frontend-components/src/edit/MultiSelectActionDialog.tsx@@ -1,6 +1,6 @@'use client'-import { useId, useMemo, useState } from 'react'+import { useEffect, useId, useMemo, useRef, useState } from 'react'import type { ReactNode } from 'react'import { DialogShell } from './DialogShell'import type { MultiSelectActionDialogProps } from './types'@@ -27,6 +27,11 @@ export function MultiSelectActionDialog({}: MultiSelectActionDialogProps) {const searchId = useId()const [query, setQuery] = useState('')+ const previousOpen = useRef(false)+ useEffect(() => {+ if (open && !previousOpen.current) setQuery('')+ previousOpen.current = open+ }, [open])const normalizedQuery = query.trim().toLocaleLowerCase()const visibleItems = useMemo(() =>diff --git a/packages/frontend-components/src/edit/__tests__/MultiSelectActionDialog.test.tsx b/packages/frontend-components/src/edit/__tests__/MultiSelectActionDialog.test.tsxindex 539cf7380..36b989c94 100644--- a/packages/frontend-components/src/edit/__tests__/MultiSelectActionDialog.test.tsx+++ b/packages/frontend-components/src/edit/__tests__/MultiSelectActionDialog.test.tsx@@ -140,4 +140,31 @@ describe('MultiSelectActionDialog', () => {await user.type(within(dialog).getByRole('searchbox', { name: 'Search items' }), 'Gamma')expect(within(dialog).getByRole('checkbox', { name: 'Gamma' })).toBeInTheDocument()})++ it('clears the previous search query when reopened without changing selection', async () => {+ const user = userEvent.setup()+ const props = {+ actionLabel: 'Apply',+ items,+ onAction: vi.fn(),+ onDismiss: vi.fn(),+ onSelectedIdsChange: vi.fn(),+ selectedIds: ['gamma'],+ title: 'Choose records',+ }+ const { rerender } = render(<MultiSelectActionDialog {...props} open />)+ const dialog = await screen.findByRole('dialog', { name: 'Choose records' })+ const search = within(dialog).getByRole('searchbox', { name: 'Search items' })+ await user.type(search, 'alpha')+ expect(within(dialog).queryByRole('checkbox', { name: /Beta/ })).not.toBeInTheDocument()++ rerender(<MultiSelectActionDialog {...props} open={false} />)+ expect(screen.queryByRole('dialog', { name: 'Choose records' })).not.toBeInTheDocument()+ rerender(<MultiSelectActionDialog {...props} open />)++ const reopened = await screen.findByRole('dialog', { name: 'Choose records' })+ expect(within(reopened).getByRole('searchbox', { name: 'Search items' })).toHaveValue('')+ expect(within(reopened).getByRole('checkbox', { name: /Beta/ })).toBeInTheDocument()+ expect(within(reopened).getByRole('checkbox', { name: /Gamma/ })).toBeChecked()+ })})