Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

feat(control-ui): standardize model enable actions

Josué8d297f734a2b
diff --git a/control-ui/components/LlmDiscoveryPanel/index.tsx b/control-ui/components/LlmDiscoveryPanel/index.tsx
index 8ca2e9271..e66e6519c 100644
--- a/control-ui/components/LlmDiscoveryPanel/index.tsx
+++ b/control-ui/components/LlmDiscoveryPanel/index.tsx
@@ -2,6 +2,7 @@
import React, { useEffect, useMemo, useRef, useState } from 'react'
import {
+ ConfirmationDialog,
DataTable,
GroupedTableBody,
TableStateRow,
@@ -58,6 +59,9 @@ export function LlmDiscoveryPanel({
const [bulkEnabling, setBulkEnabling] = useState(false)
const [expandedProviders, setExpandedProviders] = useState<Set<string>>(new Set())
const [selectedIds, setSelectedIds] = useState<Set<string>>(new Set())
+ const [enableConfirmation, setEnableConfirmation] = useState<
+ { kind: 'single'; model: LlmAllowedModel } | { kind: 'bulk' } | null
+ >(null)
const statusRequestGeneration = useRef(0)
const isInitialLoad = loading && items.length === 0
@@ -260,6 +264,13 @@ export function LlmDiscoveryPanel({
showToast(message, { tone: 'error' })
}
+ function confirmEnable() {
+ const confirmation = enableConfirmation
+ setEnableConfirmation(null)
+ if (confirmation?.kind === 'single') void handleEnable(confirmation.model)
+ if (confirmation?.kind === 'bulk') void handleBulkEnable()
+ }
+
const reviewColumns: TableHeaderColumn[] = (
[
{
@@ -323,6 +334,28 @@ export function LlmDiscoveryPanel({
</>
}
subtitle="Newly synced models land here disabled. Enable only the models you want available to agents and runtime."
+ secondaryActions={
+ selectedCount > 0 ? (
+ <>
+ <button
+ type="button"
+ className="cu-btn cu-btn--ghost cu-btn--sm"
+ onClick={() => setSelectedIds(new Set())}
+ disabled={bulkEnabling}
+ >
+ Unselect all
+ </button>
+ <button
+ type="button"
+ className="cu-btn cu-btn--primary cu-btn--sm"
+ onClick={() => setEnableConfirmation({ kind: 'bulk' })}
+ disabled={bulkEnabling}
+ >
+ {bulkEnabling ? 'Enabling…' : `Enable ${selectedCount} selected`}
+ </button>
+ </>
+ ) : undefined
+ }
primaryAction={
<button
type="button"
@@ -374,20 +407,6 @@ export function LlmDiscoveryPanel({
</div>
</div>
- {selectedCount > 0 ? (
- <div className="cu-discovery-bulkbar">
- <span className="cu-muted">{selectedCount} selected</span>
- <button
- type="button"
- className="cu-btn cu-btn--primary cu-btn--sm"
- onClick={() => void handleBulkEnable()}
- disabled={bulkEnabling}
- >
- {bulkEnabling ? 'Enabling…' : `Enable ${selectedCount} selected`}
- </button>
- </div>
- ) : null}
-
<TableViewport className="cu-table-wrap cu-table-wrap--sticky-header">
<DataTable
className="eft-table cu-table cu-table--header-band cu-llm-review-table"
@@ -487,7 +506,7 @@ export function LlmDiscoveryPanel({
<button
type="button"
className="cu-btn cu-btn--primary cu-btn--sm"
- onClick={() => void handleEnable(model)}
+ onClick={() => setEnableConfirmation({ kind: 'single', model })}
disabled={pendingId === model.id || bulkEnabling}
>
{pendingId === model.id ? 'Enabling…' : 'Enable'}
@@ -502,6 +521,27 @@ export function LlmDiscoveryPanel({
</DataTable>
</TableViewport>
</div>
+ <ConfirmationDialog
+ open={enableConfirmation !== null}
+ onCancel={() => setEnableConfirmation(null)}
+ onConfirm={confirmEnable}
+ title={
+ enableConfirmation?.kind === 'single'
+ ? `Enable ${modelLabel(enableConfirmation.model)}?`
+ : `Enable ${selectedCount} selected models?`
+ }
+ description={
+ enableConfirmation?.kind === 'single'
+ ? 'This model will become available to agents and runtime.'
+ : `This will enable ${selectedCount} models. Each model is updated independently.`
+ }
+ confirmLabel={
+ enableConfirmation?.kind === 'single'
+ ? `Enable ${modelLabel(enableConfirmation.model)}`
+ : `Enable ${selectedCount} models`
+ }
+ pending={pendingId !== null || bulkEnabling}
+ />
</>
)
}
diff --git a/control-ui/components/__tests__/LlmDiscoveryPanel.test.tsx b/control-ui/components/__tests__/LlmDiscoveryPanel.test.tsx
index 3b2268ff9..7aa2f4016 100644
--- a/control-ui/components/__tests__/LlmDiscoveryPanel.test.tsx
+++ b/control-ui/components/__tests__/LlmDiscoveryPanel.test.tsx
@@ -122,12 +122,66 @@ describe('LlmDiscoveryPanel merged lifecycle workflow', () => {
fireEvent.click(screen.getByRole('button', { name: 'Expand OpenAI review models' }))
fireEvent.click(screen.getByRole('button', { name: 'Enable' }))
+ expect(api.updateLlmModel).not.toHaveBeenCalled()
+ expect(screen.getByRole('alertdialog')).toHaveTextContent('Enable OpenAI/gpt-5?')
+ fireEvent.click(screen.getByRole('button', { name: 'Enable OpenAI/gpt-5' }))
+
await waitFor(() =>
expect(api.updateLlmModel).toHaveBeenCalledWith('review-openai', { enabled: true })
)
expect(onRefresh).toHaveBeenCalledTimes(1)
})
+ it('cancels a single-model confirmation without mutation', () => {
+ render(
+ <LlmDiscoveryPanel
+ items={[reviewModel]}
+ loading={false}
+ onRefresh={vi.fn().mockResolvedValue(undefined)}
+ />
+ )
+ fireEvent.click(screen.getByRole('button', { name: 'Expand OpenAI review models' }))
+ fireEvent.click(screen.getByRole('button', { name: 'Enable' }))
+ fireEvent.click(screen.getByRole('button', { name: 'Cancel' }))
+ expect(api.updateLlmModel).not.toHaveBeenCalled()
+ })
+
+ it('converges selected actions into the header in the required order', () => {
+ render(
+ <LlmDiscoveryPanel
+ items={[reviewModel]}
+ loading={false}
+ onRefresh={vi.fn().mockResolvedValue(undefined)}
+ />
+ )
+ fireEvent.click(screen.getByRole('button', { name: 'Expand OpenAI review models' }))
+ fireEvent.click(screen.getByRole('checkbox', { name: 'Select OpenAI/gpt-5' }))
+ const actions = document.querySelector('.cu-table-panel__actions')
+ expect(
+ Array.from(actions?.querySelectorAll('button') ?? []).map(button => button.textContent)
+ ).toEqual(['Unselect all', 'Enable 1 selected', '', 'Sync catalog'])
+ expect(screen.queryByText('1 selected')).not.toBeInTheDocument()
+ })
+
+ it('confirms bulk enable by count and unselects without mutation', () => {
+ render(
+ <LlmDiscoveryPanel
+ items={[reviewModel]}
+ loading={false}
+ onRefresh={vi.fn().mockResolvedValue(undefined)}
+ />
+ )
+ fireEvent.click(screen.getByRole('button', { name: 'Expand OpenAI review models' }))
+ fireEvent.click(screen.getByRole('checkbox', { name: 'Select OpenAI/gpt-5' }))
+ fireEvent.click(screen.getByRole('button', { name: 'Enable 1 selected' }))
+ expect(screen.getByRole('alertdialog')).toHaveTextContent('Enable 1 selected models?')
+ expect(screen.getByRole('alertdialog')).not.toHaveTextContent('gpt-5')
+ fireEvent.click(screen.getByRole('button', { name: 'Cancel' }))
+ fireEvent.click(screen.getByRole('button', { name: 'Unselect all' }))
+ expect(api.updateLlmModel).not.toHaveBeenCalled()
+ expect(screen.queryByRole('button', { name: 'Enable 1 selected' })).not.toBeInTheDocument()
+ })
+
it('keeps the per-row enable action cell wide enough for its button', () => {
render(
<LlmDiscoveryPanel
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 08b7a16b4..fcf0ca3c0 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.615",
+ "version": "0.1.616",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.615",
+ "version": "0.1.616",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index cf3bcb7fa..89e22815e 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.615",
+ "version": "0.1.616",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",