Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(frontend-components): preserve absent secret draft state

Josué9303fbf5834d
diff --git a/packages/frontend-components/src/edit/SecretEditField.tsx b/packages/frontend-components/src/edit/SecretEditField.tsx
index 0dbd9e40a..f0170a912 100644
--- a/packages/frontend-components/src/edit/SecretEditField.tsx
+++ b/packages/frontend-components/src/edit/SecretEditField.tsx
@@ -30,7 +30,7 @@ export function SecretEditField({
onStateChange(
next
? { status: 'replaced', value: next }
- : state.status === 'replaced' || existingValue
+ : existingValue
? { status: 'cleared' }
: { status: 'untouched' }
)
diff --git a/packages/frontend-components/src/edit/__tests__/SecretEditField.test.tsx b/packages/frontend-components/src/edit/__tests__/SecretEditField.test.tsx
index e3b6e87e5..a8f9bc342 100644
--- a/packages/frontend-components/src/edit/__tests__/SecretEditField.test.tsx
+++ b/packages/frontend-components/src/edit/__tests__/SecretEditField.test.tsx
@@ -63,6 +63,32 @@ describe('SecretEditField', () => {
expect(screen.getByRole('button', { name: 'Restore' })).toBeDisabled()
})
+ it('restores a never-stored secret to untouched when a new draft is cleared', async () => {
+ const user = userEvent.setup()
+ const onStateChange = vi.fn()
+ function SecretHarness() {
+ const [state, setState] = useState<SecretEditState>({ status: 'untouched' })
+ return (
+ <SecretEditField
+ existingValue={false}
+ id="new-secret"
+ label="New secret"
+ onStateChange={next => {
+ onStateChange(next)
+ setState(next)
+ }}
+ state={state}
+ />
+ )
+ }
+ render(<SecretHarness />)
+ const field = screen.getByLabelText('New secret')
+ await user.type(field, 'draft-value')
+ expect(onStateChange).toHaveBeenLastCalledWith({ status: 'replaced', value: 'draft-value' })
+ await user.clear(field)
+ expect(onStateChange).toHaveBeenLastCalledWith({ status: 'untouched' })
+ })
+
it('restores the empty original state after drafting a new secret', async () => {
const user = userEvent.setup()
const onStateChange = vi.fn()