Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

style(control-ui): move connector secret edit form into the create flow panel

Miguelon Peluchon9352ffa9b787
diff --git a/control-ui/app/secrets/connector/[name]/edit/page.tsx b/control-ui/app/secrets/connector/[name]/edit/page.tsx
index 345d83a24..856308617 100644
--- a/control-ui/app/secrets/connector/[name]/edit/page.tsx
+++ b/control-ui/app/secrets/connector/[name]/edit/page.tsx
@@ -5,6 +5,7 @@ import { useParams, useRouter, useSearchParams } from 'next/navigation'
import { DataTable, TableViewport } from '@clerum/frontend-components'
import { AuthGate } from '@components/AuthGate'
import { BodyLoadingSkeleton } from '@components/BodyLoadingSkeleton'
+import { CreateFlowPanel } from '@components/CreateFlowPanel'
import { CreatePageHeader } from '@components/CreatePageHeader'
import { DashboardLayout } from '@components/DashboardLayout'
import { IconKey } from '@components/Sidebar/icons'
@@ -223,16 +224,18 @@ function EditConnectorSecretContent() {
return (
<AuthGate>
<DashboardLayout isDetailPage>
- <CreatePageHeader
- icon={<IconKey />}
- title={`Edit connector secret${secretName ? `: ${secretName}` : ''}`}
- subtitle="Rotate the values stored in this Secret. Values are write-only; only the keys you fill in are replaced."
- backLabel="Back to secrets"
- onBack={backToList}
- />
-
- <div className="cu-create-panel">
- <div className="cu-create-content">
+ <CreateFlowPanel
+ header={
+ <CreatePageHeader
+ icon={<IconKey />}
+ title={`Edit connector secret${secretName ? `: ${secretName}` : ''}`}
+ subtitle="Rotate the values stored in this Secret. Values are write-only; only the keys you fill in are replaced."
+ backLabel="Back to secrets"
+ onBack={backToList}
+ />
+ }
+ >
+ <div className="cu-connector-edit-form">
{loadError ? (
<div className="cu-banner cu-banner--error" role="alert">
{loadError}
@@ -273,122 +276,120 @@ function EditConnectorSecretContent() {
have been deleted.
</div>
) : (
- <div className="cu-connector-edit-form">
- <FormSection
- title="Rotate stored values"
- description={
- <>
- No connector references this Secret yet, so changes take effect for the next
- connector that attaches it. Values are write-only — only the keys you fill
- in are replaced or added; every other key already on the Secret is kept.
- </>
- }
- >
- <TableViewport className="cu-table-wrap">
- <DataTable className="eft-table cu-table">
- <thead>
+ <FormSection
+ title="Rotate stored values"
+ description={
+ <>
+ No connector references this Secret yet, so changes take effect for the next
+ connector that attaches it. Values are write-only — only the keys you fill in
+ are replaced or added; every other key already on the Secret is kept.
+ </>
+ }
+ >
+ <TableViewport className="cu-table-wrap">
+ <DataTable className="eft-table cu-table">
+ <thead>
+ <tr>
+ <th>Secret key</th>
+ </tr>
+ </thead>
+ <tbody>
+ {secretSummary.keys.length === 0 ? (
<tr>
- <th>Secret key</th>
+ <td>
+ <span className="cu-muted">No keys yet.</span>
+ </td>
</tr>
- </thead>
- <tbody>
- {secretSummary.keys.length === 0 ? (
- <tr>
+ ) : (
+ secretSummary.keys.map(key => (
+ <tr key={key}>
<td>
- <span className="cu-muted">No keys yet.</span>
+ <code>{key}</code>
</td>
</tr>
- ) : (
- secretSummary.keys.map(key => (
- <tr key={key}>
- <td>
- <code>{key}</code>
- </td>
- </tr>
- ))
- )}
- </tbody>
- </DataTable>
- </TableViewport>
-
- <form
- className="cu-connector-credentials-form cu-form-stack"
- onSubmit={event => {
- event.preventDefault()
- void saveDirectRotation()
- }}
- noValidate
- >
- {secretSummary.keys.map(key => (
- <Field key={key} label={key} htmlFor={`secret-key-${key}`}>
- <TextInput
- id={`secret-key-${key}`}
- type="password"
- name={key}
- autoComplete="new-password"
- placeholder="Leave blank to keep current value"
- value={keyValues[key] ?? ''}
- onChange={e =>
- setKeyValues(current => ({ ...current, [key]: e.target.value }))
- }
- disabled={saving}
- />
- </Field>
- ))}
+ ))
+ )}
+ </tbody>
+ </DataTable>
+ </TableViewport>
- {extraKeys.map(row => (
- <div className="cu-form-inline" key={row.id}>
- <TextInput
- monospace
- aria-label={`New key name ${row.id}`}
- value={row.key}
- onChange={e => updateExtraKey(row.id, 'key', e.target.value)}
- placeholder="NEW_API_KEY"
- disabled={saving}
- />
- <TextInput
- monospace
- aria-label={`New key value ${row.id}`}
- value={row.value}
- onChange={e => updateExtraKey(row.id, 'value', e.target.value)}
- placeholder="secret value"
- type="password"
- autoComplete="new-password"
- disabled={saving}
- />
- <Button
- type="button"
- onClick={() => removeExtraKey(row.id)}
- disabled={saving}
- >
- Remove
- </Button>
- </div>
- ))}
+ <form
+ className="cu-connector-credentials-form cu-form-stack"
+ onSubmit={event => {
+ event.preventDefault()
+ void saveDirectRotation()
+ }}
+ noValidate
+ >
+ {secretSummary.keys.map(key => (
+ <Field key={key} label={key} htmlFor={`secret-key-${key}`}>
+ <TextInput
+ id={`secret-key-${key}`}
+ type="password"
+ name={key}
+ autoComplete="new-password"
+ placeholder="Leave blank to keep current value"
+ value={keyValues[key] ?? ''}
+ onChange={e =>
+ setKeyValues(current => ({ ...current, [key]: e.target.value }))
+ }
+ disabled={saving}
+ />
+ </Field>
+ ))}
- <div>
- <Button type="button" onClick={addExtraKey} disabled={saving}>
- Add key
+ {extraKeys.map(row => (
+ <div className="cu-form-inline" key={row.id}>
+ <TextInput
+ monospace
+ aria-label={`New key name ${row.id}`}
+ value={row.key}
+ onChange={e => updateExtraKey(row.id, 'key', e.target.value)}
+ placeholder="NEW_API_KEY"
+ disabled={saving}
+ />
+ <TextInput
+ monospace
+ aria-label={`New key value ${row.id}`}
+ value={row.value}
+ onChange={e => updateExtraKey(row.id, 'value', e.target.value)}
+ placeholder="secret value"
+ type="password"
+ autoComplete="new-password"
+ disabled={saving}
+ />
+ <Button
+ type="button"
+ onClick={() => removeExtraKey(row.id)}
+ disabled={saving}
+ >
+ Remove
</Button>
</div>
+ ))}
- {saveError ? (
- <div className="cu-banner cu-banner--error" role="alert">
- {saveError}
- </div>
- ) : null}
+ <div>
+ <Button type="button" onClick={addExtraKey} disabled={saving}>
+ Add key
+ </Button>
+ </div>
- <div className="cu-create-actions">
- <Button type="button" onClick={backToList} disabled={saving}>
- Cancel
- </Button>
- <Button type="submit" variant="primary" disabled={saving}>
- {saving ? 'Saving…' : 'Save'}
- </Button>
+ {saveError ? (
+ <div className="cu-banner cu-banner--error" role="alert">
+ {saveError}
</div>
- </form>
- </FormSection>
- </div>
+ ) : null}
+
+ <div className="cu-create-actions">
+ <Button type="button" onClick={backToList} disabled={saving}>
+ Cancel
+ </Button>
+ <Button type="submit" variant="primary" disabled={saving}>
+ {saving ? 'Saving…' : 'Save'}
+ </Button>
+ </div>
+ </form>
+ </FormSection>
)
) : (
<>
@@ -416,26 +417,22 @@ function EditConnectorSecretContent() {
) : null}
{selected && secretMatches ? (
- <div className="cu-connector-edit-form">
- <UpdateConnectorCredentials
- key={selectedName}
- serverName={selectedName}
- envSecret={selectedEnvSecret}
- surface={resolveCredentialSurface(
- selected.status?.conditions,
- selected.spec as { managed?: boolean } | undefined
- )}
- recipeOwned={isRecipeOwned(
- selected.spec as { managed?: boolean } | undefined
- )}
- registryCredentialSource={resolveRegistryCredentialSource(selected.metadata)}
- />
- </div>
+ <UpdateConnectorCredentials
+ key={selectedName}
+ serverName={selectedName}
+ envSecret={selectedEnvSecret}
+ surface={resolveCredentialSurface(
+ selected.status?.conditions,
+ selected.spec as { managed?: boolean } | undefined
+ )}
+ recipeOwned={isRecipeOwned(selected.spec as { managed?: boolean } | undefined)}
+ registryCredentialSource={resolveRegistryCredentialSource(selected.metadata)}
+ />
) : null}
</>
)}
</div>
- </div>
+ </CreateFlowPanel>
</DashboardLayout>
</AuthGate>
)
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index e641cf936..1a9b6c5fb 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.749",
+ "version": "0.1.750",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.749",
+ "version": "0.1.750",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index ddf3215e6..5832e044a 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.749",
+ "version": "0.1.750",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",