Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): route table rows to detail roots

Josué93ff22feb770
diff --git a/control-ui/app/contexts/page.tsx b/control-ui/app/contexts/page.tsx
index d71e2afe4..b7b5a97e6 100644
--- a/control-ui/app/contexts/page.tsx
+++ b/control-ui/app/contexts/page.tsx
@@ -71,7 +71,7 @@ export default function ContextsPage() {
{error ? <div className="cu-banner cu-banner--error">{error}</div> : null}
<ContextTable
items={contexts}
- onView={context => router.push(CONTROL_ROUTES.contexts.connectors(context.name))}
+ onView={context => router.push(CONTROL_ROUTES.contexts.detail(context.name))}
onEdit={context => router.push(CONTROL_ROUTES.contexts.connectors(context.name))}
onDelete={handleDeleteContext}
deletingKey={deletingKey}
diff --git a/control-ui/app/hosts/page.tsx b/control-ui/app/hosts/page.tsx
index a1a96e45f..151f1ed5b 100644
--- a/control-ui/app/hosts/page.tsx
+++ b/control-ui/app/hosts/page.tsx
@@ -103,7 +103,7 @@ export default function HostsPage() {
{error ? <div className="cu-banner cu-banner--error">{error}</div> : null}
<HostTable
items={hosts}
- onOpen={host => router.push(CONTROL_ROUTES.agents.tab(host.name, 'overview'))}
+ onOpen={host => router.push(CONTROL_ROUTES.agents.detail(host.name))}
onOpenContext={contextName => {
const trimmed = contextName.trim()
if (trimmed) router.push(CONTROL_ROUTES.contexts.connectors(trimmed))
diff --git a/control-ui/components/ProfileAdminHome.tsx b/control-ui/components/ProfileAdminHome.tsx
index abf5acb95..ecd4433e3 100644
--- a/control-ui/components/ProfileAdminHome.tsx
+++ b/control-ui/components/ProfileAdminHome.tsx
@@ -252,11 +252,11 @@ export function ProfileAdminHome({ activeTab, highlightedAdminId = '' }: Profile
: 'Admins'
function openTeam(team: TeamListItem) {
- router.push(CONTROL_ROUTES.usersAndTeams.teamTab(team.id, 'members'))
+ router.push(CONTROL_ROUTES.usersAndTeams.team(team.id))
}
function openUser(user: AdminUser) {
- router.push(CONTROL_ROUTES.usersAndTeams.userTab(user.id, 'contact'))
+ router.push(CONTROL_ROUTES.usersAndTeams.user(user.id))
}
function openAdminAccessForUser(user: AdminUser) {
diff --git a/control-ui/components/__tests__/ProfileAdminHome.test.tsx b/control-ui/components/__tests__/ProfileAdminHome.test.tsx
index 2d918a9b0..6b262a600 100644
--- a/control-ui/components/__tests__/ProfileAdminHome.test.tsx
+++ b/control-ui/components/__tests__/ProfileAdminHome.test.tsx
@@ -141,15 +141,11 @@ describe('ProfileAdminHome — members invitations', () => {
const memberRow = await screen.findByLabelText('Open member Accepted Invitee')
fireEvent.click(memberRow)
- expect(mockPush).toHaveBeenCalledWith(
- '/users-and-teams/users/accepted-password-pending-user/contact'
- )
+ expect(mockPush).toHaveBeenCalledWith('/users-and-teams/users/accepted-password-pending-user')
mockPush.mockClear()
fireEvent.keyDown(memberRow, { key: 'Enter' })
- expect(mockPush).toHaveBeenCalledWith(
- '/users-and-teams/users/accepted-password-pending-user/contact'
- )
+ expect(mockPush).toHaveBeenCalledWith('/users-and-teams/users/accepted-password-pending-user')
})
it('does not open a member detail page from row action buttons', async () => {
@@ -209,11 +205,11 @@ describe('ProfileAdminHome — members invitations', () => {
const teamRow = await screen.findByLabelText('Open team Marketing')
fireEvent.click(teamRow)
- expect(mockPush).toHaveBeenCalledWith('/users-and-teams/teams/team-1/members')
+ expect(mockPush).toHaveBeenCalledWith('/users-and-teams/teams/team-1')
mockPush.mockClear()
fireEvent.keyDown(teamRow, { key: ' ' })
- expect(mockPush).toHaveBeenCalledWith('/users-and-teams/teams/team-1/members')
+ expect(mockPush).toHaveBeenCalledWith('/users-and-teams/teams/team-1')
})
it('does not open a team detail page from row action buttons', async () => {
diff --git a/control-ui/lib/__tests__/routeResolution.test.ts b/control-ui/lib/__tests__/routeResolution.test.ts
index f65ed0658..32588f10f 100644
--- a/control-ui/lib/__tests__/routeResolution.test.ts
+++ b/control-ui/lib/__tests__/routeResolution.test.ts
@@ -207,4 +207,23 @@ describe('CONTROL_ROUTES App Router resolution', () => {
])
)
})
+
+ it('resolves public detail roots and their default tab slugs', async () => {
+ const redirects = ((await nextConfig.redirects?.()) ?? []) as RouteRule[]
+ const rewrites = ((await nextConfig.rewrites?.()) ?? []) as RouteRule[]
+ const appRoutes = appRoutePatterns()
+
+ for (const pathname of [
+ CONTROL_ROUTES.usersAndTeams.user('user-1'),
+ CONTROL_ROUTES.usersAndTeams.userTab('user-1', 'contact'),
+ CONTROL_ROUTES.usersAndTeams.team('team-1'),
+ CONTROL_ROUTES.usersAndTeams.teamTab('team-1', 'members'),
+ CONTROL_ROUTES.agents.detail('agent-1'),
+ CONTROL_ROUTES.agents.tab('agent-1', 'overview'),
+ CONTROL_ROUTES.contexts.detail('context-1'),
+ CONTROL_ROUTES.contexts.connectors('context-1'),
+ ]) {
+ expect(resolvesToAppRoute(pathname, redirects, rewrites, appRoutes)).toBe(true)
+ }
+ })
})
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 19a211c46..0c17fc620 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.513",
+ "version": "0.1.514",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.513",
+ "version": "0.1.514",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index b6cde36f2..e8fbad401 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.513",
+ "version": "0.1.514",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",