Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(desktop): prevent same-millisecond profile ID collisions
Alfredo Lopez9581c90145da
diff --git a/desktop-app/src/__tests__/config.runtimeConfig.test.ts b/desktop-app/src/__tests__/config.runtimeConfig.test.tsindex 7e3f5f9c5..0cd3df094 100644--- a/desktop-app/src/__tests__/config.runtimeConfig.test.ts+++ b/desktop-app/src/__tests__/config.runtimeConfig.test.ts@@ -54,6 +54,64 @@ describe('desktop runtime config', () => {vi.resetModules()})+ it('keeps same-named profiles independent when saved in the same millisecond', async () => {+ tempUserDataDir = await fsp.mkdtemp(path.join(os.tmpdir(), 'evenfire-user-data-'))+ vi.doMock('electron', () => ({+ app: {+ getPath: vi.fn((name: string) =>+ name === 'userData' ? tempUserDataDir : path.dirname(tempUserDataDir || os.tmpdir())+ ),+ isPackaged: true,+ isReady: vi.fn(() => true),+ setName: vi.fn(),+ },+ }))+ const clock = vi.spyOn(Date, 'now').mockReturnValue(1_790_000_000_000)+ try {+ const runtimeConfig = await import('../config.js')+ const firstConfig = {+ appName: 'Example tenant',+ externalRestApiBaseUrl: 'https://first-api.example.test',+ rpcProxyBaseUrl: 'https://first-rpc.example.test',+ }+ const secondConfig = {+ appName: firstConfig.appName,+ externalRestApiBaseUrl: 'https://second-api.example.test',+ rpcProxyBaseUrl: 'https://second-rpc.example.test',+ }+ await runtimeConfig.saveDesktopRuntimeConfig(firstConfig)+ await runtimeConfig.saveDesktopRuntimeConfig(secondConfig)+ const options = runtimeConfig.getDesktopRuntimeConfigState().options+ const first = options.find(+ option => option.externalRestApiBaseUrl === firstConfig.externalRestApiBaseUrl+ )+ const second = options.find(+ option => option.externalRestApiBaseUrl === secondConfig.externalRestApiBaseUrl+ )+ expect(first).toBeDefined()+ expect(second).toBeDefined()+ expect(first!.id).not.toBe(second!.id)++ await runtimeConfig.selectDesktopRuntimeConfigOption(first!.id)+ expect(runtimeConfig.config.externalRestApiBaseUrl).toBe(firstConfig.externalRestApiBaseUrl)+ await runtimeConfig.deleteDesktopRuntimeConfigOption(first!.id)+ expect(runtimeConfig.getDesktopRuntimeConfigState().options).toContainEqual(+ expect.objectContaining({ id: second!.id, ...secondConfig })+ )++ vi.resetModules()+ const reloaded = await import('../config.js')+ expect(reloaded.getDesktopRuntimeConfigState().options).toContainEqual(+ expect.objectContaining({ id: second!.id, ...secondConfig })+ )+ expect(reloaded.getDesktopRuntimeConfigState().options).not.toContainEqual(+ expect.objectContaining({ id: first!.id })+ )+ } finally {+ clock.mockRestore()+ }+ })+it('keeps localhost selectable in packaged builds with prod env defaults', async () => {tempUserDataDir = await fsp.mkdtemp(path.join(os.tmpdir(), 'evenfire-user-data-'))process.env.EXTERNAL_REST_API_BASE_URL = 'https://example.com'diff --git a/desktop-app/src/config.ts b/desktop-app/src/config.tsindex 7454f9b82..4800d3629 100644--- a/desktop-app/src/config.ts+++ b/desktop-app/src/config.ts@@ -1,5 +1,5 @@import { app } from 'electron'-import { createHash } from 'node:crypto'+import { createHash, randomUUID } from 'node:crypto'import fs from 'node:fs'import fsp from 'node:fs/promises'import os from 'node:os'@@ -783,7 +783,7 @@ export async function saveDesktopRuntimeConfig(next: DesktopRuntimeConfig): Promconst filePath = nextProfileFilePath(directoryPath, validated.appName || DEFAULT_APP_NAME)const timestamp = new Date().toISOString()const profile: StoredRuntimeProfile = {- id: `${toAppSlug(validated.appName || DEFAULT_APP_NAME)}-${Date.now()}`,+ id: `${toAppSlug(validated.appName || DEFAULT_APP_NAME)}-${randomUUID()}`,appName: validated.appName?.trim() || DEFAULT_APP_NAME,filePath,createdAt: timestamp,