Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(profile-ui): handle ambiguous recovery outcomes

Josué977735b6ec0b
diff --git a/profile-ui/app/components/__tests__/InvitationClient.reset.test.tsx b/profile-ui/app/components/__tests__/InvitationClient.reset.test.tsx
index 9f3e94072..d7cfad18e 100644
--- a/profile-ui/app/components/__tests__/InvitationClient.reset.test.tsx
+++ b/profile-ui/app/components/__tests__/InvitationClient.reset.test.tsx
@@ -220,4 +220,38 @@ describe('InvitationClient verified password recovery', () => {
expect(mocks.checkAuth).not.toHaveBeenCalled()
expect(mocks.routerReplace).not.toHaveBeenCalled()
})
+
+ it('does not resubmit a reset proof after an ambiguous recovery outcome', async () => {
+ mocks.setupInvitationPasswordWithToken.mockRejectedValue(
+ new Error('503 Service Unavailable - recovery_outcome_unknown')
+ )
+ render(
+ <InvitationClient
+ invitationToken="verified-reset-proof"
+ initialInvitation={passwordReset}
+ initialError=""
+ />
+ )
+
+ fillPassword()
+ fireEvent.click(screen.getByRole('button', { name: 'Reset password' }))
+
+ expect(
+ await screen.findByText(
+ 'We could not confirm whether your password change completed. Try signing in with the new password. If that does not work, request a new reset link.',
+ { exact: true }
+ )
+ ).toBeTruthy()
+ expect(screen.queryByLabelText('Password')).toBeNull()
+ expect(screen.queryByRole('button', { name: 'Reset password' })).toBeNull()
+ expect(screen.getByRole('link', { name: 'Try signing in' }).getAttribute('href')).toBe(
+ PROFILE_ROUTES.login({ email: '[email protected]' })
+ )
+ expect(
+ screen.getByRole('link', { name: 'Request a new recovery link' }).getAttribute('href')
+ ).toBe(PROFILE_ROUTES.forgotPassword({ email: '[email protected]' }))
+ expect(mocks.setupInvitationPasswordWithToken).toHaveBeenCalledOnce()
+ expect(mocks.checkAuth).not.toHaveBeenCalled()
+ expect(mocks.routerReplace).not.toHaveBeenCalled()
+ })
})
diff --git a/profile-ui/app/invitations/[token]/InvitationClient.tsx b/profile-ui/app/invitations/[token]/InvitationClient.tsx
index 8e914d70b..7d13ba849 100644
--- a/profile-ui/app/invitations/[token]/InvitationClient.tsx
+++ b/profile-ui/app/invitations/[token]/InvitationClient.tsx
@@ -70,6 +70,20 @@ function statusForInvitation(invitation: InvitationPreview): string {
return `Accept your Evenfire invitation for ${teamLabel}.`
}
+function isAmbiguousRecoveryOutcome(value: unknown): boolean {
+ if (!(value instanceof Error)) return true
+ const message = value.message.replace(/^\d{3}\s+[A-Za-z ]+\s+-\s+/, '')
+ if (message === 'recovery_outcome_unknown') return true
+ if (value instanceof TypeError || value.name === 'SyntaxError') return true
+ const status = value.message.match(/^\s*(\d{3})\b/)
+ return Boolean(
+ status &&
+ Number(status[1]) >= 500 &&
+ !message.includes('authority_unavailable') &&
+ !message.includes('rate_limited')
+ )
+}
+
export function InvitationClient({
invitationToken,
initialInvitation,
@@ -87,6 +101,7 @@ export function InvitationClient({
const [confirmPassword, setConfirmPassword] = useState('')
const [submitting, setSubmitting] = useState<'accept' | 'password' | null>(null)
const [recoveryCommitted, setRecoveryCommitted] = useState(false)
+ const [recoveryOutcomeUnknown, setRecoveryOutcomeUnknown] = useState(false)
const [sessionCheckInFlight, setSessionCheckInFlight] = useState(false)
const actionInFlightRef = useRef(false)
@@ -101,6 +116,11 @@ export function InvitationClient({
setStatus(initialInvitation ? statusForInvitation(initialInvitation) : '')
}, [initialInvitation, initialError])
+ useEffect(() => {
+ setRecoveryCommitted(false)
+ setRecoveryOutcomeUnknown(false)
+ }, [invitationToken])
+
const invitationExpired = useMemo(() => {
if (!invitation || invitation.status !== 'pending') return false
return formatRemaining(invitation.expiresAt, now) === 'expired'
@@ -129,6 +149,9 @@ export function InvitationClient({
const profileLoginHref = PROFILE_ROUTES.login({
email: invitation?.email.trim().toLowerCase(),
})
+ const forgotPasswordHref = PROFILE_ROUTES.forgotPassword({
+ email: invitation?.email.trim().toLowerCase(),
+ })
const busy = submitting !== null
function friendlyInvitationError(value: unknown): string {
@@ -148,6 +171,9 @@ export function InvitationClient({
return 'Account recovery is temporarily busy. Please wait a moment and try again.'
if (message === 'authority_unavailable')
return 'Account recovery is temporarily unavailable. Please try again shortly.'
+ if (message === 'recovery_outcome_unknown') {
+ return 'We could not confirm whether your password change completed. Try signing in with the new password. If that does not work, request a new reset link.'
+ }
return message
}
@@ -232,7 +258,7 @@ export function InvitationClient({
!invitation ||
busy ||
actionInFlightRef.current ||
- (isPasswordReset && recoveryCommitted)
+ (isPasswordReset && (recoveryCommitted || recoveryOutcomeUnknown))
) {
return
}
@@ -275,7 +301,16 @@ export function InvitationClient({
passwordPending: false,
})
} catch (nextError) {
- setError(friendlyInvitationError(nextError))
+ if (isPasswordReset && isAmbiguousRecoveryOutcome(nextError)) {
+ setRecoveryOutcomeUnknown(true)
+ setPassword('')
+ setConfirmPassword('')
+ setError(
+ 'We could not confirm whether your password change completed. Try signing in with the new password. If that does not work, request a new reset link.'
+ )
+ } else {
+ setError(friendlyInvitationError(nextError))
+ }
} finally {
actionInFlightRef.current = false
setSubmitting(null)
@@ -373,6 +408,15 @@ export function InvitationClient({
Sign in instead
</a>
</div>
+ ) : isPasswordReset && recoveryOutcomeUnknown ? (
+ <div className="stack">
+ <a className="cu-btn cu-btn--primary" href={profileLoginHref}>
+ Try signing in
+ </a>
+ <a className="cu-btn" href={forgotPasswordHref}>
+ Request a new recovery link
+ </a>
+ </div>
) : (isPasswordReset && invitation.status === 'pending') ||
(invitation.status === 'accepted' && invitation.passwordPending) ? (
<div className="stack">
diff --git a/profile-ui/package-lock.json b/profile-ui/package-lock.json
index 23fd58353..db57b26b9 100644
--- a/profile-ui/package-lock.json
+++ b/profile-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-profile-ui",
- "version": "0.1.171",
+ "version": "0.1.172",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-profile-ui",
- "version": "0.1.171",
+ "version": "0.1.172",
"dependencies": {
"@clerum/desktop-app-links": "file:../packages/desktop-app-links",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/profile-ui/package.json b/profile-ui/package.json
index 9ca20129c..10c1e8fff 100644
--- a/profile-ui/package.json
+++ b/profile-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-profile-ui",
- "version": "0.1.171",
+ "version": "0.1.172",
"private": true,
"scripts": {
"dev": "next dev",