Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

test(hcc): pin non-404 retry-read as fatal (#472)

Alfredo Lopez9a45e8fbd178
diff --git a/host-context-controller/package-lock.json b/host-context-controller/package-lock.json
index b8019e259..6bf7bdca1 100644
--- a/host-context-controller/package-lock.json
+++ b/host-context-controller/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-host-context-controller",
- "version": "0.1.257",
+ "version": "0.1.258",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-host-context-controller",
- "version": "0.1.257",
+ "version": "0.1.258",
"license": "SEE LICENSE IN LICENSE",
"dependencies": {
"@clerum/image-policy": "file:../packages/image-policy",
diff --git a/host-context-controller/package.json b/host-context-controller/package.json
index 9a4977f96..e041cde2c 100644
--- a/host-context-controller/package.json
+++ b/host-context-controller/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-host-context-controller",
- "version": "0.1.257",
+ "version": "0.1.258",
"description": "Host Context Controller - provides McpServer CRDs to mcp-host via REST API",
"main": "dist/main.js",
"engines": {
diff --git a/host-context-controller/src/__tests__/replaceWithConflictRetryOrder.test.ts b/host-context-controller/src/__tests__/replaceWithConflictRetryOrder.test.ts
index 1528ce37e..e0147ac83 100644
--- a/host-context-controller/src/__tests__/replaceWithConflictRetryOrder.test.ts
+++ b/host-context-controller/src/__tests__/replaceWithConflictRetryOrder.test.ts
@@ -199,6 +199,62 @@ describe('replaceWithConflictRetry order and retry', () => {
expect(replace).toHaveBeenCalledOnce()
})
+ it.each([
+ { status: 403, form: 'code', error: { code: 403 } },
+ { status: 403, form: 'statusCode', error: { response: { statusCode: 403 } } },
+ { status: 500, form: 'code', error: { code: 500 } },
+ { status: 500, form: 'statusCode', error: { response: { statusCode: 500 } } },
+ ])(
+ 'TOCTOU-NP-6: replace 409 then second read $status ($form) still throws',
+ async ({ error }) => {
+ const read = vi.fn().mockResolvedValueOnce(existing).mockRejectedValueOnce(error)
+ const replace = vi.fn().mockRejectedValueOnce({ code: 409 })
+ const validateExisting = vi.fn()
+
+ await expect(
+ replaceWithConflictRetry({
+ description: 'Service "svc"',
+ logPrefix: '[Test]',
+ body: desired,
+ mergeExisting: preserveServiceAssignedFields,
+ isUpToDate: () => false,
+ validateExisting,
+ read,
+ replace,
+ })
+ ).rejects.toBe(error)
+
+ expect(read).toHaveBeenCalledTimes(2)
+ expect(validateExisting).toHaveBeenCalledOnce()
+ expect(replace).toHaveBeenCalledOnce()
+ expect(replace.mock.calls[0][0].metadata?.resourceVersion).toBe('9')
+ }
+ )
+
+ it('TOCTOU-NP-7: replace 409 then second-read network Error is rethrown', async () => {
+ const networkErr = new Error('socket hang up')
+ const read = vi.fn().mockResolvedValueOnce(existing).mockRejectedValueOnce(networkErr)
+ const replace = vi.fn().mockRejectedValueOnce({ code: 409 })
+ const validateExisting = vi.fn()
+
+ await expect(
+ replaceWithConflictRetry({
+ description: 'Service "svc"',
+ logPrefix: '[Test]',
+ body: desired,
+ mergeExisting: preserveServiceAssignedFields,
+ isUpToDate: () => false,
+ validateExisting,
+ read,
+ replace,
+ })
+ ).rejects.toBe(networkErr)
+
+ expect(read).toHaveBeenCalledTimes(2)
+ expect(validateExisting).toHaveBeenCalledOnce()
+ expect(replace).toHaveBeenCalledOnce()
+ })
+
it('RETRY-SVC-2: post-409 re-read that matches skips the second replace', async () => {
const drifted: k8s.V1Service = {
...existing,