Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): r3-l2 bypass clamp for opaque subtitles

Josué9ad651d62048
diff --git a/control-ui/components/TablePanelHeader/contentSemantics.ts b/control-ui/components/TablePanelHeader/contentSemantics.ts
index 0f72cfcf3..9031ac970 100644
--- a/control-ui/components/TablePanelHeader/contentSemantics.ts
+++ b/control-ui/components/TablePanelHeader/contentSemantics.ts
@@ -26,10 +26,11 @@ export function splitTitleContent(title: ReactNode): {
export function hasInteractiveDescendant(node: ReactNode): boolean {
if (!isValidElement<{ children?: ReactNode }>(node)) return false
- if (
- typeof node.type === 'string' &&
- ['a', 'button', 'input', 'select', 'textarea'].includes(node.type)
- ) {
+ if (node.type === Fragment) {
+ return Children.toArray(node.props.children).some(hasInteractiveDescendant)
+ }
+ if (typeof node.type !== 'string') return true
+ if (['a', 'button', 'input', 'select', 'textarea'].includes(node.type)) {
return true
}
return Children.toArray(node.props.children).some(hasInteractiveDescendant)
diff --git a/control-ui/components/__tests__/TablePanelHeaderInteractiveSubtitle.test.tsx b/control-ui/components/__tests__/TablePanelHeaderInteractiveSubtitle.test.tsx
new file mode 100644
index 000000000..42a92256c
--- /dev/null
+++ b/control-ui/components/__tests__/TablePanelHeaderInteractiveSubtitle.test.tsx
@@ -0,0 +1,17 @@
+import type { ReactNode } from 'react'
+import { describe, expect, it } from 'vitest'
+import { render, screen } from '@testing-library/react'
+import { TablePanelHeader } from '../TablePanelHeader'
+
+function WrappedButton({ children }: { children: ReactNode }) {
+ return <button type="button">{children}</button>
+}
+
+describe('TablePanelHeader interactive subtitles', () => {
+ it('does not clamp content supplied through a custom interactive component', () => {
+ render(<TablePanelHeader subtitle={<WrappedButton>Open guide</WrappedButton>} title="Help" />)
+
+ expect(screen.getByRole('button', { name: 'Open guide' })).toBeVisible()
+ expect(document.querySelector('.cu-table-panel__description')).toBeNull()
+ })
+})
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 5484f9994..1e35e9ea8 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.601",
+ "version": "0.1.602",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.601",
+ "version": "0.1.602",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index b6d3b6d2c..da8067df0 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.601",
+ "version": "0.1.602",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",