Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(desktop-app): report stale environment handoffs (R12-M4)

Josué9b69a04925b9
diff --git a/desktop-app/ui/src/hooks/domain/__tests__/useAuthController.desktopEnvironment.test.tsx b/desktop-app/ui/src/hooks/domain/__tests__/useAuthController.desktopEnvironment.test.tsx
index f063039fd..498acf4b6 100644
--- a/desktop-app/ui/src/hooks/domain/__tests__/useAuthController.desktopEnvironment.test.tsx
+++ b/desktop-app/ui/src/hooks/domain/__tests__/useAuthController.desktopEnvironment.test.tsx
@@ -639,6 +639,32 @@ describe('Desktop environment handoff', () => {
expect(mocks.logoutForEnvironmentMismatch).not.toHaveBeenCalled()
expect(mocks.selectRuntimeConfigForHandoff).not.toHaveBeenCalled()
expect(screen.getByTestId('pending-environment')).toHaveTextContent('none')
+ expect(mocks.setStatus).toHaveBeenCalledWith(
+ 'The desktop session changed while processing this link. Open it again.',
+ 'info'
+ )
+ })
+
+ it('reports a stale native environment selection instead of silently stopping', async () => {
+ render(<Probe />)
+ await waitFor(() => expect(screen.getByTestId('configuration-loaded')).toHaveTextContent('yes'))
+ mocks.loadSession.mockClear()
+ mocks.selectRuntimeConfigForHandoff.mockRejectedValueOnce(
+ new Error(
+ "Error invoking remote method 'auth:selectRuntimeConfigForHandoff': Error: stale_session_generation"
+ )
+ )
+
+ await dispatchDesktopEnvironmentLink({
+ ...targetEnvironment,
+ externalRestApiBaseUrl: `${targetEnvironment.externalRestApiBaseUrl}/api/v1`,
+ })
+
+ expect(mocks.setStatus).toHaveBeenCalledWith(
+ 'The desktop session changed while processing this link. Open it again.',
+ 'info'
+ )
+ expect(mocks.loadSession).not.toHaveBeenCalled()
})
it('logs out and selects the linked saved environment after switch confirmation', async () => {
diff --git a/desktop-app/ui/src/hooks/domain/desktopEnvironmentHandoff.ts b/desktop-app/ui/src/hooks/domain/desktopEnvironmentHandoff.ts
index 3fabb3b84..c2dbbe84a 100644
--- a/desktop-app/ui/src/hooks/domain/desktopEnvironmentHandoff.ts
+++ b/desktop-app/ui/src/hooks/domain/desktopEnvironmentHandoff.ts
@@ -91,7 +91,9 @@ export function createDesktopEnvironmentSetupHandler({
let linkInProgress = false
const ownsSessionGeneration = async (expectedSessionGeneration: number): Promise<boolean> => {
try {
- return (await getSessionGeneration()) === expectedSessionGeneration
+ if ((await getSessionGeneration()) === expectedSessionGeneration) return true
+ setStatus('The desktop session changed while processing this link. Open it again.', 'info')
+ return false
} catch {
setStatus('Could not verify the desktop session. Try opening the link again.', 'error')
return false
diff --git a/desktop-app/ui/src/hooks/domain/useAuthController.ts b/desktop-app/ui/src/hooks/domain/useAuthController.ts
index 4d2472d84..4b7094a42 100644
--- a/desktop-app/ui/src/hooks/domain/useAuthController.ts
+++ b/desktop-app/ui/src/hooks/domain/useAuthController.ts
@@ -432,6 +432,10 @@ export function useAuthController({
return selection
} catch (error) {
if (error instanceof Error && error.message.includes('stale_session_generation')) {
+ setStatus(
+ 'The desktop session changed while processing this link. Open it again.',
+ 'info'
+ )
return null
}
setStatus(