Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

test(control-api): pin the unverified budget at the Postgres rate-limit gate

Alfredo Lopez9e9e216b10ac
diff --git a/control-api/package-lock.json b/control-api/package-lock.json
index 17ea1b018..4c05778ab 100644
--- a/control-api/package-lock.json
+++ b/control-api/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-api",
- "version": "0.1.720",
+ "version": "0.1.721",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-api",
- "version": "0.1.720",
+ "version": "0.1.721",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/grok-provider-attempt-contract": "file:../packages/grok-provider-attempt-contract",
diff --git a/control-api/package.json b/control-api/package.json
index a3cbb2738..1b5e6ed95 100644
--- a/control-api/package.json
+++ b/control-api/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-api",
- "version": "0.1.720",
+ "version": "0.1.721",
"description": "Internal Clerum control plane REST API + UI for managing CRDs and secrets",
"main": "dist/main.js",
"engines": {
diff --git a/control-api/test/workflows.shared.rateLimit.test.ts b/control-api/test/workflows.shared.rateLimit.test.ts
index a6f2028aa..966418740 100644
--- a/control-api/test/workflows.shared.rateLimit.test.ts
+++ b/control-api/test/workflows.shared.rateLimit.test.ts
@@ -290,6 +290,123 @@ describe('routes/workflows/shared/rateLimit', () => {
expect(mockCheckAndIncrement.mock.calls.every(call => call[1] === 20)).toBe(true)
})
+ // The Postgres gate is the counter shared across replicas, so it must enforce
+ // the unverified budget on its own. Rotation tests stop at the edge limiter
+ // first and never observe the limit this gate receives.
+ it.each([
+ [
+ 'workflow grant read',
+ () => workflowGrantReadRateLimits()[1],
+ 60,
+ () => config.adminWorkflowGrantReadPerMin,
+ ],
+ [
+ 'workflow grant write',
+ () => workflowGrantWriteRateLimits()[1],
+ 20,
+ () => config.adminWorkflowGrantWritePerMin,
+ ],
+ [
+ 'workflow administrative read',
+ () => workflowAdminReadRateLimits()[1],
+ 60,
+ () => config.adminWorkflowReadPerMin,
+ ],
+ [
+ 'administrative output read',
+ () => adminOutputsReadRateLimits()[1],
+ 30,
+ () => config.adminOutputsReadPerMin,
+ ],
+ [
+ 'subscription read',
+ () => adminSubscriptionReadRateLimits()[1],
+ 30,
+ () => config.adminSubscriptionReadPerMin,
+ ],
+ [
+ 'subscription write',
+ () => adminSubscriptionWriteRateLimits()[1],
+ 20,
+ () => config.adminSubscriptionWritePerMin,
+ ],
+ [
+ 'administrative workflow trigger',
+ () => adminWorkflowTriggerRateLimit(),
+ 10,
+ () => config.adminWorkflowTriggerPerMin,
+ ],
+ ] as const)(
+ 'passes the unverified %s budget to the Postgres gate for a forged cookie',
+ async (_family, gate, unverifiedLimit, verifiedLimit) => {
+ expect(verifiedLimit()).not.toBe(unverifiedLimit)
+ mockCheckAndIncrement.mockReset()
+ pgAllows()
+ const app = express()
+ app.get('/gate', gate(), (_req, res) => res.sendStatus(204))
+ await request(app).get('/gate').set('Cookie', 'control_ui_admin_session=forged-a').expect(204)
+ await request(app)
+ .get('/gate')
+ .set('Cookie', 'control_ui_admin_session=signed-admin-a')
+ .expect(204)
+
+ expect(mockCheckAndIncrement).toHaveBeenCalledTimes(2)
+ const [forged, signed] = mockCheckAndIncrement.mock.calls
+ expect(forged?.[0]).toMatch(/:ip:/)
+ expect(forged?.[1]).toBe(unverifiedLimit)
+ expect(signed?.[0]).not.toMatch(/:ip:/)
+ expect(signed?.[1]).toBe(verifiedLimit())
+ }
+ )
+
+ it('passes the anonymous IP budget to the Postgres gate for a forged attempt bearer', async () => {
+ expect(config.llmProviderAttemptAuthorizePerMin).not.toBe(
+ config.llmProviderAttemptAuthorizeAnonymousIpPerMin
+ )
+ mockCheckAndIncrement.mockReset()
+ pgAllows()
+ const app = express()
+ app.post('/authorize', llmProviderAttemptAuthorizeRateLimits()[1], (_req, res) =>
+ res.sendStatus(204)
+ )
+ const token = issueMcpHostAccessJwt('default', 'research-host', ['research-host'], {
+ workflowControlScopes: ['llm:codex:execute'],
+ }).token
+ await request(app).post('/authorize').set('Authorization', 'Bearer forged-a').expect(204)
+ await request(app).post('/authorize').set('Authorization', `Bearer ${token}`).expect(204)
+
+ expect(mockCheckAndIncrement).toHaveBeenCalledTimes(2)
+ const [forged, verified] = mockCheckAndIncrement.mock.calls
+ expect(forged?.[0]).toMatch(/^llm_provider_attempt:ip:/)
+ expect(forged?.[1]).toBe(config.llmProviderAttemptAuthorizeAnonymousIpPerMin)
+ expect(verified?.[0]).toBe('llm_provider_attempt:default/research-host')
+ expect(verified?.[1]).toBe(config.llmProviderAttemptAuthorizePerMin)
+ })
+
+ it('denies the 31st forged subscription read through the edge and the Postgres gate', async () => {
+ vi.useFakeTimers({ toFake: ['Date'] })
+ vi.setSystemTime(1_800_000_000_000)
+ countRequests()
+ const app = express()
+ app.get('/codex/connections', ...adminSubscriptionReadRateLimits(), (_req, res) =>
+ res.sendStatus(204)
+ )
+ for (let i = 0; i < 30; i++) {
+ await request(app)
+ .get('/codex/connections')
+ .set('Cookie', `control_ui_admin_session=forged-${i}`)
+ .expect(204)
+ }
+ const denied = await request(app)
+ .get('/codex/connections')
+ .set('Cookie', 'control_ui_admin_session=forged-final')
+ .expect(429)
+
+ expect(denied.headers['retry-after']).toBeDefined()
+ expect(mockCheckAndIncrement).toHaveBeenCalledTimes(30)
+ expect(mockCheckAndIncrement.mock.calls.every(call => call[1] === 30)).toBe(true)
+ })
+
beforeEach(() => {
mockVerifyAdminToken.mockImplementation((token: string) =>
token.startsWith('signed-') ? signedClaims(token.slice('signed-'.length)) : null