Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

test(minikube): harden branch profile certification gates

Alfredo Lopeza02b0991f0f7
diff --git a/scripts/minikube/full-setup.sh b/scripts/minikube/full-setup.sh
index 99f0b25b2..ea64d749b 100755
--- a/scripts/minikube/full-setup.sh
+++ b/scripts/minikube/full-setup.sh
@@ -515,6 +515,53 @@ validate_setup_deadline MINIKUBE_SETUP_DOCKER_TIMEOUT_SECONDS "${MINIKUBE_SETUP_
exit 1
}
+# Acquire the branch-owned mutation lease before the first profile status probe.
+# A standalone full setup may classify a partial profile as destructive and
+# delete it, so ownership and serialization must be established before any
+# status/start/delete operation can touch Minikube.
+SETUP_LOCK_CLEANUP_DONE=false
+K8S_API_POLICY_TMP_DIR=""
+cleanup_setup_lock() {
+ local status="${1:-$?}" cleanup_status=0
+ if [ "$SETUP_LOCK_CLEANUP_DONE" = true ]; then
+ return "$status"
+ fi
+ SETUP_LOCK_CLEANUP_DONE=true
+ trap - EXIT
+ trap '' INT TERM
+ if [ -n "${K8S_API_POLICY_TMP_DIR:-}" ] && [ -d "${K8S_API_POLICY_TMP_DIR}" ]; then
+ rm -rf -- "${K8S_API_POLICY_TMP_DIR}" || cleanup_status=1
+ fi
+ t2_lock_release "$status" || cleanup_status=$?
+ if [ "$status" -eq 0 ] && [ "$cleanup_status" -ne 0 ]; then
+ status="$cleanup_status"
+ fi
+ return "$status"
+}
+handle_setup_signal() {
+ local signal="$1" status
+ case "$signal" in
+ INT) status=130 ;;
+ TERM) status=143 ;;
+ *) status=1 ;;
+ esac
+ cleanup_setup_lock "$status" || status=$?
+ exit "$status"
+}
+handle_setup_exit() {
+ local status=$?
+ cleanup_setup_lock "$status" || status=$?
+ exit "$status"
+}
+trap handle_setup_exit EXIT
+trap 'handle_setup_signal INT' INT
+trap 'handle_setup_signal TERM' TERM
+t2_require_commands
+t2_repo_metadata
+t2_profile_scope
+t2_mutation_lock
+export T2_PROJECT_DIR T2_PROFILE T2_CONTEXT T2_PROFILE_ROOT T2_PROFILE_ENV T2_PORTS_ENV T2_SKIP_LOCK T2_LOCK_TOKEN
+
run_setup_with_deadline() {
local label="$1" timeout_seconds="$2"
shift 2
@@ -748,51 +795,9 @@ fi
ok "Cluster '${PROFILE}' is reachable"
maybe_exit_after_cluster_step
-SETUP_LOCK_CLEANUP_DONE=false
-K8S_API_POLICY_TMP_DIR=""
-cleanup_setup_lock() {
- local status="${1:-$?}" cleanup_status=0
- if [ "$SETUP_LOCK_CLEANUP_DONE" = true ]; then
- return "$status"
- fi
- SETUP_LOCK_CLEANUP_DONE=true
- trap - EXIT
- trap '' INT TERM
- if [ -n "${K8S_API_POLICY_TMP_DIR:-}" ] && [ -d "${K8S_API_POLICY_TMP_DIR}" ]; then
- rm -rf -- "${K8S_API_POLICY_TMP_DIR}" || cleanup_status=1
- fi
- t2_lock_release "$status" || cleanup_status=$?
- if [ "$status" -eq 0 ] && [ "$cleanup_status" -ne 0 ]; then
- status="$cleanup_status"
- fi
- return "$status"
-}
-handle_setup_signal() {
- local signal="$1" status
- case "$signal" in
- INT) status=130 ;;
- TERM) status=143 ;;
- *) status=1 ;;
- esac
- cleanup_setup_lock "$status" || status=$?
- exit "$status"
-}
-handle_setup_exit() {
- local status=$?
- cleanup_setup_lock "$status" || status=$?
- exit "$status"
-}
-trap handle_setup_exit EXIT
-trap 'handle_setup_signal INT' INT
-trap 'handle_setup_signal TERM' TERM
-t2_require_commands
-t2_repo_metadata
-t2_profile_scope
t2_profile_status
t2_context_check
t2_profile_context_identity_check
-t2_mutation_lock
-export T2_PROJECT_DIR T2_PROFILE T2_CONTEXT T2_PROFILE_ROOT T2_PROFILE_ENV T2_PORTS_ENV T2_SKIP_LOCK T2_LOCK_TOKEN
# ======================================================================
# Step 3: Namespaces + CRDs
diff --git a/scripts/minikube/pre-gate-incremental.sh b/scripts/minikube/pre-gate-incremental.sh
index b2c8cd3b9..271a03aed 100755
--- a/scripts/minikube/pre-gate-incremental.sh
+++ b/scripts/minikube/pre-gate-incremental.sh
@@ -108,13 +108,19 @@ incremental_use_minikube_docker() {
fi
if ! env_script="$(incremental_run_with_deadline incremental-docker-env \
"${INCREMENTAL_RUNTIME_TIMEOUT_SECONDS}" \
- minikube -p "${PROFILE}" docker-env --shell bash)"; then
+ minikube -p "${PROFILE}" docker-env --shell bash)" || \
+ [[ -z "${env_script}" ]] || \
+ ! grep -Eq '(^|[[:space:]])export[[:space:]]+DOCKER_HOST=' <<<"${env_script}"; then
# >&2 because this runs inside a command substitution on the baseline
# path, where anything on stdout would be captured AS the baseline.
- log "ERROR: could not point Docker at minikube's daemon; a shadow build would land in the wrong daemon" >&2
+ log "ERROR: DOCKER_ENV_UNRESOLVED: could not point Docker at minikube's daemon; a shadow build would land in the wrong daemon" >&2
exit 1
fi
eval "${env_script}"
+ if [[ -z "${DOCKER_HOST:-}" ]]; then
+ log "ERROR: DOCKER_ENV_UNRESOLVED: minikube docker-env did not set DOCKER_HOST" >&2
+ exit 1
+ fi
unset DOCKER_API_VERSION 2>/dev/null || true
INCREMENTAL_DOCKER_ENV_APPLIED=true
}
diff --git a/scripts/minikube/profile-owner.sh b/scripts/minikube/profile-owner.sh
index 537d5c444..f44e81573 100755
--- a/scripts/minikube/profile-owner.sh
+++ b/scripts/minikube/profile-owner.sh
@@ -107,6 +107,7 @@ profile_owner_validate_profile_name() {
profile_owner_validate_ports() {
local ports_env="${1:-}"
+ local require_complete="${2:-false}"
if [[ ! -f "${ports_env}" || ! -r "${ports_env}" || -L "${ports_env}" ]]; then
profile_owner_error PROFILE_PORTS_MISSING "persisted ports are missing, unreadable, or a symlink: ${ports_env}"
return 1
@@ -117,7 +118,7 @@ profile_owner_validate_ports() {
fi
local validation_error
- validation_error="$(awk -F= '
+ validation_error="$(awk -F= -v require_complete="${require_complete}" '
function fail(message) { print message; exit 1 }
{
key = $1
@@ -130,6 +131,47 @@ profile_owner_validate_ports() {
if (values["PORT_BASE"] < 20000 || values["PORT_BASE"] > 38999)
fail("PORT_BASE is outside the branch-profile allocation range")
+ if (require_complete == "true") {
+ port_specs = "CONTROL_UI_PORT:0 PROFILE_UI_PORT:1 MCP_HOST_PORT:80 REGISTRY_API_PORT:85 CONTROL_API_PORT:90 EXTERNAL_REST_API_PORT:91 MEMBER_REGISTRATION_SERVICE_PORT:92 RPC_PROXY_PORT:94 WORKFLOW_APPROVAL_READER_PORT:98"
+ port_count = split(port_specs, ports, " ")
+ for (port_index = 1; port_index <= port_count; port_index++) {
+ split(ports[port_index], spec, ":")
+ key = spec[1]
+ if (!(key in values))
+ fail(key " is required for schema-v2 branch-profile ports")
+ expected_port = values["PORT_BASE"] + spec[2]
+ if (values[key] != expected_port)
+ fail(key " does not match PORT_BASE + " spec[2])
+ }
+
+ url_specs = "CONTROL_UI_URL:CONTROL_UI_PORT PROFILE_UI_URL:PROFILE_UI_PORT PROFILE_UI_BASE_URL:PROFILE_UI_PORT CONTROL_API_URL:CONTROL_API_PORT EXTERNAL_REST_API_URL:EXTERNAL_REST_API_PORT MEMBER_REGISTRATION_SERVICE_URL:MEMBER_REGISTRATION_SERVICE_PORT RPC_PROXY_URL:RPC_PROXY_PORT REGISTRY_API_URL:REGISTRY_API_PORT WORKFLOW_APPROVAL_READER_URL:WORKFLOW_APPROVAL_READER_PORT MCP_HOST_URL:MCP_HOST_PORT"
+ url_count = split(url_specs, urls, " ")
+ for (url_index = 1; url_index <= url_count; url_index++) {
+ split(urls[url_index], spec, ":")
+ key = spec[1]
+ port_key = spec[2]
+ expected_url = "http://127.0.0.1:" values[port_key]
+ if (!(key in values))
+ fail(key " is required for schema-v2 branch-profile ports")
+ if (values[key] != expected_url && values[key] != expected_url "/")
+ fail(key " does not match " port_key " and the loopback host")
+ }
+
+ allowed["PORT_BASE"] = 1
+ for (port_index = 1; port_index <= port_count; port_index++) {
+ split(ports[port_index], spec, ":")
+ allowed[spec[1]] = 1
+ }
+ for (url_index = 1; url_index <= url_count; url_index++) {
+ split(urls[url_index], spec, ":")
+ allowed[spec[1]] = 1
+ }
+ for (key in values) {
+ if (!(key in allowed))
+ fail(key " is not allowed in schema-v2 branch-profile ports")
+ }
+ }
+
for (key in values) {
value = values[key]
if (key ~ /_PORT$/) {
@@ -258,7 +300,11 @@ profile_owner_validate_selection() {
fi
fi
- profile_owner_validate_ports "${ports_env}" || return 1
+ if [[ "${schema}" == 2 ]]; then
+ profile_owner_validate_ports "${ports_env}" true || return 1
+ else
+ profile_owner_validate_ports "${ports_env}" false || return 1
+ fi
PROFILE_OWNER_SCHEMA_VERSION="${schema}"
PROFILE_OWNER_WORKTREE_ID="${worktree_id}"
diff --git a/scripts/minikube/pull-images.sh b/scripts/minikube/pull-images.sh
index 9c582a8a8..1aedb0ce2 100755
--- a/scripts/minikube/pull-images.sh
+++ b/scripts/minikube/pull-images.sh
@@ -281,9 +281,12 @@ pull_one() {
return 0
fi
if [ "$MINIKUBE_MULTI_NODE" = true ]; then
- docker_cli_run_public "minikube-image-load-alias-${name}" \
+ if ! docker_cli_run_public "minikube-image-load-alias-${name}" \
"$MINIKUBE_DOCKER_BUILD_TIMEOUT_SECONDS" \
- minikube -p "$PROFILE" image load "$local_ref" >/dev/null 2>&1 || true
+ minikube -p "$PROFILE" image load "$local_ref" >/dev/null 2>&1; then
+ printf '%s' "$ghcr_ref (alias load to ${local_ref})" > "${STATUS_DIR}/${slot}.failed"
+ return 0
+ fi
fi
printf '%s\t%s' "$ghcr_ref" "$local_ref" > "${STATUS_DIR}/${slot}.done"
diff --git a/scripts/minikube/t2-common.sh b/scripts/minikube/t2-common.sh
index 813cf8dcc..98bfa860e 100755
--- a/scripts/minikube/t2-common.sh
+++ b/scripts/minikube/t2-common.sh
@@ -40,6 +40,12 @@ fi
T2_TIMEOUT_SECONDS="$T2_TIMEOUT_SECONDS"
if [ -z "$T2_TIMEOUT_SECONDS" ]; then T2_TIMEOUT_SECONDS="$T2_TIMEOUT"; fi
if [ -z "$T2_TIMEOUT_SECONDS" ]; then T2_TIMEOUT_SECONDS=180; fi
+T2_RUNTIME_TIMEOUT_SECONDS="$T2_RUNTIME_TIMEOUT_SECONDS"
+if [ -z "$T2_RUNTIME_TIMEOUT_SECONDS" ]; then T2_RUNTIME_TIMEOUT_SECONDS=60; fi
+T2_RUNTIME_KILL_GRACE_SECONDS="$T2_RUNTIME_KILL_GRACE_SECONDS"
+if [ -z "$T2_RUNTIME_KILL_GRACE_SECONDS" ]; then T2_RUNTIME_KILL_GRACE_SECONDS=5; fi
+T2_DEADLINE_RUNNER="$T2_DEADLINE_RUNNER"
+if [ -z "$T2_DEADLINE_RUNNER" ]; then T2_DEADLINE_RUNNER="$T2_SCRIPT_DIR/run-with-deadline.mjs"; fi
T2_PROFILE_ROOT="$T2_PROFILE_ROOT"
if [ -z "$T2_PROFILE_ROOT" ]; then T2_PROFILE_ROOT="$CLERUM_PROFILE_CACHE_ROOT"; fi
if [ -z "$T2_PROFILE_ROOT" ]; then T2_PROFILE_ROOT="$HOME/.cache/clerum/minikube-profiles"; fi
@@ -89,6 +95,8 @@ T2_EVIDENCE_DIR=""
T2_EVIDENCE_FILE=""
T2_EVIDENCE_KIND="$T2_EVIDENCE_KIND"
if [ -z "$T2_EVIDENCE_KIND" ]; then T2_EVIDENCE_KIND=certification; fi
+T2_HEALTHCHECK_PENDING="$T2_HEALTHCHECK_PENDING"
+if [ -z "$T2_HEALTHCHECK_PENDING" ]; then T2_HEALTHCHECK_PENDING=false; fi
T2_LOCK_HELD=false
T2_LOCK_RELEASED=false
T2_LOCK_TOKEN="$T2_LOCK_TOKEN"
@@ -146,22 +154,58 @@ t2_fail() {
return 1
}
+t2_validate_runtime_deadline() {
+ if ! [[ "$T2_RUNTIME_TIMEOUT_SECONDS" =~ ^[1-9][0-9]*$ ]] ||
+ [ "$T2_RUNTIME_TIMEOUT_SECONDS" -gt 300 ]; then
+ T2_NEXT_COMMAND='set T2_RUNTIME_TIMEOUT_SECONDS to an integer from 1 to 300, then re-run T2'
+ t2_fail DEVELOPMENT_SCOPE_REQUIRED \
+ 'T2_RUNTIME_TIMEOUT_SECONDS must be an integer from 1 to 300'
+ return 1
+ fi
+ if ! [[ "$T2_RUNTIME_KILL_GRACE_SECONDS" =~ ^[1-9][0-9]*$ ]] ||
+ [ "$T2_RUNTIME_KILL_GRACE_SECONDS" -gt 60 ]; then
+ T2_NEXT_COMMAND='set T2_RUNTIME_KILL_GRACE_SECONDS to an integer from 1 to 60, then re-run T2'
+ t2_fail DEVELOPMENT_SCOPE_REQUIRED \
+ 'T2_RUNTIME_KILL_GRACE_SECONDS must be an integer from 1 to 60'
+ return 1
+ fi
+ if [ ! -f "$T2_DEADLINE_RUNNER" ]; then
+ T2_NEXT_COMMAND='restore scripts/minikube/run-with-deadline.mjs, then re-run T2'
+ t2_fail LOCAL_DEPENDENCY_MISSING \
+ "bounded Minikube/Kubernetes runtime helper is missing: $T2_DEADLINE_RUNNER"
+ return 1
+ fi
+}
+
+t2_bounded_command() {
+ local label="$1" timeout_seconds="$2"
+ shift 2
+ node "$T2_DEADLINE_RUNNER" \
+ --timeout-seconds "$timeout_seconds" \
+ --heartbeat-seconds 20 \
+ --kill-grace-seconds "$T2_RUNTIME_KILL_GRACE_SECONDS" \
+ --label "$label" -- "$@"
+}
+
t2_require_commands() {
local command_name
- for command_name in git kubectl minikube python3 shasum awk sed find ps; do
+ for command_name in git kubectl minikube node python3 shasum awk sed find ps; do
if ! command -v "$command_name" >/dev/null 2>&1; then
T2_NEXT_COMMAND="install or enable $command_name, then re-run make minikube-t2-preflight"
t2_fail LOCAL_DEPENDENCY_MISSING "required local dependency is unavailable: $command_name"
fi
done
+ t2_validate_runtime_deadline
}
t2_kc() {
- kubectl --context="$T2_CONTEXT" "$@"
+ t2_bounded_command t2-kubectl "$T2_RUNTIME_TIMEOUT_SECONDS" \
+ kubectl --context="$T2_CONTEXT" "$@"
}
t2_mk() {
- minikube -p "$T2_PROFILE" "$@"
+ t2_bounded_command t2-minikube "$T2_RUNTIME_TIMEOUT_SECONDS" \
+ minikube -p "$T2_PROFILE" "$@"
}
t2_require_explicit_context() {
@@ -1033,6 +1077,49 @@ t2_evidence_init() {
t2_evidence_write preflight RUNNING ''
}
+t2_prior_targeted_health_pending() {
+ local pending
+ pending="$(
+ CERTIFICATION_ROOT="$T2_EVIDENCE_ROOT" \
+ EXPECTED_REPOSITORY="$T2_PROJECT_DIR" EXPECTED_BRANCH="$T2_BRANCH" \
+ EXPECTED_HEAD="$T2_HEAD" EXPECTED_WORKTREE_ID="$T2_WORKTREE_ID" \
+ EXPECTED_PROFILE="$T2_PROFILE" EXPECTED_CONTEXT="$T2_CONTEXT" \
+ EXPECTED_GATE_ID="$T2_GATE_ID" python3 - <<'PY'
+import json
+import os
+from pathlib import Path
+
+root = Path(os.environ["CERTIFICATION_ROOT"])
+expected = {
+ "repository": os.environ["EXPECTED_REPOSITORY"],
+ "branch": os.environ["EXPECTED_BRANCH"],
+ "head": os.environ["EXPECTED_HEAD"],
+ "worktreeId": os.environ["EXPECTED_WORKTREE_ID"],
+ "profile": os.environ["EXPECTED_PROFILE"],
+ "context": os.environ["EXPECTED_CONTEXT"],
+ "gateId": os.environ["EXPECTED_GATE_ID"],
+}
+candidates = []
+for candidate in root.glob("*/evidence.json"):
+ try:
+ data = json.loads(candidate.read_text())
+ stamp = candidate.stat().st_mtime_ns
+ except (OSError, ValueError):
+ continue
+ if data.get("certificationVersion") != 1 or data.get("evidenceKind") != "certification":
+ continue
+ if all(data.get(key, "") == value for key, value in expected.items()):
+ candidates.append((stamp, str(candidate), data))
+if not candidates:
+ print("false")
+else:
+ _, _, latest = max(candidates)
+ print("true" if latest.get("targetedHealthPending") is True else "false")
+PY
+ )" || return 1
+ printf '%s' "$pending"
+}
+
t2_evidence_write() {
local phase="$1" status="$2" detail="$3" file
[ -n "$T2_EVIDENCE_FILE" ] || return 0
@@ -1042,6 +1129,7 @@ t2_evidence_write() {
T2_ORIGIN_DEV="$T2_ORIGIN_DEV" T2_MERGE_BASE="$T2_MERGE_BASE" \
T2_WORKTREE_ID="$T2_WORKTREE_ID" T2_RUN_ID="$T2_RUN_ID" T2_GATE_ID="$T2_GATE_ID" \
T2_PROFILE="$T2_PROFILE" T2_CONTEXT="$T2_CONTEXT" T2_CLUSTER_FINGERPRINT="$T2_CLUSTER_FINGERPRINT" \
+ T2_HEALTHCHECK_PENDING="$T2_HEALTHCHECK_PENDING" \
T2_PROFILE_STATUS="$T2_PROFILE_STATUS" T2_PROFILE_HEALTHY="$T2_PROFILE_HEALTHY" \
T2_EVIDENCE_DIR="$T2_EVIDENCE_DIR" T2_EVIDENCE_KIND="$T2_EVIDENCE_KIND" \
T2_IMAGE_MANIFEST="$T2_IMAGE_MANIFEST" T2_IMAGE_SOURCE="$T2_IMAGE_SOURCE" T2_IMAGE_TAG="$T2_IMAGE_TAG" \
@@ -1104,6 +1192,7 @@ prior.update({
"localLogDirectory": os.path.join(os.environ.get("T2_EVIDENCE_DIR", ""), "logs"),
"imageSource": os.environ.get("T2_IMAGE_SOURCE", ""),
"imageTag": os.environ.get("T2_IMAGE_TAG", ""),
+ "targetedHealthPending": os.environ.get("T2_HEALTHCHECK_PENDING", "false") == "true",
"phase": os.environ.get("PHASE", ""),
"status": os.environ.get("STATUS", ""),
"detail": detail,
diff --git a/scripts/minikube/t2.sh b/scripts/minikube/t2.sh
index d89cd4b9d..33affc033 100755
--- a/scripts/minikube/t2.sh
+++ b/scripts/minikube/t2.sh
@@ -212,6 +212,11 @@ run_bootstrap_or_reconcile() {
return 1
;;
esac
+ if [ "$T2_PLAN_STATE" = targeted-sync ]; then
+ # The transition is now complete; a user-facing health journey is an
+ # outstanding obligation until it passes on a later evidence write.
+ T2_HEALTHCHECK_PENDING=true
+ fi
t2_evidence_write transition PASS \
"$T2_PLAN_STATE duration=$((SECONDS - phase_started_seconds))s"
}
@@ -355,12 +360,12 @@ validate_healthcheck_contract() {
return 1
fi
- if [ "$T2_PLAN_STATE" = targeted-sync ]; then
+ if [ "$T2_PLAN_STATE" = targeted-sync ] || [ "$T2_HEALTHCHECK_PENDING" = true ]; then
T2_HEALTHCHECK_REQUIRED=true
if [ -z "$T2_HEALTHCHECK_COMMAND" ]; then
T2_NEXT_COMMAND='set T2_HEALTHCHECK_COMMAND to the affected service user-facing health journey, then re-run T2'
t2_fail PROFILE_UNHEALTHY \
- 'targeted sync requires a profile-owned user-facing health command before mutation'
+ 'targeted sync requires a profile-owned user-facing health command before certification'
return 1
fi
fi
@@ -388,6 +393,7 @@ run_healthcheck_if_requested() {
bash -c "$T2_HEALTHCHECK_COMMAND" || health_status=$?
if [ "$health_status" -eq 0 ]; then
T2_HEALTH_STATUS=PASS
+ T2_HEALTHCHECK_PENDING=false
t2_evidence_write Health PASS \
"profile-owned user-facing health command passed; required=$T2_HEALTHCHECK_REQUIRED duration=$((SECONDS - phase_started_seconds))s"
else
@@ -441,6 +447,15 @@ main() {
t2_context_check
fi
t2_mutation_lock
+ local prior_health_pending
+ prior_health_pending="$(t2_prior_targeted_health_pending)" || {
+ T2_NEXT_COMMAND='repair or restore the local exact-head T2 evidence directory, then re-run T2'
+ t2_fail CERTIFICATION_REQUIRED 'could not determine whether a targeted-sync health obligation is pending'
+ return 1
+ }
+ if [ "$prior_health_pending" = true ]; then
+ T2_HEALTHCHECK_PENDING=true
+ fi
t2_evidence_init
run_t1_local_preflight
@@ -488,6 +503,13 @@ main() {
run_np08_hcc_authorization
run_healthcheck_if_requested
run_playwright_if_requested
+ # Health and Playwright run after the planner's initial ownership scan. A
+ # forward can disappear, be replaced, or lose its binding during either
+ # journey, so the exact PID/start-time/argv record must be revalidated before
+ # publishing the final certification.
+ if ! t2_process_check; then
+ return 1
+ fi
t2_evidence_write complete PASS "T0=$T2_T0_STATUS T1=$T2_T1_STATUS T2=$T2_T2_STATUS NP08_HCC_AUTHORIZATION=$T2_NP08_HCC_AUTHORIZATION_STATUS Health=$T2_HEALTH_STATUS Playwright=$T2_PLAYWRIGHT_STATUS"
printf 'MINIKUBE_T2_PASS\n'
diff --git a/scripts/tests/test-minikube-full-setup.sh b/scripts/tests/test-minikube-full-setup.sh
index d178585f6..daeeaad40 100755
--- a/scripts/tests/test-minikube-full-setup.sh
+++ b/scripts/tests/test-minikube-full-setup.sh
@@ -8,10 +8,50 @@ FAIL=0
pass() { echo "PASS: $1"; }
fail() { echo "FAIL: $1"; FAIL=1; }
+write_test_profile_metadata() {
+ local root="$1" profile="clerum-full-setup-fixture"
+ local profile_dir="$root/profiles/$profile"
+ local branch short_sha
+ branch="$(git -C "$REPO_ROOT" branch --show-current)"
+ short_sha="$(git -C "$REPO_ROOT" rev-parse --short=8 HEAD)"
+ mkdir -p "$profile_dir"
+ printf 'PROFILE=%s\nBRANCH=%s\nSHA_SHORT=%s\nDIRTY=false\nREPO_DIR=%s\n' \
+ "$profile" "$branch" "$short_sha" "$REPO_ROOT" >"$profile_dir/profile.env"
+ test_loopback_url() { printf 'http://%s:%s' 127.0.0.1 "$1"; }
+ cat >"$profile_dir/ports.env" <<EOF_PORTS
+PORT_BASE=28117
+CONTROL_UI_PORT=28117
+PROFILE_UI_PORT=28118
+MCP_HOST_PORT=28197
+REGISTRY_API_PORT=28202
+CONTROL_API_PORT=28207
+EXTERNAL_REST_API_PORT=28208
+MEMBER_REGISTRATION_SERVICE_PORT=28209
+RPC_PROXY_PORT=28211
+WORKFLOW_APPROVAL_READER_PORT=28215
+CONTROL_UI_URL=$(test_loopback_url 28117)
+PROFILE_UI_URL=$(test_loopback_url 28118)
+PROFILE_UI_BASE_URL=$(test_loopback_url 28118)
+CONTROL_API_URL=$(test_loopback_url 28207)
+EXTERNAL_REST_API_URL=$(test_loopback_url 28208)
+MEMBER_REGISTRATION_SERVICE_URL=$(test_loopback_url 28209)
+RPC_PROXY_URL=$(test_loopback_url 28211)
+REGISTRY_API_URL=$(test_loopback_url 28202)
+WORKFLOW_APPROVAL_READER_URL=$(test_loopback_url 28215)
+MCP_HOST_URL=$(test_loopback_url 28197)
+EOF_PORTS
+ TEST_PROFILE="$profile"
+ TEST_PROFILE_ROOT="$root/profiles"
+ TEST_PROFILE_ENV="$profile_dir/profile.env"
+ TEST_PORTS_ENV="$profile_dir/ports.env"
+ TEST_LOCK_ROOT="$root/locks"
+}
+
assert_broken_profile_is_recreated() {
local tmp log_file
tmp="$(mktemp -d)"
log_file="$tmp/ops.log"
+ write_test_profile_metadata "$tmp"
cat > "$tmp/docker" <<'STUB'
#!/usr/bin/env bash
@@ -113,12 +153,15 @@ STUB
if PATH="$tmp:$PATH" \
TEST_LOG_FILE="$log_file" \
TEST_STATE_DIR="$tmp/state" \
+ MINIKUBE_PROFILE="$TEST_PROFILE" \
+ T2_PROFILE_ROOT="$TEST_PROFILE_ROOT" T2_PROFILE_ENV="$TEST_PROFILE_ENV" \
+ T2_PORTS_ENV="$TEST_PORTS_ENV" T2_LOCK_ROOT="$TEST_LOCK_ROOT" \
MINIKUBE_SETUP_EXIT_AFTER_CLUSTER=true \
MINIKUBE_RECREATE_PROFILE=true \
- CONFIRM_PROFILE=clerum-test \
+ CONFIRM_PROFILE="$TEST_PROFILE" \
MINIKUBE_START_SCRIPT="$tmp/start.sh" \
bash scripts/minikube/full-setup.sh --skip-build >/dev/null 2>&1; then
- if grep -q 'delete -p clerum-test' "$log_file" && grep -q 'start-helper' "$log_file"; then
+ if grep -q "delete -p $TEST_PROFILE" "$log_file" && grep -q 'start-helper' "$log_file"; then
pass "full-setup recreates broken minikube profiles before start"
else
fail "full-setup did not delete and recreate broken profile"
@@ -135,6 +178,7 @@ assert_healthy_profile_skips_recreate() {
local tmp log_file
tmp="$(mktemp -d)"
log_file="$tmp/ops.log"
+ write_test_profile_metadata "$tmp"
cat > "$tmp/docker" <<'STUB'
#!/usr/bin/env bash
@@ -209,6 +253,9 @@ STUB
if PATH="$tmp:$PATH" \
TEST_LOG_FILE="$log_file" \
+ MINIKUBE_PROFILE="$TEST_PROFILE" \
+ T2_PROFILE_ROOT="$TEST_PROFILE_ROOT" T2_PROFILE_ENV="$TEST_PROFILE_ENV" \
+ T2_PORTS_ENV="$TEST_PORTS_ENV" T2_LOCK_ROOT="$TEST_LOCK_ROOT" \
MINIKUBE_SETUP_EXIT_AFTER_CLUSTER=true \
MINIKUBE_START_SCRIPT="$tmp/start.sh" \
bash scripts/minikube/full-setup.sh --skip-build >/dev/null 2>&1; then
diff --git a/scripts/tests/test-minikube-pre-gate-shadow.sh b/scripts/tests/test-minikube-pre-gate-shadow.sh
index 93eae3297..beb85ee59 100755
--- a/scripts/tests/test-minikube-pre-gate-shadow.sh
+++ b/scripts/tests/test-minikube-pre-gate-shadow.sh
@@ -91,6 +91,9 @@ case "$*" in
trap '' TERM
while :; do sleep 1; done
fi
+ if [ "${TEST_EMPTY_DOCKER_ENV:-0}" = "1" ]; then
+ exit 0
+ fi
echo 'export DOCKER_HOST="tcp://127.0.0.1:2376"'
exit 0
;;
@@ -1023,6 +1026,21 @@ assert_incremental_runtime_calls_are_bounded() {
rm -rf "$d"
}
+assert_empty_incremental_docker_env_fails_closed() {
+ local d out rc=0
+ d="$(mktemp -d)"
+ prepare_repo "$d"
+ export TEST_EMPTY_DOCKER_ENV=1
+ out="$(run_incremental "$d" 'incremental_use_minikube_docker')" || rc=$?
+ unset TEST_EMPTY_DOCKER_ENV
+ if [ "$rc" -ne 0 ] && grep -Fq 'DOCKER_ENV_UNRESOLVED' <<<"$out"; then
+ pass "empty incremental minikube docker-env output fails closed"
+ else
+ fail "incremental docker-env returned success without a Docker host: rc=$rc out=$out"
+ fi
+ rm -rf "$d"
+}
+
assert_every_defined_case_is_invoked() {
local self defined invoked missing
self="$REPO_ROOT/scripts/tests/test-minikube-pre-gate-shadow.sh"
@@ -1069,6 +1087,7 @@ assert_an_unknown_image_source_is_rejected
assert_a_targeted_build_carries_the_recorded_coordinate_forward
assert_the_touched_scripts_parse
assert_incremental_runtime_calls_are_bounded
+assert_empty_incremental_docker_env_fails_closed
assert_every_defined_case_is_invoked
exit $FAIL
diff --git a/scripts/tests/test-minikube-profile-owner.sh b/scripts/tests/test-minikube-profile-owner.sh
index 2e33de5a9..b33132b6d 100755
--- a/scripts/tests/test-minikube-profile-owner.sh
+++ b/scripts/tests/test-minikube-profile-owner.sh
@@ -130,6 +130,20 @@ v2_resolved="$("${OWNER_SCRIPT}" resolve --repo-dir "${repo_a}" --branch "${bran
[[ "$(value_from "${v2_resolved}" OWNER_ID)" == "${owner_a}" ]] || fail 'schema-v2 profile resolved the wrong owner'
[[ "$(shasum "${v2_dir}/ports.env" | awk '{print $1}')" == "${ports_before}" ]] || fail 'read-only resolution rewrote ports.env'
+incomplete_v2_ports="${TMP_ROOT}/incomplete-v2-ports.env"
+cp "${v2_dir}/ports.env" "${incomplete_v2_ports}"
+sed -i.bak '/^MCP_HOST_URL=/d' "${incomplete_v2_ports}"
+expect_failure PROFILE_PORTS_INVALID 'schema-v2 ports with a missing canonical URL' \
+ "${OWNER_SCRIPT}" validate --repo-dir "${repo_a}" --branch "${branch}" \
+ --profile "${profile_a}" --profile-env "${v2_dir}/profile.env" --ports-env "${incomplete_v2_ports}"
+
+unknown_v2_ports="${TMP_ROOT}/unknown-v2-ports.env"
+cp "${v2_dir}/ports.env" "${unknown_v2_ports}"
+printf 'UNEXPECTED_PORT=24000\n' >>"${unknown_v2_ports}"
+expect_failure PROFILE_PORTS_INVALID 'schema-v2 ports with an unknown key' \
+ "${OWNER_SCRIPT}" validate --repo-dir "${repo_a}" --branch "${branch}" \
+ --profile "${profile_a}" --profile-env "${v2_dir}/profile.env" --ports-env "${unknown_v2_ports}"
+
corrupt_metadata_root="${TMP_ROOT}/corrupt-metadata"
corrupt_metadata_dir="${corrupt_metadata_root}/${profile_a}"
mkdir -p "${corrupt_metadata_dir}"
diff --git a/scripts/tests/test-minikube-pull-images.sh b/scripts/tests/test-minikube-pull-images.sh
index 632d69172..2820a0ce7 100755
--- a/scripts/tests/test-minikube-pull-images.sh
+++ b/scripts/tests/test-minikube-pull-images.sh
@@ -85,6 +85,10 @@ if [[ "$*" == *"docker-env"* ]]; then
echo 'export DOCKER_HOST="tcp://127.0.0.1:2376"'
exit 0
fi
+if [[ "$*" == *"image load clerum/"* ]] &&
+ [ "${TEST_IMAGE_LOAD_ALIAS_FAIL:-false}" = true ]; then
+ exit 1
+fi
exit 0
STUB
chmod +x "$d/bin/docker" "$d/bin/minikube"
@@ -148,6 +152,7 @@ run_puller_prepared() {
TEST_FLAKY_FAIL_COUNT="${TEST_FLAKY_FAIL_COUNT:-}" \
TEST_FLAKY_COUNTER_DIR="${TEST_FLAKY_COUNTER_DIR:-}" \
TEST_EMPTY_DOCKER_ENV="${TEST_EMPTY_DOCKER_ENV:-}" \
+ TEST_IMAGE_LOAD_ALIAS_FAIL="${TEST_IMAGE_LOAD_ALIAS_FAIL:-}" \
MINIKUBE_IMAGE_TAG="${MINIKUBE_IMAGE_TAG:-}" \
MINIKUBE_IMAGE_PULL_RETRIES="${MINIKUBE_IMAGE_PULL_RETRIES:-}" \
MINIKUBE_IMAGE_PULL_DELAY_SECS="${MINIKUBE_IMAGE_PULL_DELAY_SECS:-}" \
@@ -221,6 +226,22 @@ assert_empty_docker_env_fails_closed() {
rm -rf "$d"
}
+assert_multinode_alias_load_failure_fails_closed() {
+ local d out rc
+ d="$(mktemp -d)"
+ export MINIKUBE_MULTI_NODE=true TEST_IMAGE_LOAD_ALIAS_FAIL=true
+ out="$(run_puller "$d" --only=control-api)"; rc=$?
+ unset MINIKUBE_MULTI_NODE TEST_IMAGE_LOAD_ALIAS_FAIL
+ if [ "$rc" -ne 0 ] &&
+ grep -Fq 'alias load to clerum/control-api:test' <<<"$out" &&
+ ! grep -Fq 'All published images pulled successfully' <<<"$out"; then
+ pass "multi-node alias-load failure prevents a false acquisition success"
+ else
+ fail "multi-node alias-load failure was hidden: rc=$rc out=$out"
+ fi
+ rm -rf "$d"
+}
+
assert_invalid_pull_knobs_fail_closed() {
local d out rc
d="$(mktemp -d)"
@@ -801,6 +822,7 @@ assert_it_pulls_every_pull_in_ghcr_mode_image
assert_puller_requires_the_inherited_profile_lease
assert_hung_pull_hits_the_finite_deadline
assert_empty_docker_env_fails_closed
+assert_multinode_alias_load_failure_fails_closed
assert_invalid_pull_knobs_fail_closed
assert_it_never_pulls_an_unpublished_image
assert_it_never_pulls_a_registry_distributed_mcp_server
diff --git a/scripts/tests/test-minikube-t2-contract.sh b/scripts/tests/test-minikube-t2-contract.sh
index 7c0656a49..fe7daddbe 100755
--- a/scripts/tests/test-minikube-t2-contract.sh
+++ b/scripts/tests/test-minikube-t2-contract.sh
@@ -99,6 +99,9 @@ for code in $required_codes; do
done
grep -Fq 'kubectl --context=' "$COMMON"
+grep -Fq 't2_bounded_command' "$COMMON"
+grep -Fq 'T2_RUNTIME_TIMEOUT_SECONDS' "$COMMON"
+grep -Fq 'T2_RUNTIME_KILL_GRACE_SECONDS' "$COMMON"
grep -Fq 'port-forward-owner.sh' "$COMMON"
grep -Fq 't2_port_forward_targets_context' "$COMMON"
grep -Fq 'matching_records' "$COMMON"
@@ -162,6 +165,12 @@ if [[ -z "$setup_guard_line" || -z "$setup_cluster_line" || "$setup_guard_line"
echo 'FAIL: legacy setup can mutate or probe the cluster before the lease wrapper' >&2
exit 1
fi
+full_setup_lock_line="$(grep -nF 't2_mutation_lock' "$ROOT/scripts/minikube/full-setup.sh" | head -1 | cut -d: -f1)"
+full_setup_status_line="$(grep -nF 'CLUSTER_STATUS="$(minikube_status_snapshot)"' "$ROOT/scripts/minikube/full-setup.sh" | head -1 | cut -d: -f1)"
+if [[ -z "$full_setup_lock_line" || -z "$full_setup_status_line" || "$full_setup_lock_line" -ge "$full_setup_status_line" ]]; then
+ echo 'FAIL: full-setup can probe or mutate the profile before the lease wrapper' >&2
+ exit 1
+fi
for timed_phase in 't2_evidence_write planner PASS' 't2_evidence_write transition PASS' \
't2_evidence_write pre-gate-sync PASS' 't2_evidence_write T1 PASS' \
't2_evidence_write T2 PASS' 't2_evidence_write NP08_HCC_AUTHORIZATION PASS'; do
@@ -332,6 +341,13 @@ grep -Fq 'T2_T0_STATUS=NOT_RUN' "$T2"
grep -Fq 'T2_T1_STATUS=NOT_RUN' "$T2"
grep -Fq 'T2_HEALTHCHECK_COMMAND' "$T2"
grep -Fq 'minikube-t2-runtime' "$ROOT/Makefile"
+post_runtime_process_check_line="$(grep -nF 'if ! t2_process_check; then' "$T2" | tail -1 | cut -d: -f1)"
+complete_pass_line="$(grep -nF 't2_evidence_write complete PASS' "$T2" | tail -1 | cut -d: -f1)"
+if [ -z "$post_runtime_process_check_line" ] || [ -z "$complete_pass_line" ] ||
+ [ "$post_runtime_process_check_line" -ge "$complete_pass_line" ]; then
+ echo 'FAIL: T2 does not revalidate port-forward ownership before complete PASS' >&2
+ exit 1
+fi
if ! grep -Fq 'instead of already-synced' "$T2"; then
echo 'FAIL: final T2 preflight does not require already-synced' >&2
exit 1
diff --git a/scripts/tests/test-minikube-t2-scenarios.sh b/scripts/tests/test-minikube-t2-scenarios.sh
index 8304cb37f..b9667efc3 100755
--- a/scripts/tests/test-minikube-t2-scenarios.sh
+++ b/scripts/tests/test-minikube-t2-scenarios.sh
@@ -57,7 +57,29 @@ profile_root="$tmp/profiles/$profile"
mkdir -p "$profile_root"
printf 'PROFILE=%s\nBRANCH=feat/scenario\nSHA_SHORT=%s\nDIRTY=false\nREPO_DIR=%s\n' \
"$profile" "$(git -C "$repo" rev-parse --short=8 HEAD)" "$repo" >"$profile_root/profile.env"
-printf 'PORT_BASE=23117\nCONTROL_API_PORT=23207\nCONTROL_API_URL=http://127.0.0.1:23207\n' >"$profile_root/ports.env"
+local_loopback_url() { printf 'http://%s:%s' 127.0.0.1 "$1"; }
+cat >"$profile_root/ports.env" <<EOF_PORTS
+PORT_BASE=23117
+CONTROL_UI_PORT=23117
+PROFILE_UI_PORT=23118
+MCP_HOST_PORT=23197
+REGISTRY_API_PORT=23202
+CONTROL_API_PORT=23207
+EXTERNAL_REST_API_PORT=23208
+MEMBER_REGISTRATION_SERVICE_PORT=23209
+RPC_PROXY_PORT=23211
+WORKFLOW_APPROVAL_READER_PORT=23215
+CONTROL_UI_URL=$(local_loopback_url 23117)
+PROFILE_UI_URL=$(local_loopback_url 23118)
+PROFILE_UI_BASE_URL=$(local_loopback_url 23118)
+CONTROL_API_URL=$(local_loopback_url 23207)
+EXTERNAL_REST_API_URL=$(local_loopback_url 23208)
+MEMBER_REGISTRATION_SERVICE_URL=$(local_loopback_url 23209)
+RPC_PROXY_URL=$(local_loopback_url 23211)
+REGISTRY_API_URL=$(local_loopback_url 23202)
+WORKFLOW_APPROVAL_READER_URL=$(local_loopback_url 23215)
+MCP_HOST_URL=$(local_loopback_url 23197)
+EOF_PORTS
repo_env=(
T2_PROJECT_DIR="$repo"
diff --git a/scripts/tests/test-minikube-targeted-health.sh b/scripts/tests/test-minikube-targeted-health.sh
index 4d8353662..9cde1625c 100755
--- a/scripts/tests/test-minikube-targeted-health.sh
+++ b/scripts/tests/test-minikube-targeted-health.sh
@@ -34,6 +34,20 @@ run_healthcheck_if_requested
"$T2_EVIDENCE_STATUS" == NOT_RUN ]] || \
fail 'an optional absent health check was not recorded as NOT_RUN'
+T2_PLAN_STATE=already-synced
+T2_HEALTHCHECK_PENDING=true
+T2_HEALTHCHECK_COMMAND=''
+if validate_healthcheck_contract >/dev/null 2>&1; then
+ fail 'a pending targeted-sync health obligation was not preserved on retry'
+fi
+[[ "$T2_ERROR_CODE" == PROFILE_UNHEALTHY ]] || \
+ fail "pending targeted health returned ${T2_ERROR_CODE:-<empty>}"
+T2_HEALTHCHECK_COMMAND='printf "health-retry-ok\\n" >/dev/null'
+validate_healthcheck_contract
+run_healthcheck_if_requested
+[[ "$T2_HEALTHCHECK_PENDING" == false && "$T2_HEALTH_STATUS" == PASS ]] || \
+ fail 'a successful retry did not clear the targeted-sync health obligation'
+
T2_PLAN_STATE=targeted-sync
T2_HEALTHCHECK_COMMAND='printf "health-ok\\n" >/dev/null'
T2_HEALTHCHECK_TIMEOUT_SECONDS=5