Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
build(desktop): verify Electron runtime before validation
Alfredo Lopezaab8bfa43c73
diff --git a/.github/workflows/ci-public.yml b/.github/workflows/ci-public.ymlindex 18daf933c..e67cce929 100644--- a/.github/workflows/ci-public.yml+++ b/.github/workflows/ci-public.yml@@ -97,6 +97,12 @@ jobs:working-directory: ${{ matrix.service }}run: npm ci+ - name: Verify Electron runtime+ if: matrix.service == 'desktop-app'+ working-directory: desktop-app+ run: |+ node -e "const p=require('electron'); if(typeof p !== 'string') process.exit(1); console.log(p)"+- name: Buildworking-directory: ${{ matrix.service }}run: npm run builddiff --git a/AGENTS.md b/AGENTS.mdindex 90072669c..5bbdfbb64 100644--- a/AGENTS.md+++ b/AGENTS.md@@ -84,6 +84,31 @@ does not stand in for another. Private operational state, generated ports,profile metadata, logs, and evidence belong under the ignored`.local-notes/infra/runs/` path and must never be committed.+## Desktop Electron installation invariant++Node 24 ships npm 11, which blocks dependency lifecycle scripts unless they+are explicitly approved. The Desktop app's pinned Electron package is approved+in `desktop-app/package.json` because its `postinstall` downloads the Electron+runtime used by Desktop tests and the local T2 gate. Desktop validation must+use Node 24 (the CI/runtime contract); Node 26 is not a supported validation+runtime for this dependency. Do not install `desktop-app` with+`--ignore-scripts`, and do not count a Desktop test/build result until these+checks succeed from `desktop-app`:++```bash+node --version # must report v24.x+node -e "const p=require('electron'); if(typeof p !== 'string') process.exit(1); console.log(p)"+```++If it fails with `Electron failed to install correctly`, the dependency install+is incomplete, not a product failure. Stop the gate, switch to Node 24, remove+only the generated `desktop-app/node_modules/electron` directory, rerun `npm+ci` with lifecycle scripts enabled, and rerun the checks. Do not add broad+script approvals, set `ELECTRON_SKIP_BINARY_DOWNLOAD`, point+`ELECTRON_OVERRIDE_DIST_PATH` at an unverified binary, or report green evidence+from a missing runtime. A verified local cache may be used only when its+version and checksum are recorded in the run evidence.+## Branch namingDo not create new branches with agent/vendor prefixes such as `codex/*`,diff --git a/CLAUDE.md b/CLAUDE.mdindex a7d52c1f4..153aa3702 100644--- a/CLAUDE.md+++ b/CLAUDE.md@@ -28,3 +28,17 @@ migration or add a second logger convention. Direct console output is reservedfor logger adapters, explicit CLI/bootstrap output, tests, E2E/fixtures, andintentional development diagnostics; never emit secrets, tokens, credentials,DSNs, private URLs, or raw request/response bodies.++## Desktop Electron runtime++Node 24 uses npm 11, whose install-script approval model can leave Electron+without its downloaded runtime while `npm ci` still exits successfully. The+pinned Electron package is explicitly approved in `desktop-app/package.json`.+Desktop validation must use Node 24 (Node 26 is not a supported validation+runtime), run `npm ci` without `--ignore-scripts`, and verify+`require('electron')` resolves to an executable before any test/build result is+counted. If the check reports `Electron failed to install correctly`, switch to+Node 24, repair the generated dependency directory, and rerun the install;+never bypass the postinstall with `ELECTRON_SKIP_BINARY_DOWNLOAD`, use an+unverified override, or treat the resulting test failure as a product+regression.diff --git a/desktop-app/package.json b/desktop-app/package.jsonindex a335bed5b..a73fe6176 100644--- a/desktop-app/package.json+++ b/desktop-app/package.json@@ -85,5 +85,8 @@"@tootallnate/once": "^3.0.1","tmp": "^0.2.4","tar": "7.5.19"+ },+ "allowScripts": {+ "[email protected]": true}}