Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(control-ui): r1-h1 activate connector detail tabs
Josuéaf091451660f
diff --git a/control-ui/app/mcp-servers/[name]/page.tsx b/control-ui/app/mcp-servers/[name]/page.tsxindex 0ade104ac..2b580c9cd 100644--- a/control-ui/app/mcp-servers/[name]/page.tsx+++ b/control-ui/app/mcp-servers/[name]/page.tsx@@ -88,7 +88,9 @@ export default function McpServerDetailPage() {const router = useRouter()const params = useParams<{ name: string; tab?: string | string[] }>()const name = decodeURIComponent(params?.name ?? '')- const activeTab = parseConnectorDetailTab(params?.tab)+ const [activeTab, setActiveTab] = useState<ConnectorDetailTab>(() =>+ parseConnectorDetailTab(params?.tab)+ )const [server, setServer] = useState<McpServerResource | null>(null)const [loading, setLoading] = useState(true)const [error, setError] = useState('')@@ -108,17 +110,17 @@ export default function McpServerDetailPage() {}, [name])function selectTab(next: ConnectorDetailTab) {- if (next === CONNECTOR_DETAIL_DEFAULT_TAB) {- router.replace(CONTROL_ROUTES.connectors.detail(name))- } else {- router.replace(CONTROL_ROUTES.connectors.detailTab(name, next))- }+ setActiveTab(next)}useEffect(() => {if (name) void load()}, [load, name])+ useEffect(() => {+ setActiveTab(parseConnectorDetailTab(params?.tab))+ }, [params?.tab])+const spec = server?.spec ?? {}const conditions = server?.status?.conditions ?? []const transport =@@ -144,6 +146,7 @@ export default function McpServerDetailPage() {tab === CONNECTOR_DETAIL_DEFAULT_TAB? CONTROL_ROUTES.connectors.detail(name): CONTROL_ROUTES.connectors.detailTab(name, tab),+ onLinkActivate: () => selectTab(tab),}))}contentMode="plain"contentClassName="cu-detail-content-stack--panel-continuation"diff --git a/control-ui/components/__tests__/McpServerDetailPage.test.tsx b/control-ui/components/__tests__/McpServerDetailPage.test.tsxindex ca92cf7ad..ee481b417 100644--- a/control-ui/components/__tests__/McpServerDetailPage.test.tsx+++ b/control-ui/components/__tests__/McpServerDetailPage.test.tsx@@ -5,13 +5,12 @@ import * as api from '../../lib/api'const navigation = vi.hoisted(() => ({push: vi.fn(),- replace: vi.fn(),params: { name: 'search' } as { name: string; tab?: string },}))vi.mock('next/navigation', () => ({useParams: () => navigation.params,- useRouter: () => ({ push: navigation.push, replace: navigation.replace }),+ useRouter: () => ({ push: navigation.push }),}))vi.mock('@components/AuthGate', () => ({AuthGate: ({ children }: { children: React.ReactNode }) => <>{children}</>,@@ -76,7 +75,6 @@ describe('McpServerDetailPage', () => {})it('shows runtime status on the route-backed runtime tab without rendering editable controls', async () => {- navigation.params = { name: 'search', tab: 'runtime' }vi.mocked(api.getMcpServer).mockResolvedValue({metadata: { name: 'search' },spec: {},@@ -92,7 +90,10 @@ describe('McpServerDetailPage', () => {],},})- render(<McpServerDetailPage />)+ const { rerender } = render(<McpServerDetailPage />)+ expect(await screen.findByRole('heading', { name: 'Configuration' })).toBeVisible()+ navigation.params = { name: 'search', tab: 'runtime' }+ rerender(<McpServerDetailPage />)expect(await screen.findByRole('heading', { name: 'Runtime status' })).toBeVisible()expect(screen.getByRole('tab', { name: 'Runtime status' })).toHaveAttribute(@@ -106,6 +107,36 @@ describe('McpServerDetailPage', () => {expect(screen.queryByRole('button', { name: /save/i })).not.toBeInTheDocument()})+ it('switches to runtime status when its route-backed tab is activated', async () => {+ vi.mocked(api.getMcpServer).mockResolvedValue({+ metadata: { name: 'search' },+ spec: { description: 'Search the public web' },+ status: {+ conditions: [+ {+ type: 'Ready',+ status: 'True',+ reason: 'Available',+ message: 'Connector is ready.',+ lastTransitionTime: '2026-09-23T00:00:00Z',+ },+ ],+ },+ })+ render(<McpServerDetailPage />)++ expect(await screen.findByText('Search the public web')).toBeVisible()+ fireEvent.click(screen.getByRole('tab', { name: 'Runtime status' }))++ expect(await screen.findByRole('heading', { name: 'Runtime status' })).toBeVisible()+ expect(screen.getByRole('tab', { name: 'Runtime status' })).toHaveAttribute(+ 'aria-current',+ 'page'+ )+ expect(screen.queryByText('Search the public web')).not.toBeInTheDocument()+ expect(screen.getByText('Connector is ready.')).toBeVisible()+ })+it('refreshes in place and keeps failures on the detail page', async () => {vi.mocked(api.getMcpServer).mockResolvedValueOnce({ metadata: { name: 'search' }, spec: {} })diff --git a/control-ui/e2e/connector-detail-tab-navigation.spec.ts b/control-ui/e2e/connector-detail-tab-navigation.spec.tsnew file mode 100644index 000000000..78858d229--- /dev/null+++ b/control-ui/e2e/connector-detail-tab-navigation.spec.ts@@ -0,0 +1,52 @@+import { expect, test } from '@playwright/test'++test('connector detail tabs navigate once and browser back restores configuration', async ({+ page,+}) => {+ await page.addInitScript(() => {+ window.localStorage.setItem('controlUiAdminToken', 'connector-detail-tab-test-token')+ })++ await page.route('**/api/v1/admin/**', async route => {+ const pathname = new URL(route.request().url()).pathname+ if (pathname.endsWith('/api/v1/admin/auth/me')) {+ await route.fulfill({+ status: 200,+ contentType: 'application/json',+ body: JSON.stringify({ me: { id: 'test-admin', username: 'test-admin', role: 'admin' } }),+ })+ return+ }++ if (pathname.endsWith('/api/v1/admin/mcp-servers/search')) {+ await route.fulfill({+ status: 200,+ contentType: 'application/json',+ body: JSON.stringify({+ metadata: { name: 'search', namespace: 'mcp-server' },+ spec: { description: 'Search the public web' },+ status: {+ conditions: [{ type: 'Ready', status: 'True', message: 'Connector is ready.' }],+ },+ }),+ })+ return+ }++ await route.fulfill({ status: 404, contentType: 'application/json', body: '{}' })+ })++ await page.goto('/connectors/search')+ await expect(page.getByRole('heading', { name: 'Connector: search' })).toBeVisible()+ await expect(page.getByText('Search the public web')).toBeVisible()++ await page.getByRole('tab', { name: 'Runtime status' }).click()+ await expect(page).toHaveURL(/\/connectors\/search\/runtime$/)+ await expect(page.getByRole('heading', { name: 'Runtime status' })).toBeVisible()+ await expect(page.getByText('Connector is ready.')).toBeVisible()++ await page.goBack()+ await expect(page).toHaveURL(/\/connectors\/search\/?$/)+ await expect(page.getByRole('heading', { name: 'Configuration' })).toBeVisible()+ await expect(page.getByText('Search the public web')).toBeVisible()+})diff --git a/control-ui/package-lock.json b/control-ui/package-lock.jsonindex 56012ccee..95a108d83 100644--- a/control-ui/package-lock.json+++ b/control-ui/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-ui",- "version": "0.1.720",+ "version": "0.1.721","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-ui",- "version": "0.1.720",+ "version": "0.1.721","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/frontend-components": "file:../packages/frontend-components",diff --git a/control-ui/package.json b/control-ui/package.jsonindex d302541cf..686b19dca 100644--- a/control-ui/package.json+++ b/control-ui/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-ui",- "version": "0.1.720",+ "version": "0.1.721","private": true,"scripts": {"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",