Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(frontend): r1-m3 guard retired table systems

Josuéaf2eeebcc303
diff --git a/scripts/style-rules/rules.mjs b/scripts/style-rules/rules.mjs
index 1bacbd2ee..06b8c5607 100644
--- a/scripts/style-rules/rules.mjs
+++ b/scripts/style-rules/rules.mjs
@@ -51,6 +51,14 @@ const WEB_LEGACY_TABLE_PATTERNS = [
pattern: /(?:from\s+['"][^'"]*\/RowActions['"]|<RowActions(?:\s|\/|>))/,
message: 'retired Control UI RowActions component',
},
+ {
+ pattern: /(?:from\s+['"][^'"]*\/GrantsPanel['"]|<GrantsPanel(?:\s|\/|>))/,
+ message: 'retired Control UI GrantsPanel component',
+ },
+ {
+ pattern: /from\s+['"][^'"]*\/tableSort['"]/,
+ message: 'retired app-local tableSort helper',
+ },
]
// Files where defining hex color tokens is the whole point.
diff --git a/scripts/style-rules/rules.test.mjs b/scripts/style-rules/rules.test.mjs
index 7a032d153..af4581f8c 100644
--- a/scripts/style-rules/rules.test.mjs
+++ b/scripts/style-rules/rules.test.mjs
@@ -52,6 +52,8 @@ test('rejects retired production table and expansion families', () => {
['profile-ui/app/settings/page.tsx', "import EditableList from './EditableList'"],
['control-ui/app/secrets/page.tsx', '<LlmSecretsSubTabs />'],
['control-ui/components/Hosts.tsx', "import RowActions from './RowActions'"],
+ ['control-ui/components/RecipeGrants.tsx', "import GrantsPanel from './GrantsPanel'"],
+ ['control-ui/app/agents/page.tsx', "import { sortRows } from '../../lib/tableSort'"],
]
for (const [file, content] of examples) {
@@ -69,6 +71,24 @@ test('does not confuse RowActionsMenu with the retired RowActions component', ()
)
})
+test('allows shared sorting helpers and similarly named non-retired table symbols', () => {
+ assert.deepEqual(
+ violationsFor(
+ 'control-ui/app/agents/page.tsx',
+ "import { createStringComparator } from '@clerum/frontend-components'"
+ ),
+ []
+ )
+ assert.deepEqual(
+ violationsFor('control-ui/components/GrantPanelSummary.tsx', '<GrantPanelSummary />'),
+ []
+ )
+ assert.deepEqual(
+ violationsFor('control-ui/components/__tests__/GrantsPanel.test.tsx', '<GrantsPanel />'),
+ []
+ )
+})
+
test('shared table colors resolve through tokens declared by both web apps', () => {
const sharedCss = readFileSync('packages/frontend-components/styles.css', 'utf8')
const controlCss = readFileSync('control-ui/app/globals.css', 'utf8')