Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(web-search): bound malformed HTML scanning
Alfredo Lopezb0e93a6840c7
diff --git a/mcp-servers/web-search/package-lock.json b/mcp-servers/web-search/package-lock.jsonindex d855ce239..e1bc4111d 100644--- a/mcp-servers/web-search/package-lock.json+++ b/mcp-servers/web-search/package-lock.json@@ -1,12 +1,12 @@{"name": "@clerum/web-search-mcp",- "version": "1.0.15",+ "version": "1.0.16","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "@clerum/web-search-mcp",- "version": "1.0.15",+ "version": "1.0.16","dependencies": {"@modelcontextprotocol/sdk": "^1.12.1","express": "^4.21.2"diff --git a/mcp-servers/web-search/package.json b/mcp-servers/web-search/package.jsonindex ef70b12c7..294865816 100644--- a/mcp-servers/web-search/package.json+++ b/mcp-servers/web-search/package.json@@ -1,6 +1,6 @@{"name": "@clerum/web-search-mcp",- "version": "1.0.15",+ "version": "1.0.16","type": "module","main": "dist/index.js","scripts": {diff --git a/mcp-servers/web-search/src/fetchPage.ts b/mcp-servers/web-search/src/fetchPage.tsindex 5191d7db5..150d9f83b 100644--- a/mcp-servers/web-search/src/fetchPage.ts+++ b/mcp-servers/web-search/src/fetchPage.ts@@ -31,6 +31,8 @@ function tagEnd(html: string, start: number): number {if (character === quote) quote = ''} else if (character === '"' || character === "'") {quote = character+ } else if (character === '<') {+ return -2} else if (character === '>') {return cursor}@@ -44,7 +46,7 @@ function closingTag(html: string, lower: string, name: string, from: number) {while (start !== -1) {if (/[\s>]/.test(lower[start + prefix.length] ?? '')) {const end = tagEnd(html, start)- return end === -1 ? undefined : { start, end }+ return end < 0 ? undefined : { start, end }}start = lower.indexOf(prefix, start + prefix.length)}@@ -74,13 +76,25 @@ function scanPage(html: string): { title: string; content: string } {offset = end + 3continue}+ if (lower[start + 1] === '!' || lower[start + 1] === '?') {+ const end = lower.indexOf('>', start + 2)+ if (end === -1) break+ pieces.push(' ')+ offset = end + 1+ continue+ }const end = tagEnd(html, start)+ if (end === -2) {+ pieces.push('<')+ offset = start + 1+ continue+ }if (end === -1) {- pieces.push(html.slice(start))+ if (!/^<\/?[a-z]/.test(lower.slice(start, start + 4))) pieces.push(html.slice(start))break}const match = /^<\/?([a-z][a-z0-9:-]*)(?=[\s/>])/.exec(lower.slice(start, end + 1))- if (!match && lower[start + 1] !== '!' && lower[start + 1] !== '?') {+ if (!match) {pieces.push('<')offset = start + 1continue@@ -89,7 +103,10 @@ function scanPage(html: string): { title: string; content: string } {offset = end + 1if (!match || lower[start + 1] === '/') continueconst name = match[1]- if (name === 'plaintext') break+ if (name === 'plaintext') {+ pieces.push(html.slice(offset))+ break+ }if (name !== 'title' && !inertText.has(name)) continueconst close = closingTag(html, lower, name, offset)if (!close) breakdiff --git a/mcp-servers/web-search/test/fetchPage.test.mjs b/mcp-servers/web-search/test/fetchPage.test.mjsindex 461bab43c..059897cc4 100644--- a/mcp-servers/web-search/test/fetchPage.test.mjs+++ b/mcp-servers/web-search/test/fetchPage.test.mjs@@ -1,4 +1,5 @@import assert from 'node:assert/strict'+import { spawnSync } from 'node:child_process'import { EventEmitter } from 'node:events'import http from 'node:http'import { PassThrough } from 'node:stream'@@ -253,3 +254,24 @@ test('quoted greater-than and partial raw closing tags do not reveal inert text'content: 'Actual Visible',})})++test('malformed tags with a distant bracket finish within a bounded interval', () => {+ const moduleUrl = new URL('../dist/fetchPage.js', import.meta.url).href+ const code =+ 'import { pageText } from ' ++ JSON.stringify(moduleUrl) ++ "; const input = '<'.repeat(100000) + '<a>'; if (pageText(input) !== '<'.repeat(100000)) process.exit(1)"+ const result = spawnSync(process.execPath, ['--input-type=module', '-e', code], {+ timeout: 3000,+ encoding: 'utf8',+ })+ assert.equal(result.status, 0, result.error?.message ?? result.stderr)+})++test('plaintext keeps visible content without parsing its tag-like text', () => {+ assert.equal(pageText('<plaintext>Visible</plaintext>'), 'Visible</plaintext>')+})++test('bogus declarations end at their first greater-than', () => {+ assert.equal(pageText('<!x=">Visible'), 'Visible')+})