Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
refactor(frontend-components): r5-m1 unify secret state transitions
Josuéb3d2d6f15ac7
diff --git a/packages/frontend-components/src/edit/SecretEditField.tsx b/packages/frontend-components/src/edit/SecretEditField.tsxindex f0170a912..613fa6f3e 100644--- a/packages/frontend-components/src/edit/SecretEditField.tsx+++ b/packages/frontend-components/src/edit/SecretEditField.tsx@@ -1,6 +1,7 @@'use client'import type { ChangeEvent } from 'react'+import { transitionSecretEditState } from './secretEditTransitions'import type { SecretEditFieldProps } from './types'export function SecretEditField({@@ -27,13 +28,7 @@ export function SecretEditField({.join(' ') || undefinedfunction change(event: ChangeEvent<HTMLInputElement>) {const next = event.currentTarget.value- onStateChange(- next- ? { status: 'replaced', value: next }- : existingValue- ? { status: 'cleared' }- : { status: 'untouched' }- )+ onStateChange(transitionSecretEditState(existingValue, { type: 'input', value: next }))}return (@@ -70,7 +65,7 @@ export function SecretEditField({state.status === 'cleared' ||(!existingValue && state.status === 'untouched')}- onClick={() => onStateChange({ status: 'cleared' })}+ onClick={() => onStateChange(transitionSecretEditState(existingValue, { type: 'clear' }))}type="button">{clearLabel}@@ -79,7 +74,7 @@ export function SecretEditField({className="eft-dialog__text-button"disabled={disabled || state.status === 'untouched' || state.status === 'restored'}onClick={() =>- onStateChange(existingValue ? { status: 'restored' } : { status: 'untouched' })+ onStateChange(transitionSecretEditState(existingValue, { type: 'restore' }))}type="button">diff --git a/packages/frontend-components/src/edit/__tests__/SecretEditField.test.tsx b/packages/frontend-components/src/edit/__tests__/SecretEditField.test.tsxindex a8f9bc342..8bb1ae7c3 100644--- a/packages/frontend-components/src/edit/__tests__/SecretEditField.test.tsx+++ b/packages/frontend-components/src/edit/__tests__/SecretEditField.test.tsx@@ -106,4 +106,34 @@ describe('SecretEditField', () => {await user.click(restore)expect(onStateChange).toHaveBeenCalledWith({ status: 'untouched' })})++ it('keeps an absent secret untouched when Clear value removes a draft', async () => {+ const user = userEvent.setup()+ const onStateChange = vi.fn()+ function SecretHarness() {+ const [state, setState] = useState<SecretEditState>({ status: 'untouched' })+ return (+ <SecretEditField+ existingValue={false}+ id="new-secret"+ label="New secret"+ onStateChange={next => {+ onStateChange(next)+ setState(next)+ }}+ state={state}+ />+ )+ }++ render(<SecretHarness />)+ const field = screen.getByLabelText('New secret')+ await user.type(field, 'draft-value')+ const clear = screen.getByRole('button', { name: 'Clear value' })+ expect(clear).toBeEnabled()+ await user.click(clear)++ expect(field).toHaveValue('')+ expect(onStateChange).toHaveBeenLastCalledWith({ status: 'untouched' })+ })})diff --git a/packages/frontend-components/src/edit/__tests__/secretEditTransitions.test.ts b/packages/frontend-components/src/edit/__tests__/secretEditTransitions.test.tsnew file mode 100644index 000000000..fc7dbdb6a--- /dev/null+++ b/packages/frontend-components/src/edit/__tests__/secretEditTransitions.test.ts@@ -0,0 +1,17 @@+import { describe, expect, it } from 'vitest'+import { transitionSecretEditState } from '../secretEditTransitions'++describe('transitionSecretEditState', () => {+ it.each([+ [false, { type: 'input', value: 'draft' }, { status: 'replaced', value: 'draft' }],+ [true, { type: 'input', value: 'draft' }, { status: 'replaced', value: 'draft' }],+ [false, { type: 'input', value: '' }, { status: 'untouched' }],+ [true, { type: 'input', value: '' }, { status: 'cleared' }],+ [false, { type: 'clear' }, { status: 'untouched' }],+ [true, { type: 'clear' }, { status: 'cleared' }],+ [false, { type: 'restore' }, { status: 'untouched' }],+ [true, { type: 'restore' }, { status: 'restored' }],+ ] as const)('maps existingValue=%s and event=%j to %j', (existingValue, event, expected) => {+ expect(transitionSecretEditState(existingValue, event)).toEqual(expected)+ })+})diff --git a/packages/frontend-components/src/edit/secretEditTransitions.ts b/packages/frontend-components/src/edit/secretEditTransitions.tsnew file mode 100644index 000000000..23d427cca--- /dev/null+++ b/packages/frontend-components/src/edit/secretEditTransitions.ts@@ -0,0 +1,22 @@+import type { SecretEditState } from './types'++export type SecretEditTransitionEvent =+ | { type: 'input'; value: string }+ | { type: 'clear' }+ | { type: 'restore' }++export function transitionSecretEditState(+ existingValue: boolean,+ event: SecretEditTransitionEvent+): SecretEditState {+ if (event.type === 'input') {+ if (event.value) return { status: 'replaced', value: event.value }+ return existingValue ? { status: 'cleared' } : { status: 'untouched' }+ }++ if (event.type === 'clear') {+ return existingValue ? { status: 'cleared' } : { status: 'untouched' }+ }++ return existingValue ? { status: 'restored' } : { status: 'untouched' }+}