Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(profile-ui): enter authenticated state after recovery

Josuéb5c70d2f13bd
diff --git a/profile-ui/app/components/AuthContext/index.tsx b/profile-ui/app/components/AuthContext/index.tsx
index 576256856..3085718ed 100644
--- a/profile-ui/app/components/AuthContext/index.tsx
+++ b/profile-ui/app/components/AuthContext/index.tsx
@@ -49,6 +49,7 @@ function meFromPasswordLoginResponse(me: PasswordLoginResponse['me']): Me {
export function AuthProvider({ children }: { children: React.ReactNode }) {
const sessionExpiredHandledRef = useRef(false)
+ const authCheckSequenceRef = useRef(0)
const [authState, setAuthState] = useState<AuthState>({
isLoggedIn: false,
isLoading: true,
@@ -56,11 +57,14 @@ export function AuthProvider({ children }: { children: React.ReactNode }) {
})
const checkAuth = useCallback(async () => {
+ const sequence = ++authCheckSequenceRef.current
try {
const me = await getMe({ silentUnauthorized: true })
+ if (sequence !== authCheckSequenceRef.current) return
sessionExpiredHandledRef.current = false
setAuthState({ isLoggedIn: true, isLoading: false, me })
} catch (error) {
+ if (sequence !== authCheckSequenceRef.current) return
if (isSilentApiError(error)) {
setAuthState({ isLoggedIn: false, isLoading: false, me: null })
return
@@ -84,6 +88,7 @@ export function AuthProvider({ children }: { children: React.ReactNode }) {
}, [checkAuth])
const login = useCallback(async (email: string, password: string) => {
+ authCheckSequenceRef.current += 1
try {
const result = await loginWithPassword(email, password)
resetProfileAccessCache()
@@ -105,6 +110,7 @@ export function AuthProvider({ children }: { children: React.ReactNode }) {
}, [])
const logout = useCallback(() => {
+ authCheckSequenceRef.current += 1
sessionExpiredHandledRef.current = false
resetProfileAccessCache(authState.me?.id)
void logoutProfileUI()
diff --git a/profile-ui/app/components/__tests__/AuthContext.recovery.test.tsx b/profile-ui/app/components/__tests__/AuthContext.recovery.test.tsx
new file mode 100644
index 000000000..90382f4b4
--- /dev/null
+++ b/profile-ui/app/components/__tests__/AuthContext.recovery.test.tsx
@@ -0,0 +1,82 @@
+import React from 'react'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import { act, cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
+import { AuthProvider, useAuth } from '../AuthContext'
+
+const apiMocks = vi.hoisted(() => ({
+ clearToken: vi.fn(),
+ getMe: vi.fn(),
+ isSilentApiError: vi.fn(),
+ loginWithPassword: vi.fn(),
+ logoutProfileUI: vi.fn(),
+ setGlobalAuthErrorHandler: vi.fn(),
+}))
+
+vi.mock('@lib/api', () => apiMocks)
+vi.mock('@lib/profileAccess', () => ({ resetProfileAccessCache: vi.fn() }))
+
+function AuthProbe() {
+ const { authState, checkAuth } = useAuth()
+ return (
+ <div>
+ <div data-testid="auth-state">
+ {authState.isLoggedIn ? `signed-in:${authState.me?.email}` : 'signed-out'}
+ </div>
+ <button type="button" onClick={() => void checkAuth()}>
+ Check recovered session
+ </button>
+ </div>
+ )
+}
+
+function deferred<T>() {
+ let resolve!: (value: T) => void
+ let reject!: (reason?: unknown) => void
+ const promise = new Promise<T>((resolvePromise, rejectPromise) => {
+ resolve = resolvePromise
+ reject = rejectPromise
+ })
+ return { promise, resolve, reject }
+}
+
+const member = {
+ id: 'recovered-user',
+ email: '[email protected]',
+ name: 'Member',
+ teamId: 'team-1',
+ teamName: 'Team One',
+ role: 'admin',
+}
+
+beforeEach(() => {
+ vi.clearAllMocks()
+ apiMocks.isSilentApiError.mockReturnValue(false)
+})
+
+afterEach(cleanup)
+
+describe('AuthProvider verified recovery session', () => {
+ it('ignores an older anonymous auth check after recovery establishes a session', async () => {
+ const initialAnonymousCheck = deferred<typeof member>()
+ apiMocks.getMe.mockReturnValueOnce(initialAnonymousCheck.promise).mockResolvedValueOnce(member)
+
+ render(
+ <AuthProvider>
+ <AuthProbe />
+ </AuthProvider>
+ )
+
+ fireEvent.click(screen.getByRole('button', { name: 'Check recovered session' }))
+ await waitFor(() =>
+ expect(screen.getByTestId('auth-state')).toHaveTextContent('signed-in:[email protected]')
+ )
+
+ await act(async () => {
+ initialAnonymousCheck.reject(new Error('anonymous request completed after recovery'))
+ await initialAnonymousCheck.promise.catch(() => undefined)
+ })
+
+ expect(screen.getByTestId('auth-state')).toHaveTextContent('signed-in:[email protected]')
+ expect(apiMocks.clearToken).not.toHaveBeenCalled()
+ })
+})
diff --git a/profile-ui/app/components/__tests__/InvitationClient.reset.test.tsx b/profile-ui/app/components/__tests__/InvitationClient.reset.test.tsx
new file mode 100644
index 000000000..f37812098
--- /dev/null
+++ b/profile-ui/app/components/__tests__/InvitationClient.reset.test.tsx
@@ -0,0 +1,161 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
+import { PROFILE_ROUTES } from '@constants/routes'
+import type { InvitationPreview } from '@/app/types/api'
+import { InvitationClient } from '../../invitations/[token]/InvitationClient'
+
+const mocks = vi.hoisted(() => ({
+ acceptInvitation: vi.fn(),
+ checkAuth: vi.fn(),
+ routerReplace: vi.fn(),
+ setupInvitationPasswordWithToken: vi.fn(),
+}))
+
+vi.mock('next/navigation', () => ({
+ useRouter: () => ({ replace: mocks.routerReplace }),
+}))
+
+vi.mock('@components/AuthContext', () => ({
+ useAuth: () => ({ checkAuth: mocks.checkAuth }),
+}))
+
+vi.mock('@lib/api', () => ({
+ acceptInvitation: mocks.acceptInvitation,
+ getEvenfireDownloadUrl: () => 'https://downloads.example.invalid/evenfire',
+ setupInvitationPasswordWithToken: mocks.setupInvitationPasswordWithToken,
+}))
+
+const passwordReset: InvitationPreview = {
+ id: 'reset-1',
+ teamId: null,
+ teamName: null,
+ email: '[email protected]',
+ role: 'member',
+ purpose: 'password_reset',
+ status: 'pending',
+ expiresAt: new Date(Date.now() + 60_000).toISOString(),
+ acceptedAt: null,
+ userId: 'user-1',
+ passwordPending: true,
+}
+
+function fillPassword() {
+ fireEvent.change(screen.getByLabelText('Password'), {
+ target: { value: 'new-synthetic-password' },
+ })
+ fireEvent.change(screen.getByLabelText('Confirm password'), {
+ target: { value: 'new-synthetic-password' },
+ })
+}
+
+beforeEach(() => {
+ mocks.acceptInvitation.mockReset()
+ mocks.checkAuth.mockReset().mockResolvedValue(undefined)
+ mocks.routerReplace.mockReset()
+ mocks.setupInvitationPasswordWithToken.mockReset().mockResolvedValue({
+ ...passwordReset,
+ status: 'accepted',
+ passwordUpdated: true,
+ })
+})
+
+afterEach(cleanup)
+
+describe('InvitationClient verified password recovery', () => {
+ it('navigates to the authenticated home after reset completes', async () => {
+ render(
+ <InvitationClient
+ invitationToken="verified-reset-proof"
+ initialInvitation={passwordReset}
+ initialError=""
+ />
+ )
+
+ fillPassword()
+ fireEvent.click(screen.getByRole('button', { name: 'Reset password' }))
+
+ await waitFor(() => expect(mocks.routerReplace).toHaveBeenCalledWith(PROFILE_ROUTES.home))
+ expect(mocks.checkAuth).toHaveBeenCalledOnce()
+ expect(mocks.checkAuth.mock.invocationCallOrder[0]).toBeLessThan(
+ mocks.routerReplace.mock.invocationCallOrder[0]
+ )
+ expect(mocks.acceptInvitation).not.toHaveBeenCalled()
+ expect(mocks.setupInvitationPasswordWithToken).toHaveBeenCalledWith(
+ 'verified-reset-proof',
+ 'reset-1',
+ 'new-synthetic-password'
+ )
+ })
+
+ it('keeps member invitation password setup on its existing page flow', async () => {
+ mocks.setupInvitationPasswordWithToken.mockResolvedValue({
+ ...passwordReset,
+ purpose: 'member_invitation',
+ status: 'accepted',
+ passwordPending: false,
+ passwordUpdated: true,
+ })
+ render(
+ <InvitationClient
+ invitationToken="member-invitation-proof"
+ initialInvitation={{
+ ...passwordReset,
+ purpose: 'member_invitation',
+ status: 'accepted',
+ passwordPending: true,
+ }}
+ initialError=""
+ />
+ )
+
+ fillPassword()
+ fireEvent.click(screen.getByRole('button', { name: 'Set password and continue' }))
+
+ await waitFor(() => expect(screen.getByText('You are now registered with Evenfire.')))
+ expect(mocks.routerReplace).not.toHaveBeenCalled()
+ })
+
+ it('shows a retryable message when bounded recovery admission is busy', async () => {
+ mocks.setupInvitationPasswordWithToken.mockRejectedValue(
+ new Error('429 Too Many Requests - rate_limited')
+ )
+ render(
+ <InvitationClient
+ invitationToken="verified-reset-proof"
+ initialInvitation={passwordReset}
+ initialError=""
+ />
+ )
+
+ fillPassword()
+ fireEvent.click(screen.getByRole('button', { name: 'Reset password' }))
+
+ expect(
+ await screen.findByText(
+ 'Account recovery is temporarily busy. Please wait a moment and try again.'
+ )
+ ).toBeTruthy()
+ expect(screen.getByRole('button', { name: 'Reset password' })).toBeEnabled()
+ expect(mocks.checkAuth).not.toHaveBeenCalled()
+ expect(mocks.routerReplace).not.toHaveBeenCalled()
+ })
+
+ it('shows a recovery-link error instead of blaming the new password', async () => {
+ mocks.setupInvitationPasswordWithToken.mockRejectedValue(new Error('invalid_invitation'))
+ render(
+ <InvitationClient
+ invitationToken="invalid-reset-proof"
+ initialInvitation={passwordReset}
+ initialError=""
+ />
+ )
+
+ fillPassword()
+ fireEvent.click(screen.getByRole('button', { name: 'Reset password' }))
+
+ expect(await screen.findByText('This recovery link is invalid or expired.')).toBeTruthy()
+ expect(mocks.checkAuth).not.toHaveBeenCalled()
+ expect(mocks.routerReplace).not.toHaveBeenCalled()
+ })
+})
diff --git a/profile-ui/app/invitations/[token]/InvitationClient.tsx b/profile-ui/app/invitations/[token]/InvitationClient.tsx
index 2674cba4d..347d763a9 100644
--- a/profile-ui/app/invitations/[token]/InvitationClient.tsx
+++ b/profile-ui/app/invitations/[token]/InvitationClient.tsx
@@ -9,6 +9,8 @@ import {
useRef,
useState,
} from 'react'
+import { useRouter } from 'next/navigation'
+import { useAuth } from '@components/AuthContext'
import { Button } from '@components/Button'
import { FormField } from '@components/FormField'
import { TextInput } from '@components/TextInput'
@@ -73,6 +75,8 @@ export function InvitationClient({
initialInvitation,
initialError,
}: InvitationClientProps) {
+ const router = useRouter()
+ const { checkAuth } = useAuth()
const [invitation, setInvitation] = useState<InvitationPreview | null>(initialInvitation)
const [error, setError] = useState(initialError)
const [status, setStatus] = useState(() =>
@@ -129,6 +133,7 @@ export function InvitationClient({
if (!(value instanceof Error)) return 'Failed to update invitation.'
const message = value.message.replace(/^\d{3}\s+[A-Za-z ]+\s+-\s+/, '')
if (message === 'invalid_password') return 'Password must be between 8 and 256 characters.'
+ if (message === 'invalid_invitation') return 'This recovery link is invalid or expired.'
if (message === 'invitation_not_accepted')
return 'Accept the invitation before setting a password.'
if (message === 'invitation_not_pending') return 'This invitation has already been used.'
@@ -137,6 +142,10 @@ export function InvitationClient({
if (message === 'expired') return 'This invitation has expired.'
if (message === 'forbidden') return 'Invitation email does not match.'
if (message === 'not_found') return 'Invitation not found.'
+ if (message === 'rate_limited')
+ return 'Account recovery is temporarily busy. Please wait a moment and try again.'
+ if (message === 'authority_unavailable')
+ return 'Account recovery is temporarily unavailable. Please try again shortly.'
return message
}
@@ -204,6 +213,11 @@ export function InvitationClient({
invitation.id,
password
)
+ if (isPasswordReset) {
+ await checkAuth()
+ router.replace(PROFILE_ROUTES.home)
+ return
+ }
applyInvitationUpdate({
...invitation,
...response,
diff --git a/profile-ui/package-lock.json b/profile-ui/package-lock.json
index 2f494bf80..348c55153 100644
--- a/profile-ui/package-lock.json
+++ b/profile-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-profile-ui",
- "version": "0.1.165",
+ "version": "0.1.166",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-profile-ui",
- "version": "0.1.165",
+ "version": "0.1.166",
"dependencies": {
"@clerum/desktop-app-links": "file:../packages/desktop-app-links",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/profile-ui/package.json b/profile-ui/package.json
index 47e1f309a..052c0e788 100644
--- a/profile-ui/package.json
+++ b/profile-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-profile-ui",
- "version": "0.1.165",
+ "version": "0.1.166",
"private": true,
"scripts": {
"dev": "next dev",