Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): r5-l1 align sanitized Markdown fragments

Josuéb69880d1d7d9
diff --git a/control-ui/components/MarkdownContent/index.tsx b/control-ui/components/MarkdownContent/index.tsx
index 7c131fc4c..1349e4cc8 100644
--- a/control-ui/components/MarkdownContent/index.tsx
+++ b/control-ui/components/MarkdownContent/index.tsx
@@ -32,8 +32,17 @@ const MarkdownPreview = dynamic<MarkdownPreviewProps>(
function renderMarkdownLink({ children, href }: { children?: React.ReactNode; href?: string }) {
const safeHref = safeMarkdownHref(href ?? '')
if (!safeHref) return <span>{children}</span>
+ const isFragment = safeHref.startsWith('#')
+ const fragment = safeHref.slice(1)
+ const alignedHref = isFragment
+ ? `#${fragment.startsWith('user-content-') ? fragment : `user-content-${fragment}`}`
+ : safeHref
return (
- <a href={safeHref} rel="noreferrer" target="_blank">
+ <a
+ href={alignedHref}
+ rel={isFragment ? undefined : 'noreferrer'}
+ target={isFragment ? undefined : '_blank'}
+ >
{children}
</a>
)
diff --git a/control-ui/components/__tests__/HostIdentityTab.test.tsx b/control-ui/components/__tests__/HostIdentityTab.test.tsx
index ff53b9848..77f3ee44b 100644
--- a/control-ui/components/__tests__/HostIdentityTab.test.tsx
+++ b/control-ui/components/__tests__/HostIdentityTab.test.tsx
@@ -132,6 +132,21 @@ describe('HostIdentityTab', () => {
expect(within(table).getByRole('cell', { name: 'Read-only' })).toBeInTheDocument()
})
+ it('keeps sanitized heading ids aligned with Markdown fragment links', async () => {
+ vi.mocked(api.getHostPersonalization).mockResolvedValue({
+ ...initialFiles,
+ identity: '## Target heading\n\n[Jump to target](#target-heading)',
+ })
+ renderTab()
+
+ const heading = await screen.findByRole('heading', { name: 'Target heading' })
+ const link = screen.getByRole('link', { name: 'Jump to target' })
+ const fragmentId = link.getAttribute('href')?.slice(1)
+
+ expect(fragmentId).toBeTruthy()
+ expect(document.getElementById(fragmentId ?? '')).toBe(heading)
+ })
+
it.each(['{Enter}', ' '])(
'opens a filled document with keyboard Edit activation %s',
async key => {
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 1aac446d9..4838703fa 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.649",
+ "version": "0.1.650",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.649",
+ "version": "0.1.650",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index ac83997b3..b1b575fb3 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.649",
+ "version": "0.1.650",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",