Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

chore(desktop): clarify command editing policy

Josuéb93ded5b0d95
diff --git a/desktop-app/src/__tests__/desktopCommands.test.ts b/desktop-app/src/__tests__/desktopCommands.test.ts
index 69c041fa2..0ccc3127e 100644
--- a/desktop-app/src/__tests__/desktopCommands.test.ts
+++ b/desktop-app/src/__tests__/desktopCommands.test.ts
@@ -46,6 +46,7 @@ describe('Desktop command registry', () => {
it('has unique stable IDs and no binding collisions within a source', () => {
expect(new Set(DESKTOP_COMMANDS.map(command => command.id)).size).toBe(DESKTOP_COMMANDS.length)
+ expect(DESKTOP_COMMANDS.every(command => !('editingPolicy' in command))).toBe(true)
for (const platform of ['darwin', 'win32'] as const) {
for (const source of ['host', 'sandbox'] as const) {
const keys = DESKTOP_COMMANDS.filter(
diff --git a/desktop-app/src/desktopCommands.ts b/desktop-app/src/desktopCommands.ts
index 4e2293d5f..dce1223d5 100644
--- a/desktop-app/src/desktopCommands.ts
+++ b/desktop-app/src/desktopCommands.ts
@@ -34,7 +34,6 @@ export type DesktopCommandDefinition = {
sources: readonly DesktopCommandSource[]
eligibility: DesktopCommandEligibility
tabIndex?: number
- editingPolicy: 'allow' | 'suppress'
modalPolicy: 'block' | 'toggle-palette'
actionOwner: 'renderer'
visibleInPalette: boolean
@@ -65,7 +64,6 @@ function tabSelectCommand<const Id extends `tabs.select${1 | 2 | 3 | 4 | 5 | 6 |
sources: ['host', 'sandbox'] as const,
eligibility: 'tab-index' as const,
tabIndex,
- editingPolicy: 'allow' as const,
modalPolicy: 'block' as const,
actionOwner: 'renderer' as const,
visibleInPalette: true,
@@ -94,7 +92,6 @@ const definitions = [
defaultBinding: { key: 't', modifier: 'mod' },
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'allow',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -109,7 +106,6 @@ const definitions = [
defaultBinding: { key: 'w', modifier: 'mod' },
sources: ['host', 'sandbox'],
eligibility: 'tab-exists',
- editingPolicy: 'allow',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -125,7 +121,6 @@ const definitions = [
defaultBinding: { key: '9', modifier: 'mod' },
sources: ['host', 'sandbox'],
eligibility: 'tab-exists',
- editingPolicy: 'allow',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -140,7 +135,6 @@ const definitions = [
defaultBinding: { key: 'Tab', modifier: 'control' },
sources: ['host', 'sandbox'],
eligibility: 'multiple-tabs',
- editingPolicy: 'allow',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -155,7 +149,6 @@ const definitions = [
defaultBinding: { key: 'Tab', modifier: 'control', shift: true },
sources: ['host', 'sandbox'],
eligibility: 'multiple-tabs',
- editingPolicy: 'allow',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -170,7 +163,6 @@ const definitions = [
defaultBinding: { key: 'f', modifier: 'mod' },
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'allow',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -185,7 +177,6 @@ const definitions = [
defaultBinding: { key: 'f', modifier: 'mod', shift: true },
sources: ['host', 'sandbox'],
eligibility: 'searchable-content',
- editingPolicy: 'allow',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -200,7 +191,6 @@ const definitions = [
defaultBinding: { key: 'l', modifier: 'mod', shift: true },
sources: ['host', 'sandbox'],
eligibility: 'composer-available',
- editingPolicy: 'allow',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -215,7 +205,6 @@ const definitions = [
defaultBinding: { key: 'k', modifier: 'mod' },
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'allow',
modalPolicy: 'toggle-palette',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -230,7 +219,6 @@ const definitions = [
defaultBinding: { key: ',', modifier: 'mod' },
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'allow',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -245,7 +233,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'allow',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -260,7 +247,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'not-busy',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -275,7 +261,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -290,7 +275,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -305,7 +289,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -320,7 +303,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -335,7 +317,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -350,7 +331,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -365,7 +345,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -380,7 +359,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -395,7 +373,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -410,7 +387,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'always',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -425,7 +401,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'app-mounted',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -440,7 +415,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'app-mounted',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,
@@ -455,7 +429,6 @@ const definitions = [
defaultBinding: null,
sources: ['host', 'sandbox'],
eligibility: 'conversation-origin',
- editingPolicy: 'suppress',
modalPolicy: 'block',
actionOwner: 'renderer',
visibleInPalette: true,