Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
feat(gfs): add mp4/webm preview and restyle rows like marketplace connectors
Miguelon Peluchonb9cb49130b9c
diff --git a/control-ui/app/constants/gfsVideoPreview.ts b/control-ui/app/constants/gfsVideoPreview.tsnew file mode 100644index 000000000..03031f4a4--- /dev/null+++ b/control-ui/app/constants/gfsVideoPreview.ts@@ -0,0 +1,6 @@+export const GFS_VIDEO_PREVIEW_MIME_TYPES: Readonly<Record<string, string>> = {+ mp4: 'video/mp4',+ webm: 'video/webm',+}++export const GFS_VIDEO_PREVIEW_MAX_BYTES = 100 * 1024 * 1024diff --git a/control-ui/app/globals.css b/control-ui/app/globals.cssindex d1fccc919..a90479025 100644--- a/control-ui/app/globals.css+++ b/control-ui/app/globals.css@@ -11449,7 +11449,6 @@ button.cu-gfs-tree__button:focus-visible,padding: var(--cu-space-2) var(--cu-space-3);padding-inline: calc(var(--cu-space-3) + var(--cu-space-2));border-bottom: 1px solid var(--cu-border-subtle);- border-radius: var(--cu-radius-sm) var(--cu-radius-sm) 0 0;background: var(--cu-surface-hover);color: var(--cu-text-muted);font-size: 0.7rem;@@ -11466,29 +11465,29 @@ button.cu-gfs-tree__button:focus-visible,display: grid;flex: 1 1 auto;align-content: start;- gap: var(--cu-space-1);+ gap: 0;margin: 0;- padding: var(--cu-space-2);+ padding: 0;list-style: none;}.cu-gfs-list__row {min-height: 3.7rem;- border: 1px solid var(--cu-border-subtle);- border-radius: var(--cu-radius-sm);+ width: 100%;+ border: 0;+ border-bottom: 1px solid var(--cu-border-subtle);+ border-radius: 0;padding: var(--cu-space-2) var(--cu-space-3);- background: var(--cu-bg);+ background: transparent;+ transition: background-color 80ms ease;}-.cu-gfs-list__row:first-child,.cu-gfs-list__row:last-child {- border: 1px solid var(--cu-border-subtle);- border-radius: var(--cu-radius-sm);+ border-bottom: 0;}.cu-gfs-list__row:hover {- border-color: var(--cu-border-hover);- background: var(--cu-surface-hover);+ background: rgba(var(--cu-accent-rgb), 0.06);}.cu-gfs-list__row--clickable {@@ -11562,14 +11561,16 @@ button.cu-gfs-tree__button:focus-visible,}.cu-gfs-image-preview-modal,-.cu-gfs-markdown-preview-modal {+.cu-gfs-markdown-preview-modal,+.cu-gfs-video-preview-modal {z-index: 1010;background: var(--cu-overlay);backdrop-filter: blur(12px);}.cu-gfs-image-preview-dialog,-.cu-gfs-markdown-preview-dialog {+.cu-gfs-markdown-preview-dialog,+.cu-gfs-video-preview-dialog {width: min(60rem, calc(100vw - (var(--cu-space-4) * 2)));height: min(47.5rem, calc(100vh - (var(--cu-space-4) * 2)));display: grid;@@ -11582,7 +11583,8 @@ button.cu-gfs-tree__button:focus-visible,}.cu-gfs-image-preview-dialog__header,-.cu-gfs-markdown-preview-dialog__header {+.cu-gfs-markdown-preview-dialog__header,+.cu-gfs-video-preview-dialog__header {display: flex;align-items: center;justify-content: space-between;@@ -11593,7 +11595,8 @@ button.cu-gfs-tree__button:focus-visible,}.cu-gfs-image-preview-dialog__header h3,-.cu-gfs-markdown-preview-dialog__header h3 {+.cu-gfs-markdown-preview-dialog__header h3,+.cu-gfs-video-preview-dialog__header h3 {min-width: 0;overflow: hidden;margin: 0;@@ -11605,7 +11608,8 @@ button.cu-gfs-tree__button:focus-visible,}.cu-gfs-image-preview-dialog__close.cu-btn,-.cu-gfs-markdown-preview-dialog__close.cu-btn {+.cu-gfs-markdown-preview-dialog__close.cu-btn,+.cu-gfs-video-preview-dialog__close.cu-btn {width: 2.25rem;min-width: 2.25rem;height: 2.25rem;@@ -11613,7 +11617,8 @@ button.cu-gfs-tree__button:focus-visible,border-radius: 999px;}-.cu-gfs-image-preview-dialog__body {+.cu-gfs-image-preview-dialog__body,+.cu-gfs-video-preview-dialog__body {min-width: 0;min-height: 0;display: grid;@@ -11628,6 +11633,11 @@ button.cu-gfs-tree__button:focus-visible,font-size: 0.8125rem;}+.cu-gfs-video-preview-dialog__loading {+ color: var(--cu-text-muted);+ font-size: 0.8125rem;+}+.cu-gfs-image-preview-dialog__image {max-width: 100%;max-height: 100%;@@ -11636,6 +11646,15 @@ button.cu-gfs-tree__button:focus-visible,object-fit: contain;}+.cu-gfs-video-preview-dialog__video {+ width: 100%;+ max-width: min(56rem, calc(100vw - (var(--cu-space-5) * 2)));+ max-height: 100%;+ display: block;+ border-radius: var(--cu-radius-sm);+ background: var(--cu-expandable-body-bg);+}+.cu-gfs-markdown-preview-dialog__body {min-width: 0;min-height: 0;diff --git a/control-ui/components/GfsBrowser.tsx b/control-ui/components/GfsBrowser.tsxindex 86591189e..613da7c30 100644--- a/control-ui/components/GfsBrowser.tsx+++ b/control-ui/components/GfsBrowser.tsx@@ -4,6 +4,7 @@ import React, { useCallback, useEffect, useRef, useState } from 'react'import { FileUploadModal } from '@components/FileUploadModal'import { GfsImagePreview } from '@components/GfsImagePreview'import { GfsMarkdownPreview } from '@components/GfsMarkdownPreview'+import { GfsVideoPreview } from '@components/GfsVideoPreview'import {IconDocumentText,IconFolder,@@ -21,6 +22,7 @@ import { gfsImagePreviewMimeType } from '@lib/gfsImagePreview'import { isGfsMarkdownPreviewFile } from '@lib/gfsMarkdownPreview'import { normalizeGfsResourceName } from '@lib/gfsResourceName'import { isGfsVideoFile } from '@lib/gfsVideoFile'+import { gfsVideoPreviewMimeType } from '@lib/gfsVideoPreview'import { GfsGrantPanel } from './GfsGrantPanel'import { GfsResourceMenu } from './GfsResourceMenu'import { NewFolderModal } from './NewFolderModal'@@ -94,7 +96,11 @@ function hasDraggedFiles(event: React.DragEvent<HTMLElement>): boolean {}function isGfsPreviewFile(fileName: string): boolean {- return gfsImagePreviewMimeType(fileName) !== null || isGfsMarkdownPreviewFile(fileName)+ return (+ gfsImagePreviewMimeType(fileName) !== null ||+ isGfsMarkdownPreviewFile(fileName) ||+ gfsVideoPreviewMimeType(fileName) !== null+ )}function isEventFromNestedInteractive(@@ -142,6 +148,12 @@ export function GfsBrowser(): React.JSX.Element {fileName: stringrid: string} | null>(null)+ const [videoPreview, setVideoPreview] = useState<{+ byteLength: number+ fileName: string+ mimeType: string+ rid: string+ } | null>(null)// Resource IDs currently streaming a download (disables that row's button).const [downloadingIds, setDownloadingIds] = useState<ReadonlySet<string>>(() => new Set())@@ -194,13 +206,13 @@ export function GfsBrowser(): React.JSX.Element {}, [current, load])useEffect(() => {- if (!selected || imagePreview || markdownPreview) return+ if (!selected || imagePreview || markdownPreview || videoPreview) returnfunction handleKeyDown(event: KeyboardEvent) {if (event.key === 'Escape') setSelected(null)}window.addEventListener('keydown', handleKeyDown)return () => window.removeEventListener('keydown', handleKeyDown)- }, [imagePreview, markdownPreview, selected])+ }, [imagePreview, markdownPreview, videoPreview, selected])function openDirectory(child: GfsChild): void {if (child.kind !== 'directory') return@@ -224,6 +236,16 @@ export function GfsBrowser(): React.JSX.Element {setMarkdownPreview({ byteLength: child.bytes, fileName: child.name, rid: child.rid })return true}+ const videoMimeType = gfsVideoPreviewMimeType(child.name)+ if (videoMimeType) {+ setVideoPreview({+ byteLength: child.bytes,+ fileName: child.name,+ mimeType: videoMimeType,+ rid: child.rid,+ })+ return true+ }return false}@@ -934,6 +956,16 @@ export function GfsBrowser(): React.JSX.Element {onClose={() => setMarkdownPreview(null)}/>) : null}++ {videoPreview ? (+ <GfsVideoPreview+ byteLength={videoPreview.byteLength}+ fileName={videoPreview.fileName}+ mimeType={videoPreview.mimeType}+ rid={videoPreview.rid}+ onClose={() => setVideoPreview(null)}+ />+ ) : null}</section>)}diff --git a/control-ui/components/GfsVideoPreview/index.tsx b/control-ui/components/GfsVideoPreview/index.tsxnew file mode 100644index 000000000..31a72626c--- /dev/null+++ b/control-ui/components/GfsVideoPreview/index.tsx@@ -0,0 +1,118 @@+'use client'++import { useEffect, useId, useRef, useState } from 'react'+import { createPortal } from 'react-dom'+import { IconX } from '@components/icons'+import { Button } from '@components/ui'+import { gfsFetchFileBlob } from '@lib/api'+import { assertGfsVideoPreviewSize } from '@lib/gfsVideoPreview'+import type { GfsVideoPreviewProps } from './types'++export function GfsVideoPreview({+ byteLength,+ fileName,+ mimeType,+ onClose,+ rid,+}: GfsVideoPreviewProps): React.JSX.Element {+ const titleId = useId()+ const dialogRef = useRef<HTMLElement | null>(null)+ const [previewUrl, setPreviewUrl] = useState<string | null>(null)+ const [previewError, setPreviewError] = useState<string | null>(null)++ useEffect(() => {+ const previouslyFocused = document.activeElement+ dialogRef.current?.querySelector<HTMLButtonElement>('[data-preview-close]')?.focus()+ const handleKeyDown = (event: KeyboardEvent) => {+ if (event.key === 'Escape') onClose()+ }+ window.addEventListener('keydown', handleKeyDown)+ return () => {+ window.removeEventListener('keydown', handleKeyDown)+ if (previouslyFocused instanceof HTMLElement && document.contains(previouslyFocused)) {+ previouslyFocused.focus()+ }+ }+ }, [onClose])++ useEffect(() => {+ let active = true+ let objectUrl: string | null = null++ async function loadPreview(): Promise<void> {+ try {+ assertGfsVideoPreviewSize(byteLength)+ const sourceBlob = await gfsFetchFileBlob(rid)+ assertGfsVideoPreviewSize(sourceBlob.size)+ if (!active) return+ objectUrl = URL.createObjectURL(new Blob([sourceBlob], { type: mimeType }))+ setPreviewUrl(objectUrl)+ } catch (error) {+ if (!active) return+ setPreviewError(error instanceof Error ? error.message : 'Could not load the video preview')+ }+ }++ void loadPreview()+ return () => {+ active = false+ if (objectUrl) URL.revokeObjectURL(objectUrl)+ }+ }, [byteLength, mimeType, rid])++ return createPortal(+ <div+ className="cu-modal-backdrop cu-gfs-video-preview-modal"+ role="presentation"+ onMouseDown={event => {+ if (event.target === event.currentTarget) onClose()+ }}+ >+ <section+ className="cu-gfs-video-preview-dialog"+ ref={dialogRef}+ role="dialog"+ aria-modal="true"+ aria-labelledby={titleId}+ >+ <header className="cu-gfs-video-preview-dialog__header">+ <h3 id={titleId}>{fileName}</h3>+ <Button+ className="cu-gfs-video-preview-dialog__close"+ data-preview-close+ variant="ghost"+ aria-label="Close video preview"+ onClick={onClose}+ >+ <IconX width={18} height={18} />+ </Button>+ </header>+ <div className="cu-gfs-video-preview-dialog__body">+ {previewError ? (+ <div className="cu-banner cu-banner--error" role="alert">+ {previewError}+ </div>+ ) : null}+ {!previewError && !previewUrl ? (+ <div className="cu-gfs-video-preview-dialog__loading" role="status">+ Loading video preview…+ </div>+ ) : null}+ {previewUrl && !previewError ? (+ <video+ aria-label={`Video preview of ${fileName}`}+ className="cu-gfs-video-preview-dialog__video"+ controls+ onError={() => setPreviewError('This video could not be played by your browser')}+ preload="metadata"+ src={previewUrl}+ />+ ) : null}+ </div>+ </section>+ </div>,+ document.body+ )+}++export type { GfsVideoPreviewProps } from './types'diff --git a/control-ui/components/GfsVideoPreview/types.ts b/control-ui/components/GfsVideoPreview/types.tsnew file mode 100644index 000000000..cd1971ec4--- /dev/null+++ b/control-ui/components/GfsVideoPreview/types.ts@@ -0,0 +1,7 @@+export interface GfsVideoPreviewProps {+ byteLength: number+ fileName: string+ mimeType: string+ onClose: () => void+ rid: string+}diff --git a/control-ui/components/__tests__/GfsBrowser.test.tsx b/control-ui/components/__tests__/GfsBrowser.test.tsxindex 907495eb7..439a63a68 100644--- a/control-ui/components/__tests__/GfsBrowser.test.tsx+++ b/control-ui/components/__tests__/GfsBrowser.test.tsx@@ -524,6 +524,33 @@ describe('GfsBrowser', () => {expect(mockGfsFetchFileBlob).not.toHaveBeenCalled()})+ it('previews supported video files in a closable HTML5 video dialog', async () => {+ mockApiGet.mockResolvedValueOnce({+ items: [child('demo.mp4', 'file', 7)],+ nextCursor: null,+ })+ mockGfsFetchFileBlob.mockResolvedValueOnce(new Blob(['fake-video-bytes']))+ renderBrowser()++ const previewTrigger = await screen.findByRole('button', { name: 'demo.mp4' })+ fireEvent.click(previewTrigger)++ const dialog = await screen.findByRole('dialog', { name: 'demo.mp4' })+ const video = await within(dialog).findByLabelText('Video preview of demo.mp4')+ expect(video.tagName).toBe('VIDEO')+ expect(video).toHaveAttribute('controls', '')+ expect(video).toHaveAttribute('src', 'blob:gfs-image-preview')+ expect((mockCreateObjectUrl.mock.calls[0]?.[0] as Blob).type).toBe('video/mp4')++ fireEvent.click(within(dialog).getByRole('button', { name: 'Close video preview' }))+ await waitFor(() => expect(screen.queryByRole('dialog', { name: 'demo.mp4' })).toBeNull())+ expect(mockRevokeObjectUrl).toHaveBeenCalledWith('blob:gfs-image-preview')++ await openResourceMenu('demo.mp4')+ fireEvent.click(screen.getByRole('menuitem', { name: 'Preview' }))+ expect(await screen.findByRole('dialog', { name: 'demo.mp4' })).toBeTruthy()+ })+it('previews Markdown files with safe vanilla rendering', async () => {mockApiGet.mockResolvedValueOnce({items: [child('README.md', 'file', 5)],diff --git a/control-ui/components/__tests__/GfsVideoPreview.test.tsx b/control-ui/components/__tests__/GfsVideoPreview.test.tsxnew file mode 100644index 000000000..4cd7c3c92--- /dev/null+++ b/control-ui/components/__tests__/GfsVideoPreview.test.tsx@@ -0,0 +1,117 @@+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'+import { fireEvent, render, screen } from '@testing-library/react'+import { GfsVideoPreview } from '../GfsVideoPreview'+import { ToastProvider } from '../Toast'++const mockGfsFetchFileBlob = vi.fn()+const mockCreateObjectUrl = vi.fn((blob: Blob) => `blob:${blob.type}-preview`)+const mockRevokeObjectUrl = vi.fn()++vi.mock('@lib/api', () => ({+ gfsFetchFileBlob: (...args: unknown[]) => mockGfsFetchFileBlob(...args),+}))++function renderVideoPreview(props: Parameters<typeof GfsVideoPreview>[0]) {+ return render(+ <ToastProvider>+ <GfsVideoPreview {...props} />+ </ToastProvider>+ )+}++describe('GfsVideoPreview', () => {+ beforeEach(() => {+ mockGfsFetchFileBlob.mockReset()+ mockCreateObjectUrl.mockReset()+ mockCreateObjectUrl.mockReturnValue('blob:video-preview')+ mockRevokeObjectUrl.mockReset()+ Object.defineProperty(URL, 'createObjectURL', {+ configurable: true,+ value: mockCreateObjectUrl,+ })+ Object.defineProperty(URL, 'revokeObjectURL', {+ configurable: true,+ value: mockRevokeObjectUrl,+ })+ })++ afterEach(() => {+ vi.restoreAllMocks()+ })++ it('renders a video element with the file as a Blob URL and frees it on close', async () => {+ const bytes = new Uint8Array([0xde, 0xad, 0xbe, 0xef])+ mockGfsFetchFileBlob.mockResolvedValueOnce(new Blob([bytes], { type: 'video/mp4' }))++ const { unmount } = renderVideoPreview({+ byteLength: 4096,+ fileName: 'clip.mp4',+ mimeType: 'video/mp4',+ onClose: vi.fn(),+ rid: 'r-clip',+ })++ expect(await screen.findByLabelText('Video preview of clip.mp4')).toBeTruthy()+ expect(mockGfsFetchFileBlob).toHaveBeenCalledWith('r-clip')+ expect(mockCreateObjectUrl).toHaveBeenCalledTimes(1)+ const blobArg = mockCreateObjectUrl.mock.calls[0]?.[0] as Blob+ expect(blobArg.type).toBe('video/mp4')++ unmount()+ expect(mockRevokeObjectUrl).toHaveBeenCalledWith('blob:video-preview')+ })++ it('rejects oversized videos before downloading them', async () => {+ renderVideoPreview({+ byteLength: 200 * 1024 * 1024,+ fileName: 'huge.mp4',+ mimeType: 'video/mp4',+ onClose: vi.fn(),+ rid: 'r-huge',+ })++ expect(await screen.findByRole('alert')).toHaveTextContent(+ 'Video previews are limited to 100 MB'+ )+ expect(mockGfsFetchFileBlob).not.toHaveBeenCalled()+ })++ it('falls back to a friendly error when the browser cannot decode the video', async () => {+ mockGfsFetchFileBlob.mockResolvedValueOnce(+ new Blob([new Uint8Array([1, 2, 3])], { type: 'video/mp4' })+ )++ renderVideoPreview({+ byteLength: 1024,+ fileName: 'broken.mp4',+ mimeType: 'video/mp4',+ onClose: vi.fn(),+ rid: 'r-broken',+ })++ const video = await screen.findByLabelText('Video preview of broken.mp4')+ fireEvent.error(video)+ expect(await screen.findByRole('alert')).toHaveTextContent(+ 'This video could not be played by your browser'+ )+ })++ it('escapes the modal when Escape is pressed', async () => {+ const onClose = vi.fn()+ mockGfsFetchFileBlob.mockResolvedValueOnce(+ new Blob([new Uint8Array([1])], { type: 'video/mp4' })+ )++ renderVideoPreview({+ byteLength: 1024,+ fileName: 'clip.mp4',+ mimeType: 'video/mp4',+ onClose,+ rid: 'r-clip',+ })++ await screen.findByLabelText('Video preview of clip.mp4')+ fireEvent.keyDown(window, { key: 'Escape' })+ expect(onClose).toHaveBeenCalledTimes(1)+ })+})diff --git a/control-ui/lib/gfsVideoPreview.ts b/control-ui/lib/gfsVideoPreview.tsnew file mode 100644index 000000000..242d6d551--- /dev/null+++ b/control-ui/lib/gfsVideoPreview.ts@@ -0,0 +1,18 @@+import {+ GFS_VIDEO_PREVIEW_MAX_BYTES,+ GFS_VIDEO_PREVIEW_MIME_TYPES,+} from '@constants/gfsVideoPreview'++export function gfsVideoPreviewMimeType(fileName: string): string | null {+ const extension = fileName.split('.').pop()?.toLowerCase()+ if (!extension || extension === fileName.toLowerCase()) return null+ return GFS_VIDEO_PREVIEW_MIME_TYPES[extension] ?? null+}++export function assertGfsVideoPreviewSize(byteLength: number): void {+ if (byteLength > GFS_VIDEO_PREVIEW_MAX_BYTES) {+ throw new Error(+ 'Video previews are limited to 100 MB. Download the file to watch the full video.'+ )+ }+}diff --git a/control-ui/package-lock.json b/control-ui/package-lock.jsonindex 186b759a2..3ba55bed4 100644--- a/control-ui/package-lock.json+++ b/control-ui/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-ui",- "version": "0.1.435",+ "version": "0.1.436","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-ui",- "version": "0.1.435",+ "version": "0.1.436","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/llm-providers": "file:../packages/llm-providers",diff --git a/control-ui/package.json b/control-ui/package.jsonindex 414f82f1d..ff6ae447e 100644--- a/control-ui/package.json+++ b/control-ui/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-ui",- "version": "0.1.435",+ "version": "0.1.436","private": true,"scripts": {"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",diff --git a/desktop-app/ui/src/components/GfsVideoPreview/index.tsx b/desktop-app/ui/src/components/GfsVideoPreview/index.tsxnew file mode 100644index 000000000..2c5716a3c--- /dev/null+++ b/desktop-app/ui/src/components/GfsVideoPreview/index.tsx@@ -0,0 +1,106 @@+import { useEffect, useId, useRef, useState } from 'react'+import { createPortal } from 'react-dom'+import { IconButton, StatusBanner } from '@components/Common'+import { IconClose } from '@components/SidebarNav/icons'+import { assertGfsVideoPreviewSize } from '@lib/gfsVideoPreview'+import type { GfsVideoPreviewProps } from './types'++export function GfsVideoPreview({+ byteLength,+ fileName,+ gfsUri,+ mimeType,+ onClose,+ onDownloadError,+}: GfsVideoPreviewProps) {+ const titleId = useId()+ const closeButtonRef = useRef<HTMLButtonElement | null>(null)+ const [previewUrl, setPreviewUrl] = useState<string | null>(null)+ const [previewError, setPreviewError] = useState<string | null>(null)++ useEffect(() => {+ closeButtonRef.current?.focus()+ const handleKeyDown = (event: KeyboardEvent) => {+ if (event.key === 'Escape') onClose()+ }+ window.addEventListener('keydown', handleKeyDown)+ return () => window.removeEventListener('keydown', handleKeyDown)+ }, [onClose])++ useEffect(() => {+ let active = true+ let objectUrl: string | null = null++ const loadPreview = async () => {+ try {+ assertGfsVideoPreviewSize(byteLength)+ const { bytes } = await window.clerum.gfs.download(gfsUri)+ assertGfsVideoPreviewSize(bytes.byteLength)+ if (!active) return+ objectUrl = URL.createObjectURL(new Blob([bytes], { type: mimeType }))+ setPreviewUrl(objectUrl)+ } catch (error) {+ if (!active) return+ onDownloadError?.(error)+ setPreviewError(error instanceof Error ? error.message : 'Could not load the video preview')+ }+ }++ void loadPreview()+ return () => {+ active = false+ if (objectUrl) URL.revokeObjectURL(objectUrl)+ }+ }, [byteLength, gfsUri, mimeType, onDownloadError])++ return createPortal(+ <div+ className="da-gfs-video-preview-modal"+ role="presentation"+ onMouseDown={event => {+ if (event.target === event.currentTarget) onClose()+ }}+ >+ <section+ className="da-gfs-video-preview-dialog"+ role="dialog"+ aria-modal="true"+ aria-labelledby={titleId}+ >+ <header className="da-gfs-video-preview-dialog__header">+ <h3 id={titleId}>{fileName}</h3>+ <IconButton+ ref={closeButtonRef}+ label="Close video preview"+ onClick={onClose}+ size="sm"+ variant="ghost"+ >+ <IconClose />+ </IconButton>+ </header>+ <div className="da-gfs-video-preview-dialog__body">+ {previewError ? <StatusBanner tone="error" text={previewError} /> : null}+ {!previewError && !previewUrl ? (+ <div className="da-gfs-video-preview-dialog__loading" role="status">+ Loading video preview…+ </div>+ ) : null}+ {previewUrl && !previewError ? (+ <video+ aria-label={`Video preview of ${fileName}`}+ className="da-gfs-video-preview-dialog__video"+ controls+ onError={() => setPreviewError('This video could not be played by your browser')}+ preload="metadata"+ src={previewUrl}+ />+ ) : null}+ </div>+ </section>+ </div>,+ document.body+ )+}++export type { GfsVideoPreviewProps } from './types'diff --git a/desktop-app/ui/src/components/GfsVideoPreview/types.ts b/desktop-app/ui/src/components/GfsVideoPreview/types.tsnew file mode 100644index 000000000..2b7b5e105--- /dev/null+++ b/desktop-app/ui/src/components/GfsVideoPreview/types.ts@@ -0,0 +1,8 @@+export type GfsVideoPreviewProps = {+ byteLength: number+ fileName: string+ gfsUri: string+ mimeType: string+ onClose: () => void+ onDownloadError?: (error: unknown) => void+}diff --git a/desktop-app/ui/src/constants/gfsVideoPreview.ts b/desktop-app/ui/src/constants/gfsVideoPreview.tsnew file mode 100644index 000000000..03031f4a4--- /dev/null+++ b/desktop-app/ui/src/constants/gfsVideoPreview.ts@@ -0,0 +1,6 @@+export const GFS_VIDEO_PREVIEW_MIME_TYPES: Readonly<Record<string, string>> = {+ mp4: 'video/mp4',+ webm: 'video/webm',+}++export const GFS_VIDEO_PREVIEW_MAX_BYTES = 100 * 1024 * 1024diff --git a/desktop-app/ui/src/lib/gfsVideoPreview.ts b/desktop-app/ui/src/lib/gfsVideoPreview.tsnew file mode 100644index 000000000..242d6d551--- /dev/null+++ b/desktop-app/ui/src/lib/gfsVideoPreview.ts@@ -0,0 +1,18 @@+import {+ GFS_VIDEO_PREVIEW_MAX_BYTES,+ GFS_VIDEO_PREVIEW_MIME_TYPES,+} from '@constants/gfsVideoPreview'++export function gfsVideoPreviewMimeType(fileName: string): string | null {+ const extension = fileName.split('.').pop()?.toLowerCase()+ if (!extension || extension === fileName.toLowerCase()) return null+ return GFS_VIDEO_PREVIEW_MIME_TYPES[extension] ?? null+}++export function assertGfsVideoPreviewSize(byteLength: number): void {+ if (byteLength > GFS_VIDEO_PREVIEW_MAX_BYTES) {+ throw new Error(+ 'Video previews are limited to 100 MB. Download the file to watch the full video.'+ )+ }+}diff --git a/desktop-app/ui/src/pages/FilesPage.tsx b/desktop-app/ui/src/pages/FilesPage.tsxindex 70ff2d43b..795394c1e 100644--- a/desktop-app/ui/src/pages/FilesPage.tsx+++ b/desktop-app/ui/src/pages/FilesPage.tsx@@ -6,6 +6,7 @@ import { GfsFileIcon } from '@components/GfsFileIcon'import { GfsImagePreview } from '@components/GfsImagePreview'import { GfsMarkdownPreview } from '@components/GfsMarkdownPreview'import { GfsResourceMenu } from '@components/GfsResourceMenu'+import { GfsVideoPreview } from '@components/GfsVideoPreview'import {IconAttachFile,IconChevronRight,@@ -22,6 +23,7 @@ import { assertGfsFileUploadSize } from '@lib/gfsFileUpload'import { describeGfsGrantError } from '@lib/gfsGrantErrors'import { gfsImagePreviewMimeType } from '@lib/gfsImagePreview'import { isGfsMarkdownPreviewFile } from '@lib/gfsMarkdownPreview'+import { gfsVideoPreviewMimeType } from '@lib/gfsVideoPreview'import { formatSharedFileSize } from '@lib/sharedFiles'import { GfsGrantList } from '@/gfs/GfsGrantList'import {@@ -69,7 +71,11 @@ function isDroppedPreviewFile(file: File): boolean {}function isGfsPreviewFile(fileName: string): boolean {- return gfsImagePreviewMimeType(fileName) !== null || isGfsMarkdownPreviewFile(fileName)+ return (+ gfsImagePreviewMimeType(fileName) !== null ||+ isGfsMarkdownPreviewFile(fileName) ||+ gfsVideoPreviewMimeType(fileName) !== null+ )}function delegationSubjectOptions(@@ -253,6 +259,17 @@ export function FilesPage({ pushToast, pendingGfsUri, onPendingGfsUriHandled }:})return true}+ const videoMimeType = gfsVideoPreviewMimeType(resource.name)+ if (videoMimeType) {+ setFilePreview({+ bytes: resource.bytes,+ gfsUri: resource.gfsUri,+ kind: 'video',+ mimeType: videoMimeType,+ name: resource.name,+ })+ return true+ }return false}@@ -1183,6 +1200,16 @@ export function FilesPage({ pushToast, pendingGfsUri, onPendingGfsUriHandled }:/>) : null}+ {filePreview?.kind === 'video' ? (+ <GfsVideoPreview+ byteLength={filePreview.bytes}+ fileName={filePreview.name}+ gfsUri={filePreview.gfsUri}+ mimeType={filePreview.mimeType}+ onClose={() => setFilePreview(null)}+ />+ ) : null}+{deleteTarget ? (<ConfirmDialogbody={diff --git a/desktop-app/ui/src/pages/FilesPage.types.ts b/desktop-app/ui/src/pages/FilesPage.types.tsindex 53cf4d053..f4a4c37a0 100644--- a/desktop-app/ui/src/pages/FilesPage.types.ts+++ b/desktop-app/ui/src/pages/FilesPage.types.ts@@ -8,7 +8,7 @@ export type GfsDriveResource = GfsBrowserChild & {}export type GfsPreviewResource = Pick<GfsDriveResource, 'bytes' | 'gfsUri' | 'name'> &- ({ kind: 'image'; mimeType: string } | { kind: 'markdown' })+ ({ kind: 'image'; mimeType: string } | { kind: 'markdown' } | { kind: 'video'; mimeType: string })export interface FilesPageProps {/** App-level toast dispatcher for success feedback (desktop-app/ui rule). */diff --git a/desktop-app/ui/src/pages/__tests__/FilesPage.test.tsx b/desktop-app/ui/src/pages/__tests__/FilesPage.test.tsxindex b6874be7a..126186d81 100644--- a/desktop-app/ui/src/pages/__tests__/FilesPage.test.tsx+++ b/desktop-app/ui/src/pages/__tests__/FilesPage.test.tsx@@ -1546,6 +1546,58 @@ describe('FilesPage', () => {expect(revokeObjectURL).toHaveBeenCalledWith('blob:gfs-image-preview')})+ it('previews a video file in a closable HTML5 video dialog', async () => {+ const download = vi.fn(async () => ({ bytes: new Uint8Array([1, 2, 3]).buffer }))+ const createObjectURL = vi.fn(() => 'blob:gfs-video-preview')+ const revokeObjectURL = vi.fn()+ Object.defineProperty(URL, 'createObjectURL', {+ configurable: true,+ value: createObjectURL,+ })+ Object.defineProperty(URL, 'revokeObjectURL', {+ configurable: true,+ value: revokeObjectURL,+ })+ Object.defineProperty(window, 'clerum', {+ configurable: true,+ value: { gfs: { download } },+ })+ hookMock.useGfsBrowserController.mockReturnValue({+ ...baseController(),+ accessibleResources: [+ {+ resourceId: 'video-1',+ rid: 'video-1',+ gfsUri: 'gfs://main/video-1',+ drive: 'main',+ parentResourceId: null,+ name: 'demo.mp4',+ kind: 'file',+ path: '/demo.mp4',+ version: 1,+ bytes: 3,+ sources: ['grant'],+ permissions: ['read'],+ coversDescendants: false,+ },+ ],+ })++ renderFilesPage()+ fireEvent.click(screen.getByRole('button', { name: 'demo.mp4' }))++ const dialog = await screen.findByRole('dialog', { name: 'demo.mp4' })+ const video = await within(dialog).findByLabelText('Video preview of demo.mp4')+ expect(video.tagName).toBe('VIDEO')+ expect(video.getAttribute('controls')).not.toBeNull()+ expect(video.getAttribute('src')).toBe('blob:gfs-video-preview')+ expect(createObjectURL).toHaveBeenCalledWith(expect.objectContaining({ type: 'video/mp4' }))++ fireEvent.click(within(dialog).getByRole('button', { name: 'Close video preview' }))+ await waitFor(() => expect(screen.queryByRole('dialog', { name: 'demo.mp4' })).toBeNull())+ expect(revokeObjectURL).toHaveBeenCalledWith('blob:gfs-video-preview')+ })+it('previews Markdown files with safe vanilla rendering', async () => {const markdown ='# Project guide\n\nUse **safe rendering**.\n\n1. First\n2. Second\n\n[Unsafe](javascript:alert)\n\n<script>alert("no")</script>'diff --git a/desktop-app/ui/src/styles.css b/desktop-app/ui/src/styles.cssindex 62981c671..4fffb8497 100644--- a/desktop-app/ui/src/styles.css+++ b/desktop-app/ui/src/styles.css@@ -13940,12 +13940,34 @@ pre {flex: 1 1 auto;width: auto;align-content: start;+ gap: 0;margin: var(--space-2) var(--space-3) var(--space-3);overflow: visible;}.da-gfs-drive__grid .da-grid__head {padding-inline: calc(var(--table-cell-padding-x) + var(--grid-row-gap));+ border-radius: 0;+ border-bottom: 1px solid var(--grid-card-border);+ background: var(--grid-card-bg-hover);+}++.da-gfs-drive__grid .da-grid__row {+ width: 100%;+ border-radius: 0;+ border: 0;+ border-bottom: 1px solid var(--grid-card-border);+ background: transparent;+ transition: background-color var(--motion-fast);+}++.da-gfs-drive__grid .da-grid__row:last-child {+ border-bottom: 0;+}++.da-gfs-drive__grid .da-grid__row--clickable:hover:enabled {+ background: var(--grid-card-bg-hover);+ border-color: var(--grid-card-border);}.da-gfs-current-file {@@ -14150,7 +14172,8 @@ pre {}.da-gfs-image-preview-modal,-.da-gfs-markdown-preview-modal {+.da-gfs-markdown-preview-modal,+.da-gfs-video-preview-modal {position: fixed;inset: 0;z-index: calc(var(--layer-chat-overlay) + 3);@@ -14162,7 +14185,8 @@ pre {}.da-gfs-image-preview-dialog,-.da-gfs-markdown-preview-dialog {+.da-gfs-markdown-preview-dialog,+.da-gfs-video-preview-dialog {width: min(960px, 96vw);height: min(760px, 92vh);display: grid;@@ -14175,7 +14199,8 @@ pre {}.da-gfs-image-preview-dialog__header,-.da-gfs-markdown-preview-dialog__header {+.da-gfs-markdown-preview-dialog__header,+.da-gfs-video-preview-dialog__header {display: flex;align-items: center;justify-content: space-between;@@ -14186,7 +14211,8 @@ pre {}.da-gfs-image-preview-dialog__header h3,-.da-gfs-markdown-preview-dialog__header h3 {+.da-gfs-markdown-preview-dialog__header h3,+.da-gfs-video-preview-dialog__header h3 {min-width: 0;overflow: hidden;margin: 0;@@ -14198,7 +14224,8 @@ pre {white-space: nowrap;}-.da-gfs-image-preview-dialog__body {+.da-gfs-image-preview-dialog__body,+.da-gfs-video-preview-dialog__body {min-width: 0;min-height: 0;display: grid;@@ -14221,6 +14248,20 @@ pre {object-fit: contain;}+.da-gfs-video-preview-dialog__loading {+ color: var(--text-muted);+ font-size: var(--font-size-sm);+}++.da-gfs-video-preview-dialog__video {+ width: 100%;+ max-width: min(920px, calc(96vw - var(--space-5) * 2));+ max-height: 100%;+ display: block;+ border-radius: var(--radius-sm);+ background: var(--media-surface);+}+.da-gfs-markdown-preview-dialog__body {min-width: 0;min-height: 0;@@ -14782,18 +14823,21 @@ pre {@media (max-width: 560px) {.da-gfs-image-preview-modal,- .da-gfs-markdown-preview-modal {+ .da-gfs-markdown-preview-modal,+ .da-gfs-video-preview-modal {padding: var(--space-2);}.da-gfs-image-preview-dialog,- .da-gfs-markdown-preview-dialog {+ .da-gfs-markdown-preview-dialog,+ .da-gfs-video-preview-dialog {width: 100%;height: 96vh;}.da-gfs-image-preview-dialog__body,- .da-gfs-markdown-preview-dialog__body {+ .da-gfs-markdown-preview-dialog__body,+ .da-gfs-video-preview-dialog__body {padding: var(--space-2);}diff --git a/desktop-app/ui/src/styles/tokens.css b/desktop-app/ui/src/styles/tokens.cssindex 72a07385c..b111b699e 100644--- a/desktop-app/ui/src/styles/tokens.css+++ b/desktop-app/ui/src/styles/tokens.css@@ -27,6 +27,9 @@--info: #0072c0;--text-inverse: #ffffff;+ /* Media surfaces (full-bleed dark background for video/image previews). */+ --media-surface: #000000;+--accent-rgb: 67, 119, 250;--accent-soft-rgb: 67, 119, 250;--edge-rgb: 94, 99, 108;@@ -193,6 +196,9 @@--info: #0072c0;--text-inverse: #ffffff;+ /* Media surfaces (full-bleed dark background for video/image previews). */+ --media-surface: #000000;+--accent-rgb: 67, 119, 250;--accent-soft-rgb: 67, 119, 250;--edge-rgb: 158, 174, 205;