Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

test(hcc): prove Role verb-order skip converges on the next pass

Alfredo Lopezbcbe6a419b45
diff --git a/host-context-controller/package-lock.json b/host-context-controller/package-lock.json
index 64b419081..4a7a1abf2 100644
--- a/host-context-controller/package-lock.json
+++ b/host-context-controller/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-host-context-controller",
- "version": "0.1.260",
+ "version": "0.1.261",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-host-context-controller",
- "version": "0.1.260",
+ "version": "0.1.261",
"license": "SEE LICENSE IN LICENSE",
"dependencies": {
"@clerum/image-policy": "file:../packages/image-policy",
diff --git a/host-context-controller/package.json b/host-context-controller/package.json
index 95556c9a5..c880b3031 100644
--- a/host-context-controller/package.json
+++ b/host-context-controller/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-host-context-controller",
- "version": "0.1.260",
+ "version": "0.1.261",
"description": "Host Context Controller - provides McpServer CRDs to mcp-host via REST API",
"main": "dist/main.js",
"engines": {
diff --git a/host-context-controller/src/__tests__/hostRoleNoopGate.test.ts b/host-context-controller/src/__tests__/hostRoleNoopGate.test.ts
index b9c1afac0..747fd12bf 100644
--- a/host-context-controller/src/__tests__/hostRoleNoopGate.test.ts
+++ b/host-context-controller/src/__tests__/hostRoleNoopGate.test.ts
@@ -165,13 +165,23 @@ describe('Host ensureHostRole no-op gate', () => {
}
})
- it('NOOP-ROLE-5: reordered live verbs still replaces once', async () => {
+ it('NOOP-ROLE-5: reordered live verbs replace once then converge', async () => {
rbacApi.createNamespacedRole.mockRejectedValue({ code: 409 })
let existing: k8s.V1Role | undefined
+ let readPass = 0
rbacApi.readNamespacedRole.mockImplementation(() => {
- const live = structuredClone(desiredFromCreate(rbacApi))
- secretGetRule(live).verbs = ['watch', 'get', 'list']
- existing = asApiserverRole(live)
+ readPass += 1
+ if (readPass === 1) {
+ const live = structuredClone(desiredFromCreate(rbacApi))
+ secretGetRule(live).verbs = ['watch', 'get', 'list']
+ existing = asApiserverRole(live)
+ return Promise.resolve(existing)
+ }
+ const written = rbacApi.replaceNamespacedRole.mock.calls[0]?.[0].body as
+ | k8s.V1Role
+ | undefined
+ if (!written) throw new Error('NOOP-ROLE-5: second read expected a written Role body')
+ existing = asApiserverRole(structuredClone(written))
return Promise.resolve(existing)
})
const log = vi.spyOn(console, 'log')
@@ -182,6 +192,13 @@ describe('Host ensureHostRole no-op gate', () => {
expect(updatedRoleLogs(log, '"host-chatllm-config-reader"')).toEqual([
'[HostReconciler] Updated Role "host-chatllm-config-reader"',
])
+
+ await (reconciler as any).ensureHostRole(host)
+ expect(secretGetRule(existing!).verbs).toEqual(['get', 'watch', 'list'])
+ expect(rbacApi.replaceNamespacedRole).toHaveBeenCalledOnce()
+ expect(updatedRoleLogs(log, '"host-chatllm-config-reader"')).toEqual([
+ '[HostReconciler] Updated Role "host-chatllm-config-reader"',
+ ])
} finally {
log.mockRestore()
}