Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): remove dead Access tab from member view left by D10 rename

Miguelon Peluchonbd33a094f029
diff --git a/control-ui/app/profile-admin/users/[userId]/page.tsx b/control-ui/app/profile-admin/users/[userId]/page.tsx
index e40e60462..05e52011d 100644
--- a/control-ui/app/profile-admin/users/[userId]/page.tsx
+++ b/control-ui/app/profile-admin/users/[userId]/page.tsx
@@ -51,23 +51,21 @@ import { formatTeamRole, permissionsForTeamRole } from '../../../../lib/teamRole
type TeamRole = 'admin' | 'inviter' | 'member'
-type UserTab = 'contact' | 'approval-dms' | 'communication-channels' | 'access' | 'teams' | 'agents'
+type UserTab = 'contact' | 'approval-dms' | 'communication-channels' | 'agents' | 'teams'
const USER_TABS: UserTab[] = [
'contact',
'approval-dms',
'communication-channels',
- 'access',
- 'teams',
'agents',
+ 'teams',
]
const USER_TAB_LABELS: Record<UserTab, string> = {
contact: 'Contact',
'approval-dms': 'Approval DMs',
'communication-channels': 'Communication Channels',
- access: 'Access',
- teams: 'Teams',
agents: 'Agents',
+ teams: 'Teams',
}
function parseUserTab(value: string | undefined): UserTab {
diff --git a/control-ui/e2e/qa-recorder-member-access.spec.ts b/control-ui/e2e/qa-recorder-member-access.spec.ts
index 272c9033c..7d1fc69ff 100644
--- a/control-ui/e2e/qa-recorder-member-access.spec.ts
+++ b/control-ui/e2e/qa-recorder-member-access.spec.ts
@@ -102,6 +102,9 @@ test.describe('optional QA recorder: Control UI member Agents tab', () => {
const memberTabs = page.getByRole('tablist', { name: 'Member sections' })
await expect(memberTabs).toBeVisible({ timeout: 20_000 })
+ // D10 guard: the merged tab is Agents only — no dead 'Access' tab.
+ await expect(memberTabs.getByRole('tab', { name: 'Access', exact: true })).toHaveCount(0)
+ await expect(memberTabs).toBeVisible({ timeout: 20_000 })
const agentsTab = memberTabs.getByRole('tab', { name: 'Agents', exact: true })
await expect(agentsTab).toBeVisible()
await agentsTab.click()
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index d5b00a90d..c6c1e8790 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.475",
+ "version": "0.1.476",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.475",
+ "version": "0.1.476",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/llm-providers": "file:../packages/llm-providers",
diff --git a/control-ui/package.json b/control-ui/package.json
index ef4523a71..a4b7858e8 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.475",
+ "version": "0.1.476",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",
diff --git a/docs/features/control-ui-context-removal.md b/docs/features/control-ui-context-removal.md
index 2a73c77d1..b17181337 100644
--- a/docs/features/control-ui-context-removal.md
+++ b/docs/features/control-ui-context-removal.md
@@ -286,6 +286,7 @@ Tests updated in the same commit: `HostTable.test.tsx` (hover card now asserts a
| 2026-08-27 | e2e | Video-format answer + MP4 pipeline: Playwright/Chromium records **WebM** natively (not MP4) — `qa:recorder:convert-mp4` added (`scripts/qa-recorder/convert-videos-mp4.sh`, ffmpeg H.264 + faststart, `--replace` to drop originals; round-trip verified against a synthetic clip). Recorder doc + §9 updated. **No video evidence exists yet anywhere in `.local-notes/` — zero journeys have been executed in this lane; videos are produced only when a journey runs against a live cluster.** |
| 2026-08-28 | e2e | **Execution campaign (mock-backed).** Full T2 bootstrap was ruled out on this host (7 GB RAM, ~3 available → OOM risk; both minikube profiles Stopped, stale branch.mk ownership → fail-closed per repo rules). Instead: built `scripts/qa-recorder/mock-control-api.mjs` — an in-memory control-api implementing the audited wire contract (auth cookie, resourceVersion/409 semantics, users/teams contexts mappings with deleted-history, hosts/contexts/mcp-servers CRUD, registry entries + install, budgets, recipes, rotation `DeploymentReady` simulation) — and ran the REAL control-ui dev server against it. Environment fights solved along the way: mock must bind dual-stack (`localhost` → `::1` first for Playwright's request context); Next dev daemon ignores env/port and grabs its own port (verify + set `CONTROL_UI_URL` per run); each playwright invocation wipes the outputDir (run batches in ONE invocation, copy evidence out after). Spec fixes found by real rendering: connectors rows use `role="button"` (kills `row` role; target `Expand/Collapse connector <name>`), team Access rows are `listitem`s, sort headers expose `Sort by access …` aria-names, tombstone rows persist after removal (assert actionability, not absence), toasts stack (`.last()`), 10s auto-refresh detaches click targets (retry), journeys must re-navigate after seeding (login pre-seed landing makes sidebar clicks no-ops). |
| 2026-08-28 | e2e | **Two REAL production bugs found by the journeys, fixed in `f2eebbc8a`:** (1) member detail page crashed wholesale — `accessLabeler` useMemo was declared after its consumer in `availableContextOptions` (TDZ ReferenceError; no unit tests covered those pages); (2) connectors-page search-by-agent silently broke in the Phase-1 rework (`summary.agents` emptied while the search haystack still reads it). Both fixed; search-by-agent locked with a new unit regression test (`McpServerTable.test.tsx`); unit suite now **1701/1701**, `tsc` clean. |
+| 2026-08-28 | D10-fix | Operator caught a REAL bug we shipped: the member view still rendered a dead "Access" tab beside "Agents" — the D10 rename had silently no-opped on the member page's tab block (formatting drift, unasserted replace) and no spec guarded member-view tab absence. Fixed (UserTab now contact/approval-dms/communication-channels/agents/teams, zero 'access' remnants) + added a regression guard to the member journey asserting NO 'Access' tab renders. All 3 member journeys re-verified green against the live stack. Lesson recorded: every scripted replace must assert, and every removal needs an absence guard. |
| 2026-08-28 | D10 | Operator renamed the merged tab back to **Agents** (D8 semantics, new name): route `agents`, agent-flavored copy, wizard `Team → Members → Agents`, single `Agents` column on the teams table, redirects `/contexts` + `/access` → `/agents`. One post-merge formatting miss (users `[tab]` route list) was caught live by the journeys and fixed. Verified: `tsc` clean + all 7 affected recorder journeys green against the mock stack (full unit rerun was interrupted by an operator abort; suite was green at D9 and no unit-covered code changed since). |
| 2026-08-28 | D9 | Operator review killed the "Removed access" tombstone section on member/team Access tabs (backend soft-delete history = bookkeeping, not UI). Section + dead CSS removed from both pages; `member-removed-access` journey rewritten to assert ZERO residue after an out-of-band scope deletion (no heading, no row, no raw id, clean empty state); `team-access` comment updated. Verified: `tsc` clean, unit suite green, 4 affected recorder journeys green against the mock stack (member-access ×3 incl. removed-access, team-access). |
| 2026-08-28 | D8 | **Access tabs = agents** (operator-approved design): member + team Access tabs rebuilt as agent tables with the shared Connectors column (extracted `components/ConnectorCountCell.tsx`, now also used by the Agents list — same pill, same hover, same click-through); separate "Agents" tabs folded in with legacy redirects; team wizard collapsed to 3 steps with an agent picker; writes are composite (`agents` + `contexts` mappings synced, legacy scope-only mappings preserved). Verified: `tsc` clean, unit suite green (2 known load flakes pass solo), and all 7 affected recorder journeys re-executed green against the mock stack (member-access ×3, team-access ×2, team-create, onboarding-combo). Spec fallout updated incl. api-client agent-mapping helpers and restore-agentNames hygiene. |