Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(desktop-ui): r12-l3 prove switch identity and simplify admission
Josuébe50e99ba07e
diff --git a/desktop-app/ui/src/hooks/domain/__tests__/switchJoinIdentity.r13.test.tsx b/desktop-app/ui/src/hooks/domain/__tests__/switchJoinIdentity.r13.test.tsxnew file mode 100644index 000000000..26b13a4c6--- /dev/null+++ b/desktop-app/ui/src/hooks/domain/__tests__/switchJoinIdentity.r13.test.tsx@@ -0,0 +1,99 @@+// @vitest-environment jsdom+import { afterEach, expect, it, vi } from 'vitest'+import { act, cleanup, waitFor } from '@testing-library/react'+import { DESKTOP_ROUTES } from '@constants/navigation'+import { deferred } from './__fixtures__/catalogFixtures'+import { renderController } from './__fixtures__/controllerHarness'+import { installMockClerum, uninstallMockClerum } from './__fixtures__/mockClerum'++afterEach(() => {+ cleanup()+ vi.restoreAllMocks()+ uninstallMockClerum()+})++it.each(['chat-1', 'chat-2'])(+ 'does not reuse a fulfilled execution for a new specific intent to %s',+ async destination => {+ const clerum = installMockClerum()+ clerum.chat.getIndex.mockImplementation(agent => clerum.readIndex(agent))+ clerum.chat.setLastActive.mockImplementation((agent, chat) =>+ clerum.persistLastActive(agent, chat)+ )+ for (const id of ['chat-1', 'chat-2']) {+ await clerum.chat.create('agent-x', id)+ await clerum.chat.upsertMessages('agent-x', id, [+ { id: `${id}-history`, role: 'user', content: `${id} actual history`, timestamp: 1 },+ ])+ }+ const controller = renderController({ loadMenuData: false })+ await waitFor(() => expect(controller.result.current.chatListLoading).toBe(false))+ await act(async () => controller.result.current.switchToChat('agent-x', 'chat-1'))+ act(() => {+ controller.result.current.setPendingChatSelection('agent-x', destination, {+ deferSwitch: true,+ })+ controller.rerender({ navItem: DESKTOP_ROUTES.apps })+ })+ await waitFor(() => {+ expect(controller.result.current.chatMessages).toEqual([+ expect.objectContaining({ id: `${destination}-history` }),+ ])+ expect(controller.result.current.chatMessagesLoading).toBe(false)+ })+ expect(controller.result.current.activeChatId).toBe(destination)+ expect(clerum.chat.setLastActive.mock.calls.map(([, id]) => id)).toEqual([+ 'chat-1',+ destination,+ ])+ expect((await clerum.readIndex('agent-x')).lastActiveChatId).toBe(destination)+ expect(controller.spies.pushToast).not.toHaveBeenCalled()+ }+)++it('does not join another agent execution even when real pending producers reuse its chat id', async () => {+ const clerum = installMockClerum()+ clerum.chat.getIndex.mockImplementation(agent => clerum.readIndex(agent))+ for (const agent of ['agent-x', 'agent-y']) {+ await clerum.chat.create(agent, 'shared-chat')+ await clerum.chat.upsertMessages(agent, 'shared-chat', [+ { id: `${agent}-history`, role: 'user', content: `${agent} history`, timestamp: 1 },+ ])+ }+ const controller = renderController({ loadMenuData: false, agentNames: ['agent-x', 'agent-y'] })+ await waitFor(() => expect(controller.result.current.chatListLoading).toBe(false))+ const opening = deferred<void>()+ clerum.chat.setLastActive.mockImplementationOnce(() => opening.promise)+ let request!: Promise<void>+ act(() => {+ // The pending-selection producer records the destination before React+ // commits selectedAgent; a public imperative action may still use agent-x.+ controller.result.current.setPendingChatSelection('agent-y', 'shared-chat', {+ deferSwitch: true,+ })+ request = controller.result.current.switchToChat('agent-x', 'shared-chat', {+ onCurrentError: cause => controller.spies.pushToast(String(cause), 'error'),+ })+ controller.rerender({ selectedAgent: 'agent-y', navItem: DESKTOP_ROUTES.apps })+ })+ await waitFor(() => expect(controller.result.current.chatListLoading).toBe(false))+ await waitFor(() =>+ expect(controller.result.current.chatMessages).toEqual([+ expect.objectContaining({ id: 'agent-y-history', content: 'agent-y history' }),+ ])+ )+ await act(async () => {+ opening.resolve()+ expect(await request).toBeUndefined()+ })+ expect(controller.result.current.activeChatId).toBe('shared-chat')+ expect(controller.result.current.chatMessages).toEqual([+ expect.objectContaining({ id: 'agent-y-history', content: 'agent-y history' }),+ ])+ expect(controller.result.current.chatMessagesLoading).toBe(false)+ expect(clerum.chat.setLastActive.mock.calls.map(([agent]) => agent)).toEqual([+ 'agent-x',+ 'agent-y',+ ])+ expect(controller.spies.pushToast).not.toHaveBeenCalled()+})diff --git a/desktop-app/ui/src/hooks/domain/useAgentChatController.ts b/desktop-app/ui/src/hooks/domain/useAgentChatController.tsindex 663a5bd93..a78ce8f4c 100644--- a/desktop-app/ui/src/hooks/domain/useAgentChatController.ts+++ b/desktop-app/ui/src/hooks/domain/useAgentChatController.ts@@ -1467,13 +1467,14 @@ export function useAgentChatController({const selectionIntentRevision = selectionIntentRevisionRef.currentconst requestedSelection = readPendingSelection(selectedAgent)const pendingSwitch = pendingChatSwitchRequestRef.current+ // Public registration preserves only a matching same-agent specific intent;+ // a later specific write advances revision, so its destination cannot drift.const sharesPendingSwitch = Boolean(requestedSelection?.mode === 'specific' &&pendingSwitch?.state !== 'rejected' &&pendingSwitch?.revision === selectionIntentRevision &&pendingSwitch.scope === currentAuthScopeRef.current &&- pendingSwitch.agentRef === selectedAgent &&- pendingSwitch.chatId === requestedSelection.chatId+ pendingSwitch.agentRef === selectedAgent)const switchForEffect = (chatId: string) => {if (sharesPendingSwitch) return pendingSwitch!.promise