Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
test(gfs): pin legacy fallback size preflight
Josuébea4641766cc
diff --git a/control-ui/lib/__tests__/gfsFileUpload.test.ts b/control-ui/lib/__tests__/gfsFileUpload.test.tsindex 3a04a07dd..57662c88d 100644--- a/control-ui/lib/__tests__/gfsFileUpload.test.ts+++ b/control-ui/lib/__tests__/gfsFileUpload.test.ts@@ -1,5 +1,6 @@import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'import {+ GFS_LEGACY_UPLOAD_MAX_BYTES,GfsUploadJob,type GfsUploadStatus,assertGfsFileUploadSize,@@ -7,6 +8,7 @@ import {isRetryableUploadStatus,normalizeInstabilityFailureThreshold,parseRetryAfter,+ uploadGfsFileLegacy,} from '@lib/gfsFileUpload'describe('assertGfsFileUploadSize', () => {@@ -22,6 +24,52 @@ describe('assertGfsFileUploadSize', () => {})})+describe('uploadGfsFileLegacy', () => {+ afterEach(() => {+ vi.unstubAllGlobals()+ vi.restoreAllMocks()+ })++ it('rejects above the legacy limit before reading or requesting the legacy upload', async () => {+ const file = new File([new Uint8Array([1])], 'too-large-for-legacy.bin')+ Object.defineProperty(file, 'size', { value: GFS_LEGACY_UPLOAD_MAX_BYTES + 1 })+ const arrayBuffer = vi.spyOn(file, 'arrayBuffer')+ const fetchMock = vi.fn()+ vi.stubGlobal('fetch', fetchMock)++ await expect(+ uploadGfsFileLegacy({+ file,+ name: file.name,+ target: { operation: 'create', parentRid: 'parent-legacy-limit' },+ })+ ).rejects.toThrow(`legacy GFS is limited to ${GFS_LEGACY_UPLOAD_MAX_BYTES} bytes`)+ expect(arrayBuffer).not.toHaveBeenCalled()+ expect(fetchMock).not.toHaveBeenCalled()+ })++ it('keeps files within the legacy limit on the existing compatibility path', async () => {+ const file = new File([new Uint8Array([1, 2, 3])], 'legacy.bin')+ const fetchMock = vi.fn(+ async () =>+ new Response(JSON.stringify({ ok: true, data: { resourceId: 'legacy-resource' } }), {+ status: 200,+ headers: { 'Content-Type': 'application/json' },+ })+ )+ vi.stubGlobal('fetch', fetchMock)++ await expect(+ uploadGfsFileLegacy({+ file,+ name: file.name,+ target: { operation: 'create', parentRid: 'parent-legacy-limit' },+ })+ ).resolves.toEqual({ ok: true, data: { resourceId: 'legacy-resource' } })+ expect(fetchMock).toHaveBeenCalledTimes(1)+ })+})+describe('parseRetryAfter', () => {it('accepts delta-seconds and caps untrusted server delays', () => {expect(parseRetryAfter('2')).toBe(2_000)diff --git a/control-ui/package-lock.json b/control-ui/package-lock.jsonindex dbd6b0ae6..875b41811 100644--- a/control-ui/package-lock.json+++ b/control-ui/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-ui",- "version": "0.1.441",+ "version": "0.1.442","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-ui",- "version": "0.1.441",+ "version": "0.1.442","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/llm-providers": "file:../packages/llm-providers",diff --git a/control-ui/package.json b/control-ui/package.jsonindex 53b92ca59..903f97ff5 100644--- a/control-ui/package.json+++ b/control-ui/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-ui",- "version": "0.1.441",+ "version": "0.1.442","private": true,"scripts": {"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",diff --git a/desktop-app/src/__tests__/appService.gfs.test.ts b/desktop-app/src/__tests__/appService.gfs.test.tsindex 0c6b849f4..36421bb23 100644--- a/desktop-app/src/__tests__/appService.gfs.test.ts+++ b/desktop-app/src/__tests__/appService.gfs.test.ts@@ -1,6 +1,6 @@import { describe, expect, it, vi } from 'vitest'import fs from 'node:fs'-import { mkdtemp, readFile, rename, rm, symlink, writeFile } from 'node:fs/promises'+import { mkdtemp, readFile, rename, rm, symlink, truncate, writeFile } from 'node:fs/promises'import { tmpdir } from 'node:os'import { join } from 'node:path'import { AppService, legacyEncodedFile, migrateDesktopGfsUploadState } from '../appService.js'@@ -354,6 +354,31 @@ describe('AppService GFS upload security scope', () => {}})+ it('rejects above the legacy limit before invoking the fallback request', async () => {+ const root = await mkdtemp(join(tmpdir(), 'evenfire-gfs-legacy-limit-fallback-'))+ try {+ const filePath = join(root, 'oversized-legacy.bin')+ await writeFile(filePath, Buffer.alloc(0))+ await truncate(filePath, 16 * 1024 * 1024 + 1)+ const service = authenticatedUploadService(join(root, 'gfs-upload-sessions.json'))+ service.startDesktopGfsUpload.mockRejectedValue(+ new DesktopUploadCapabilityError('resumable uploads are disabled')+ )+ service.gfsClient = {+ createResource: vi.fn(),+ replaceFile: vi.fn(),+ }++ await expect(+ service.startGfsFileUpload('parent-rid', 'oversized-legacy.bin', filePath, 'main')+ ).rejects.toThrow(`legacy GFS is limited to ${16 * 1024 * 1024} bytes`)+ expect(service.gfsClient.createResource).not.toHaveBeenCalled()+ expect(service.gfsClient.replaceFile).not.toHaveBeenCalled()+ } finally {+ await rm(root, { recursive: true, force: true })+ }+ })+it('never falls back to a second legacy resource for an explicit resume', async () => {const root = await mkdtemp(join(tmpdir(), 'evenfire-gfs-explicit-resume-no-fallback-'))try {