Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(frontend-components): contain disabled escape dismissal
Josuébee0c3ffa11c
diff --git a/packages/frontend-components/src/edit/DialogShell.tsx b/packages/frontend-components/src/edit/DialogShell.tsxindex e961ee052..9f71ea830 100644--- a/packages/frontend-components/src/edit/DialogShell.tsx+++ b/packages/frontend-components/src/edit/DialogShell.tsx@@ -71,10 +71,9 @@ export function DialogShell({function handleKeyDown(event: KeyboardEvent<HTMLElement>) {if (event.key === 'Escape') {- if (!dismissOnEscape) returnevent.preventDefault()event.stopPropagation()- if (blocked) return+ if (!dismissOnEscape || blocked) returndismiss('escape')return}diff --git a/packages/frontend-components/src/edit/__tests__/DialogShell.test.tsx b/packages/frontend-components/src/edit/__tests__/DialogShell.test.tsxindex 1957b72fc..a40e6d22f 100644--- a/packages/frontend-components/src/edit/__tests__/DialogShell.test.tsx+++ b/packages/frontend-components/src/edit/__tests__/DialogShell.test.tsx@@ -107,6 +107,7 @@ describe('DialogShell', () => {const nextDialog = screen.getByRole('dialog', { name: 'Saving' })fireEvent.keyDown(nextDialog, { key: 'Escape' })expect(onDismiss).not.toHaveBeenCalled()+ expect(onOutsideKeyDown).not.toHaveBeenCalled()fireEvent.mouseDown(screen.getByTestId('dialog-backdrop'))expect(onDismiss).toHaveBeenCalledWith('backdrop')})