Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
test(desktop): pin the sync ref clear and the handler's error path
Alfredo Lopezc19dbd069666
diff --git a/desktop-app/scripts/bench-chat-open/benchmark.test.mjs b/desktop-app/scripts/bench-chat-open/benchmark.test.mjsindex e24d843af..c5435459b 100644--- a/desktop-app/scripts/bench-chat-open/benchmark.test.mjs+++ b/desktop-app/scripts/bench-chat-open/benchmark.test.mjs@@ -165,10 +165,8 @@ test('HEAD delegates to the compiled export and settle waits for the cleanups itassert.deepEqual(calls, ['export', 'cleanup:synthetic', 'index:synthetic', 'cleanup:end'])})-test('HEAD drives the real chat:getIndex handler through the adapter deps', async () => {- // The stub above witnesses delegation; this runs the shipped handler against- // the adapter's untyped deps, so a renamed dependency fails here instead of- // surfacing only as a cleanup warning in a benchmark run.+/** The shipped `runChatGetIndex`, transpiled from source. */+async function realRunChatGetIndex() {const source = await fs.readFile(new URL('../../src/chatGetIndexHandler.ts', import.meta.url),'utf8'@@ -179,6 +177,14 @@ test('HEAD drives the real chat:getIndex handler through the adapter deps', asynconst compiled = { exports: {} }new Function('module', 'exports', outputText)(compiled, compiled.exports)assert.equal(typeof compiled.exports.runChatGetIndex, 'function')+ return compiled.exports.runChatGetIndex+}++test('HEAD drives the real chat:getIndex handler through the adapter deps', async () => {+ // The stub above witnesses delegation; this runs the shipped handler against+ // the adapter's untyped deps, so a renamed dependency fails here instead of+ // surfacing only as a cleanup warning in a benchmark run.+ const runChatGetIndex = await realRunChatGetIndex()const calls = []let release@@ -201,7 +207,7 @@ test('HEAD drives the real chat:getIndex handler through the adapter deps', asynconst context = head.context(store, {runChatGetIndex: (deps, agentRef) => {calls.push('export')- return compiled.exports.runChatGetIndex(deps, agentRef)+ return runChatGetIndex(deps, agentRef)},})@@ -222,3 +228,25 @@ test('HEAD drives the real chat:getIndex handler through the adapter deps', asynassert.deepEqual(calls, ['export', 'cleanup:synthetic', 'index:synthetic', 'cleanup:end'])assert.equal(context.cleanupErrors, 0)})++test('HEAD counts a rejected cleanup from the real handler and still returns the index', async () => {+ const runChatGetIndex = await realRunChatGetIndex()+ const calls = []+ const result = { chats: [1] }+ const store = {+ async retryPendingDeleteCleanups(_scope, agentRef) {+ calls.push(`cleanup:${agentRef}`)+ throw new Error('Synthetic cleanup failure')+ },+ async getIndex(agentRef) {+ calls.push(`index:${agentRef}`)+ return result+ },+ }+ const context = head.context(store, { runChatGetIndex })+ assert.equal(await context.getIndex('synthetic'), result)+ await context.settle()+ // Witness: the handler started the cleanup that rejected.+ assert.deepEqual(calls, ['cleanup:synthetic', 'index:synthetic'])+ assert.equal(context.cleanupErrors, 1)+})diff --git a/desktop-app/ui/src/hooks/domain/useAgentChatController.ts b/desktop-app/ui/src/hooks/domain/useAgentChatController.tsindex d9ac44757..256866c3c 100644--- a/desktop-app/ui/src/hooks/domain/useAgentChatController.ts+++ b/desktop-app/ui/src/hooks/domain/useAgentChatController.ts@@ -579,6 +579,10 @@ export function useAgentChatController({activeChatSwitchKeyRef.current = nullactiveChatLocalPageRequestRef.current = nullcancelOlderMessagesLoad()+ // Invariant: the ref is cleared with the state, not by the passive sync+ // effect. Merges read the ref, and a merge that runs before that effect+ // would otherwise build on the withdrawn transcript. Under `act` the effect+ // always runs first, so no unit test can observe this line.chatMessagesRef.current = []setChatMessages([])setHasOlderMessages(false)