Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
test(branch-profile): pin that a dying stop-pf does not strand minikube stop
Alfredo Lopezc27f8221a82e
diff --git a/scripts/tests/test-branch-profile-lifecycle.sh b/scripts/tests/test-branch-profile-lifecycle.shindex 6b77adc08..36008713f 100755--- a/scripts/tests/test-branch-profile-lifecycle.sh+++ b/scripts/tests/test-branch-profile-lifecycle.sh@@ -564,6 +564,21 @@ bp delete-minikube-fails delete "CONFIRM_DELETE=${profile}"assert_rc 11 'delete returns the exit code of a failed minikube delete'assert_log_has "minikube -p ${profile} delete pidfiles=0" 'delete ran the failing minikube delete with no records left'+# A die inside cmd_stop_pf (here: a symlinked pids directory) is contained by+# the subshell in stop_pf_before_minikube: minikube stop still runs and the+# command fails.+reset_state+mv "${pids_dir}" "${tmp}/pids-aside"+mkdir -p "${tmp}/pids-target"+ln -s "${tmp}/pids-target" "${pids_dir}"+bp stop-pf-dies stop+assert_rc_nonzero 'stop must fail when clearing the port-forward records dies'+# Witness: the die that the subshell contained.+assert_output_has "refusing symlinked port-forward PID directory: ${pids_dir}" 'stop reached the dying stop-pf'+assert_log_has "minikube -p ${profile} stop" 'a die in stop-pf must not prevent minikube stop'+rm -f "${pids_dir}"+mv "${tmp}/pids-aside" "${pids_dir}"+# === stop-pf attempts every record ============================================# record_pf_pids <name...>: PF_PIDS gets the recorded PID of each named forward.record_pf_pids() {