Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(frontend): r1-m1 isolate row keyboard navigation
Josuéc468f827c326
diff --git a/control-ui/components/__tests__/FrontendTableSystem.test.tsx b/control-ui/components/__tests__/FrontendTableSystem.test.tsxindex e5ead509c..bd30d1265 100644--- a/control-ui/components/__tests__/FrontendTableSystem.test.tsx+++ b/control-ui/components/__tests__/FrontendTableSystem.test.tsx@@ -53,6 +53,8 @@ describe('shared frontend table system', () => {<td>Record</td><td><button onClick={onChild}>Child action</button>+ <a href="/elsewhere">Child link</a>+ <input aria-label="Child selection" type="checkbox" /></td></TableRow></tbody>@@ -66,6 +68,16 @@ describe('shared frontend table system', () => {fireEvent.click(screen.getByRole('button', { name: 'Child action' }))expect(onChild).toHaveBeenCalledOnce()expect(onNavigate).toHaveBeenCalledTimes(2)++ for (const child of [+ screen.getByRole('button', { name: 'Child action' }),+ screen.getByRole('link', { name: 'Child link' }),+ screen.getByRole('checkbox', { name: 'Child selection' }),+ ]) {+ fireEvent.keyDown(child, { key: 'Enter' })+ fireEvent.keyDown(child, { key: ' ' })+ }+ expect(onNavigate).toHaveBeenCalledTimes(2)})it('opens one accessible action menu and executes its destructive action', () => {diff --git a/control-ui/package-lock.json b/control-ui/package-lock.jsonindex aa2e26028..846e74813 100644--- a/control-ui/package-lock.json+++ b/control-ui/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-ui",- "version": "0.1.480",+ "version": "0.1.481","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-ui",- "version": "0.1.480",+ "version": "0.1.481","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/frontend-table-system": "file:../packages/frontend-table-system",diff --git a/control-ui/package.json b/control-ui/package.jsonindex 98a1f95c6..35fe8e10b 100644--- a/control-ui/package.json+++ b/control-ui/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-ui",- "version": "0.1.480",+ "version": "0.1.481","private": true,"scripts": {"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",diff --git a/packages/frontend-table-system/src/index.tsx b/packages/frontend-table-system/src/index.tsxindex 2c5fe009f..ffa73782e 100644--- a/packages/frontend-table-system/src/index.tsx+++ b/packages/frontend-table-system/src/index.tsx@@ -125,7 +125,12 @@ export function TableRow({}: React.HTMLAttributes<HTMLTableRowElement> & { onNavigate?: () => void }) {const activate = (event: KeyboardEvent<HTMLTableRowElement>) => {props.onKeyDown?.(event)- if (event.defaultPrevented || !onNavigate || (event.key !== 'Enter' && event.key !== ' '))+ if (+ event.defaultPrevented ||+ event.target !== event.currentTarget ||+ !onNavigate ||+ (event.key !== 'Enter' && event.key !== ' ')+ )returnevent.preventDefault()onNavigate()