Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

Merge origin/dev into refactor/desktop-app-styles

Diego Zacariascf28cdb60150
diff --cc desktop-app/test/browser/responsiveUtilityGutter.browser.test.ts
index d592b901c,4c9eafdcb..e69f71a3c
--- a/desktop-app/test/browser/responsiveUtilityGutter.browser.test.ts
+++ b/desktop-app/test/browser/responsiveUtilityGutter.browser.test.ts
@@@ -67,26 -99,30 +93,35 @@@ describe('responsive utility gutter', (
const closed = await headerGeometry(1100)
const open = await headerGeometry(1100, true)
- // Search is now portalled into the titlebar. The embedded app therefore
- // reserves the notification drawer rail, not the removed in-panel search.
- expect(closed.searchInsideContentPanel).toBe(false)
- expect(closed.mountedPaddingRight).toBe(438)
- expect(open.mountedPaddingRight).toBe(0)
+ // Closed: no base gutter on the mounted embed (search is in the title bar).
+ // Open: the page reserves the drawer rail and the embed sits flush against it
- // (the embed slot's own padding stays 0 — the page pads, not the slot).
++ // (the embed slot's own padding stays 0 — the page pads, not the slot). The
++ // rail is `--app-notification-drawer-width` (420px) + `--space-4` (18px) = 438px;
++ // the window-controls term was dropped once those controls moved to the titlebar.
+ expect(closed.embedPaddingRight).toBe(0)
+ expect(open.embedPaddingRight).toBe(0)
- expect(open.pagePaddingRight).toBe(466)
+ expect(open.pagePaddingRight).toBe(438)
})
- it('retains mobile zero-reservation and the wide desktop utility budget', async () => {
+ it('reserves no base utility gutter at any width, mobile or wide desktop', async () => {
const mobile = await headerGeometry(900)
const desktop = await headerGeometry(1221)
+ // With search in the title bar, neither the apps picker header nor the
+ // mounted embed pads a base gutter at any width — the responsive "utility
+ // budget" that reserved space for the floating in-panel search is retired.
+ // Regression guard: re-introducing a floating in-panel search would make one
+ // of these non-zero again.
expect(mobile.appsPaddingRight).toBe(0)
- expect(mobile.mountedPaddingRight).toBe(0)
- // The titlebar owns the window controls, so the mounted app only reserves
- // the 420px notification rail plus its 18px outer inset.
- expect(desktop.appsPaddingRight).toBe(438)
- expect(desktop.mountedPaddingRight).toBe(438)
+ expect(mobile.embedPaddingRight).toBe(0)
+ expect(desktop.appsPaddingRight).toBe(0)
+ expect(desktop.embedPaddingRight).toBe(0)
})
+
+ it('fills the measured embedded-app rail when the chat drawer is closed', async () => {
+ const geometry = await notificationDrawerGeometry()
+
+ expect(geometry.drawerLeft).toBe(geometry.embedRight)
+ expect(geometry.drawerRight).toBe(1182)
+ })
})
diff --cc desktop-app/ui/src/styles.css
index 773d02a8d,cd3b018f9..e06a6a962
--- a/desktop-app/ui/src/styles.css
+++ b/desktop-app/ui/src/styles.css
@@@ -12998,17 -12905,10 +13010,6 @@@ pre
padding-right: var(--app-header-utilities-width);
}
- /* The chat drawer occupies the right rail at --layer-chat-overlay, above the
- header (`.top-bar` at --layer-header) within the shared content-panel stacking
- context — so the header's transient dropdowns (the notification Inbox popover,
- global search) would paint BEHIND the drawer and never surface. While the chat
- drawer is open, lift the header to the dropdown layer so those overlays surface
- over it, exactly as they do over chat content in full-screen. Toasts
- (z-index: 4000) still sit above the header; the drawer's own z is unchanged. */
- .content-panel.content-panel--chat-drawer-open .top-bar {
- z-index: var(--layer-dropdown);
-.content-panel.content-panel--chat-drawer-open .sandbox-ui-mounted-header {
- padding-right: 0;
--}
--
.chat-drawer {
position: fixed;
/* Follow the measured top of the embed slot (`--chat-drawer-top`, published by
diff --cc desktop-app/ui/src/styles/tokens.css
index ab0c0647e,d09416a36..dc5e869f1
--- a/desktop-app/ui/src/styles/tokens.css
+++ b/desktop-app/ui/src/styles/tokens.css
@@@ -177,20 -158,10 +177,21 @@@
--window-control-mac-minimize: rgb(255, 189, 46);
--window-control-mac-expand: rgb(40, 201, 64);
--window-control-mac-border: rgba(var(--overlay-rgb), 0.28);
+ --titlebar-divider-border: rgba(var(--edge-rgb), 0.28);
--titlebar-control-ink: #ffffff;
- --titlebar-control-border: rgba(255, 255, 255, 0.3);
+ --titlebar-control-border: var(--titlebar-divider-border);
--titlebar-control-surface: rgb(var(--panel-rgb));
+ /* VS Code command center: a fixed-width pill centered in the title bar. */
+ --titlebar-search-width: 320px;
+ /* Close-control hover is the one destructive window control — a solid red
+ hover on Windows/Linux (mac keeps its own traffic-light styling). The red
+ signal reads on both themes, so it lives in the shared root block. */
+ --window-control-close-hover-bg: #e81123;
+ --window-control-close-hover-ink: #ffffff;
+ /* Flat 1px zone-separation border between structural surfaces (title bar /
+ activity bar / sidebar / editor). Solid, not translucent, so the boundary
+ stays crisp like VS Code instead of bleeding the zone color through. */
+ --zone-border: #26282c;
/* chat-view session tabs (Chrome-style: shrink to a floor, cap at a ceiling) */
--chat-tab-max: 220px;
@@@ -316,7 -287,6 +317,7 @@@
--mcp-health-shell-surface: rgba(var(--panel-rgb), 0.96);
--mcp-health-rows-surface: rgba(var(--panel-rgb), 0.86);
--titlebar-control-ink: #000000;
- --titlebar-control-border: rgba(var(--overlay-rgb), 0.3);
+ --titlebar-control-border: var(--titlebar-divider-border);
--titlebar-control-surface: rgb(var(--panel-rgb));
+ --zone-border: #d3ddef;
}