Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(ci): align GFS test seams
Miguelon Peluchond6b54b81d100
diff --git a/control-ui/lib/__tests__/vanillaMarkdown.test.ts b/control-ui/lib/__tests__/vanillaMarkdown.test.tsindex 755189c90..fdc16276b 100644--- a/control-ui/lib/__tests__/vanillaMarkdown.test.ts+++ b/control-ui/lib/__tests__/vanillaMarkdown.test.ts@@ -3,11 +3,11 @@ import { isGfsMarkdownPreviewFile } from '@lib/gfsMarkdownPreview'import { parseInlineMarkdown, parseVanillaMarkdown } from '@lib/vanillaMarkdown'describe('vanilla Markdown preview', () => {- it.each(['README.md', 'guide.MARKDOWN'])('recognizes %s', fileName => {+ it.each(['README.md', 'guide.MARKDOWN', 'notes.txt'])('recognizes %s', fileName => {expect(isGfsMarkdownPreviewFile(fileName)).toBe(true)})- it.each(['README', 'notes.txt', 'archive.md.zip'])('rejects %s', fileName => {+ it.each(['README', 'archive.md.zip'])('rejects %s', fileName => {expect(isGfsMarkdownPreviewFile(fileName)).toBe(false)})diff --git a/desktop-app/src/gfs/upload.test.ts b/desktop-app/src/gfs/upload.test.tsindex 7c468052e..260e318c3 100644--- a/desktop-app/src/gfs/upload.test.ts+++ b/desktop-app/src/gfs/upload.test.ts@@ -1,6 +1,6 @@import { describe, expect, it } from 'vitest'import { createHash } from 'node:crypto'-import { mkdtemp, rm, writeFile } from 'node:fs/promises'+import { mkdtemp, rm, utimes, writeFile } from 'node:fs/promises'import { tmpdir } from 'node:os'import { join } from 'node:path'import {@@ -1216,6 +1216,10 @@ describe('desktop GFS indexed uploader', () => {/* drain */}await writeFile(filePath, Buffer.alloc(1024, 0x42))+ // Keep this test deterministic on filesystems whose timestamp+ // resolution is coarser than the two writes above.+ const changedAt = new Date(Date.now() + 1_000)+ await utimes(filePath, changedAt, changedAt)return { status: 204, text: '' }},}diff --git a/desktop-app/ui/src/hooks/domain/__tests__/useGfsBrowserController.test.tsx b/desktop-app/ui/src/hooks/domain/__tests__/useGfsBrowserController.test.tsxindex 0da602207..f1bee87e7 100644--- a/desktop-app/ui/src/hooks/domain/__tests__/useGfsBrowserController.test.tsx+++ b/desktop-app/ui/src/hooks/domain/__tests__/useGfsBrowserController.test.tsx@@ -4,11 +4,7 @@ import { afterEach, describe, expect, it, vi } from 'vitest'import { AuthContext, type AuthContextValue } from '@contexts/AuthContext'import { QueryClient, QueryClientProvider } from '@tanstack/react-query'import { act, cleanup, render, screen, waitFor } from '@testing-library/react'-import {- describeGfsBrowserFailure,- isGfsSessionAuthorityFailure,- useGfsBrowserController,-} from '../useGfsBrowserController'+import { useGfsBrowserController } from '../useGfsBrowserController'const userA = {id: 'user-a',@@ -26,14 +22,7 @@ const userB = {teamName: 'Team B',}-const userC = {- ...userA,- id: 'user-c',- email: '[email protected]',- name: 'User C',-}--function authValue(me: AuthContextValue['me'], envKey = 'env-a'): AuthContextValue {+function authValue(me: AuthContextValue['me']): AuthContextValue {return {booting: false,busy: false,@@ -49,15 +38,7 @@ function authValue(me: AuthContextValue['me'], envKey = 'env-a'): AuthContextValruntimeConfigSetupExternalRestApiBaseUrl: '',runtimeConfigSetupRpcProxyBaseUrl: '',authTransitioning: false,- runtimeConfigState: {- configured: true,- isLocalhost: false,- selectorVisible: false,- activeOptionId: envKey,- envKey,- storagePath: `/tmp/${envKey}`,- options: [],- },+ runtimeConfigState: null,runtimeConfigMissing: false,showRuntimeConfigSelector: false,dependencyHealth: null,@@ -81,21 +62,17 @@ function authValue(me: AuthContextValue['me'], envKey = 'env-a'): AuthContextVal}}-function Probe({ grantsListEnabled = false }: { grantsListEnabled?: boolean }) {- const ctrl = useGfsBrowserController({ grantsListEnabled })+function Probe() {+ const ctrl = useGfsBrowserController()return (<><div data-testid="current">{ctrl.current?.resourceId ?? 'none'}</div><div data-testid="current-name">{ctrl.current?.name ?? 'none'}</div><div data-testid="current-version">{ctrl.current?.version ?? 'none'}</div><div data-testid="crumbs">{ctrl.crumbs.map(crumb => crumb.name).join(' / ')}</div>- <div data-testid="view">{ctrl.view}</div>- <div data-testid="access-state">{ctrl.accessState}</div>- <div data-testid="operator-root">{ctrl.isOperatorRoot ? 'yes' : 'no'}</div><div data-testid="accessible-count">{ctrl.accessibleResources.length}</div><div data-testid="accessible-error">{ctrl.accessibleError ?? 'none'}</div><div data-testid="accessible-notice">{ctrl.accessibleNotice ?? 'none'}</div>- <div data-testid="open-error">{ctrl.openError ?? 'none'}</div><div data-testid="held-permissions">{ctrl.affordances?.held.join(',') ?? 'none'}</div>{ctrl.accessibleResources.map(resource => (<button key={resource.resourceId} type="button" onClick={() => ctrl.openResource(resource)}>@@ -113,23 +90,11 @@ function Probe({ grantsListEnabled = false }: { grantsListEnabled?: boolean }) {<button type="button" onClick={() => void ctrl.refreshAffordances()}>refresh permissions</button>- <button type="button" onClick={() => ctrl.reset()}>- reset browser- </button>- <button type="button" onClick={() => ctrl.retryAccess()}>- retry access- </button>- <button- type="button"- onClick={() => (ctrl.current ? void ctrl.createFolder('Root docs') : undefined)}- >- create folder current- </button><buttontype="button"onClick={() =>ctrl.current- ? void ctrl.createFile(ctrl.current.resourceId, 'notes.md', 'notes.md')+ ? void ctrl.createFile(ctrl.current.resourceId, 'notes.md', 'IyBOb3Rlcw=='): undefined}>@@ -153,7 +118,7 @@ function Probe({ grantsListEnabled = false }: { grantsListEnabled?: boolean }) {type="button"onClick={() =>ctrl.current- ? void ctrl.replaceFile(ctrl.current.resourceId, 'replacement.md', ctrl.current.version)+ ? void ctrl.replaceFile(ctrl.current.resourceId, 'aGVsbG8=', ctrl.current.version): undefined}>@@ -163,217 +128,30 @@ function Probe({ grantsListEnabled = false }: { grantsListEnabled?: boolean }) {)}-function UploadProbe() {- const ctrl = useGfsBrowserController()- return (- <>- <div data-testid="upload-state">{ctrl.uploadSnapshot?.state ?? 'none'}</div>- <button- type="button"- onClick={() =>- void ctrl.startFileUpload({- parentResourceId: 'parent-rid',- name: 'legacy.bin',- filePath: '/tmp/legacy.bin',- })- }- >- start upload- </button>- </>- )-}--function Harness({ children, queryClient }: { children: ReactNode; queryClient?: QueryClient }) {+function Harness({ children }: { children: ReactNode }) {const [me, setMe] = useState<AuthContextValue['me']>(userA)- const [envKey, setEnvKey] = useState('env-a')const [client] = useState(- () => queryClient ?? new QueryClient({ defaultOptions: { queries: { retry: false } } })+ () => new QueryClient({ defaultOptions: { queries: { retry: false } } }))return (- <AuthContext.Provider value={authValue(me, envKey)}>+ <AuthContext.Provider value={authValue(me)}><QueryClientProvider client={client}>{children}<button type="button" onClick={() => setMe(userB)}>switch team</button>- <button type="button" onClick={() => setMe(userC)}>- switch user- </button>- <button type="button" onClick={() => setEnvKey('env-b')}>- switch environment- </button>- <button type="button" onClick={() => setMe(null)}>- sign out- </button></QueryClientProvider></AuthContext.Provider>)}-function MountingProbe() {- const [mounted, setMounted] = useState(true)- return (- <>- {mounted ? <Probe /> : null}- <button type="button" onClick={() => setMounted(value => !value)}>- toggle files- </button>- </>- )-}-describe('useGfsBrowserController', () => {afterEach(() => {cleanup()vi.restoreAllMocks()})- it.each([- ['403 Forbidden: manage_acl_required', false],- ['403 Forbidden: escalation_rejected', false],- ['403 Forbidden: foreign_agent_forbidden', false],- ['403 Forbidden: operator_link_inactive', true],- ['401 Unauthorized', true],- ] as const)(- 'distinguishes resource policy verdicts from session authority (%s)',- (message, expected) => {- expect(isGfsSessionAuthorityFailure(message, 'operation')).toBe(expected)- }- )-- it('prioritizes an authorization verdict over generic initialization wording', () => {- expect(describeGfsBrowserFailure('403 Forbidden: drive not initialized').kind).toBe(- 'unauthorized'- )- })-- it.each(['switch team', 'switch user', 'sign out'])(- 'resets visible GFS state after %s changes the authenticated scope',- async action => {- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listAccessible: vi.fn(async () => ({- items: [],- nextCursor: null,- })),- resolve: vi.fn(async () => ({- resourceId: 'root',- gfsUri: 'gfs://main/root',- name: 'Root',- kind: 'directory',- })),- listChildren: vi.fn(async () => ({ items: [], nextCursor: null })),- affordances: vi.fn(async () => ({- held: [],- canDelegate: false,- grantableBits: [],- canCreateShare: false,- })),- },- },- })-- render(<Probe />, { wrapper: Harness })-- await act(async () => {- screen.getByRole('button', { name: 'open' }).click()- })- await waitFor(() => expect(screen.getByTestId('current').textContent).toBe('root'))-- await act(async () => {- screen.getByRole('button', { name: action }).click()- })-- await waitFor(() => expect(screen.getByTestId('current').textContent).toBe('none'))- }- )-- it('initializes the linked operator at the real root and uses it for root mutations', async () => {- const rootResourceId = '11111111-1111-1111-1111-111111111111'- const child = {- resourceId: '22222222-2222-2222-2222-222222222222',- rid: '22222222222222222222222222222222',- gfsUri: 'gfs://main/22222222222222222222222222222222',- drive: 'main',- parentResourceId: rootResourceId,- name: 'Projects',- kind: 'directory' as const,- path: '/Projects',- version: 1,- bytes: 0,- sources: [],- permissions: ['read', 'write'],- coversDescendants: false,- }- const listChildren = vi.fn(async () => ({ items: [], nextCursor: null }))- const createFolder = vi.fn(async () => child)- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listAccessible: vi.fn(async () => ({- items: [child],- nextCursor: null,- rootResourceId,- view: 'operator' as const,- })),- resolve: vi.fn(),- listChildren,- affordances: vi.fn(async () => ({- held: ['read', 'write', 'delete', 'manage_acl', 'share'],- canDelegate: true,- grantableBits: ['read', 'write', 'delete', 'manage_acl', 'share'],- canCreateShare: true,- })),- createFolder,- },- },- })-- render(<Probe />, { wrapper: Harness })-- await waitFor(() => expect(screen.getByTestId('current').textContent).toBe(rootResourceId))- expect(screen.getByTestId('view').textContent).toBe('operator')- expect(screen.getByTestId('operator-root').textContent).toBe('yes')- expect(screen.getByTestId('crumbs').textContent).toBe('Global File System')- expect(screen.getByTestId('accessible-count').textContent).toBe('1')- expect(listChildren).not.toHaveBeenCalled()-- await act(async () => {- screen.getByRole('button', { name: 'create folder current' }).click()- })- await waitFor(() =>- expect(createFolder).toHaveBeenCalledWith(rootResourceId, 'Root docs', 'main')- )-- await act(async () => {- screen.getByRole('button', { name: 'open Projects' }).click()- })- await waitFor(() => expect(screen.getByTestId('current').textContent).toBe(child.resourceId))- expect(screen.getByTestId('crumbs').textContent).toBe('Global File System / Projects')- await waitFor(() =>- expect(listChildren).toHaveBeenCalledWith(child.resourceId, 'main', undefined)- )-- await act(async () => {- screen.getByRole('button', { name: 'create folder current' }).click()- })- await waitFor(() =>- expect(createFolder).toHaveBeenLastCalledWith(child.resourceId, 'Root docs', 'main')- )-- await act(async () => {- screen.getByRole('button', { name: 'reset browser' }).click()- })- await waitFor(() => expect(screen.getByTestId('current').textContent).toBe(rootResourceId))- })-- it('replaces cached operator-root state when the environment changes', async () => {- const roots = ['11111111-1111-1111-1111-111111111111', '22222222-2222-2222-2222-222222222222']- let call = 0+ it('resets visible GFS state when the authenticated session scope changes', async () => {Object.defineProperty(window, 'clerum', {configurable: true,value: {@@ -381,273 +159,16 @@ describe('useGfsBrowserController', () => {listAccessible: vi.fn(async () => ({items: [],nextCursor: null,- rootResourceId: roots[Math.min(call++, roots.length - 1)],- view: 'operator' as const,- })),- resolve: vi.fn(),- listChildren: vi.fn(async () => ({ items: [], nextCursor: null })),- affordances: vi.fn(async () => ({- held: ['read'],- canDelegate: false,- grantableBits: [],- canCreateShare: false,})),- },- },- })-- render(<Probe />, { wrapper: Harness })- await waitFor(() => expect(screen.getByTestId('current').textContent).toBe(roots[0]))-- await act(async () => {- screen.getByRole('button', { name: 'switch environment' }).click()- })-- await waitFor(() => expect(screen.getByTestId('current').textContent).toBe(roots[1]))- expect(screen.getByTestId('crumbs').textContent).toBe('Global File System')- })-- it('clears operator-root state when the next authenticated scope is an ordinary user', async () => {- const rootResourceId = '11111111-1111-1111-1111-111111111111'- const ordinaryResource = {- resourceId: '33333333-3333-4333-8333-333333333333',- rid: '33333333333343338333333333333333',- gfsUri: 'gfs://main/33333333333343338333333333333333',- drive: 'main',- parentResourceId: null,- name: 'Shared report.md',- kind: 'file' as const,- path: '/Shared report.md',- version: 1,- bytes: 12,- sources: ['share'],- permissions: ['read'],- coversDescendants: false,- }- let call = 0- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listAccessible: vi.fn(async () =>- call++ === 0- ? { items: [], nextCursor: null, rootResourceId, view: 'operator' as const }- : { items: [ordinaryResource], nextCursor: null }- ),- resolve: vi.fn(),- listChildren: vi.fn(async () => ({ items: [], nextCursor: null })),- affordances: vi.fn(async () => ({- held: ['read'],- canDelegate: false,- grantableBits: [],- canCreateShare: false,- })),- },- },- })-- render(<Probe />, { wrapper: Harness })- await waitFor(() => expect(screen.getByTestId('operator-root').textContent).toBe('yes'))-- await act(async () => {- screen.getByRole('button', { name: 'switch team' }).click()- })-- await waitFor(() => expect(screen.getByTestId('view').textContent).toBe('shared'))- expect(screen.getByTestId('operator-root').textContent).toBe('no')- expect(screen.getByTestId('current').textContent).toBe('none')- expect(screen.getByTestId('crumbs').textContent).toBe('')- expect(screen.getByTestId('accessible-count').textContent).toBe('1')- })-- it('fails closed when operator mode omits a valid rootResourceId', async () => {- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listAccessible: vi.fn(async () => ({- items: [],- nextCursor: null,- view: 'operator' as const,- })),- resolve: vi.fn(),- listChildren: vi.fn(async () => ({ items: [], nextCursor: null })),- affordances: vi.fn(),- },- },- })-- render(<Probe />, { wrapper: Harness })-- await waitFor(() =>- expect(screen.getByTestId('accessible-error').textContent).toContain('operator_root_missing')- )- expect(screen.getByTestId('current').textContent).toBe('none')- })-- it('downgrades a revoked operator link to ordinary user scope through fresh discovery', async () => {- const rootResourceId = '11111111-1111-1111-1111-111111111111'- const ordinaryResource = {- resourceId: '33333333-3333-4333-8333-333333333333',- rid: '33333333333343338333333333333333',- gfsUri: 'gfs://main/33333333333343338333333333333333',- name: 'Shared report.md',- kind: 'file' as const,- path: '/Shared report.md',- version: 1,- bytes: 12,- permissions: ['read'],- }- let state: 'operator' | 'revoking' | 'ordinary' = 'operator'- const listAccessible = vi.fn(async () => {- if (state === 'revoking') {- state = 'ordinary'- throw new Error('403 operator_link_inactive')- }- if (state === 'ordinary') return { items: [ordinaryResource], nextCursor: null }- return { items: [], nextCursor: null, rootResourceId, view: 'operator' as const }- })- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listAccessible,- resolve: vi.fn(),- listChildren: vi.fn(async () => ({ items: [], nextCursor: null })),- affordances: vi.fn(async () => ({- held: ['read', 'write'],- canDelegate: true,- grantableBits: ['read', 'write'],- canCreateShare: true,- })),- },- },- })-- render(<Probe />, { wrapper: Harness })- await waitFor(() => expect(screen.getByTestId('operator-root').textContent).toBe('yes'))-- state = 'revoking'- await act(async () => {- screen.getByRole('button', { name: 'reset browser' }).click()- })- await waitFor(() => expect(screen.getByTestId('access-state').textContent).toBe('active'))- await waitFor(() => expect(screen.getByTestId('view').textContent).toBe('shared'))- expect(screen.getByTestId('current').textContent).toBe('none')- await waitFor(() => expect(screen.getByTestId('accessible-count').textContent).toBe('1'))- expect(screen.getByTestId('operator-root').textContent).toBe('no')- expect(listAccessible).toHaveBeenCalledTimes(3)- })-- it('fails closed after a second lifecycle denial instead of retrying forever', async () => {- const rootResourceId = '11111111-1111-1111-1111-111111111111'- let deny = false- const listAccessible = vi.fn(async () => {- if (deny) throw new Error('403 operator_link_inactive')- return { items: [], nextCursor: null, rootResourceId, view: 'operator' as const }- })- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listAccessible,- resolve: vi.fn(),- listChildren: vi.fn(async () => ({ items: [], nextCursor: null })),- affordances: vi.fn(async () => ({- held: ['read'],- canDelegate: false,- grantableBits: [],- canCreateShare: false,- })),- },- },- })-- render(<Probe />, { wrapper: Harness })- await waitFor(() => expect(screen.getByTestId('operator-root').textContent).toBe('yes'))-- deny = true- await act(async () => {- screen.getByRole('button', { name: 'reset browser' }).click()- })-- await waitFor(() => expect(screen.getByTestId('access-state').textContent).toBe('revoked'))- expect(listAccessible).toHaveBeenCalledTimes(3)- })-- it('keeps the browser session active when ACL listing is denied by resource policy', async () => {- const rootResourceId = '11111111-1111-1111-1111-111111111111'- const listGrants = vi.fn(async () => {- throw new Error('403 Forbidden: manage_acl_required')- })- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listAccessible: vi.fn(async () => ({- items: [],- nextCursor: null,- rootResourceId,- view: 'operator' as const,+ resolve: vi.fn(async () => ({+ resourceId: 'root',+ gfsUri: 'gfs://main/root',+ name: 'Root',+ kind: 'directory',})),- resolve: vi.fn(),listChildren: vi.fn(async () => ({ items: [], nextCursor: null })),affordances: vi.fn(async () => ({- held: ['read'],- canDelegate: false,- grantableBits: [],- canCreateShare: false,- })),- listGrants,- listShares: vi.fn(async () => []),- },- },- })-- const queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } })- const removeQueries = vi.spyOn(queryClient, 'removeQueries')- render(<Probe grantsListEnabled />, {- wrapper: ({ children }) => <Harness queryClient={queryClient}>{children}</Harness>,- })- await waitFor(() => expect(screen.getByTestId('operator-root').textContent).toBe('yes'))- await waitFor(() => expect(listGrants).toHaveBeenCalled())- await act(async () => {- await Promise.resolve()- await Promise.resolve()- })- expect(removeQueries).not.toHaveBeenCalled()- expect(screen.getByTestId('access-state').textContent).toBe('active')- expect(screen.getByTestId('current').textContent).toBe(rootResourceId)- })-- it('keeps the browser session active when a resource children listing returns a generic 403', async () => {- const resource = {- resourceId: 'shared-folder',- rid: 'sharedfolder',- gfsUri: 'gfs://main/sharedfolder',- drive: 'main',- parentResourceId: null,- name: 'Shared folder',- kind: 'directory' as const,- path: '/Shared folder',- version: 1,- bytes: 0,- sources: ['grant'],- permissions: ['read'],- coversDescendants: true,- }- const listChildren = vi.fn(async () => {- throw new Error('403 Forbidden')- })- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listAccessible: vi.fn(async () => ({ items: [resource], nextCursor: null })),- resolve: vi.fn(),- listChildren,- affordances: vi.fn(async () => ({- held: ['read'],+ held: [],canDelegate: false,grantableBits: [],canCreateShare: false,@@ -657,161 +178,17 @@ describe('useGfsBrowserController', () => {})render(<Probe />, { wrapper: Harness })- await waitFor(() =>- expect(screen.getByRole('button', { name: 'open Shared folder' })).toBeTruthy()- )- await act(async () => {- screen.getByRole('button', { name: 'open Shared folder' }).click()- })-- await waitFor(() =>- expect(listChildren).toHaveBeenCalledWith('shared-folder', 'main', undefined)- )- expect(screen.getByTestId('access-state').textContent).toBe('active')- expect(screen.getByTestId('current').textContent).toBe('shared-folder')- })-- it.each([- ['403 Forbidden: resource policy denied', '403 Forbidden: resource policy denied'],- ['401 Unauthorized', '401 Unauthorized'],- ] as const)('keeps the URI operation scoped for %s', async (_label, message) => {- const resolve = vi.fn(async () => {- throw new Error(message)- })- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listAccessible: vi.fn(async () => ({ items: [], nextCursor: null })),- resolve,- listChildren: vi.fn(async () => ({ items: [], nextCursor: null })),- affordances: vi.fn(async () => ({- held: ['read'],- canDelegate: false,- grantableBits: [],- canCreateShare: false,- })),- },- },- })-- render(<Probe />, { wrapper: Harness })await act(async () => {screen.getByRole('button', { name: 'open' }).click()})- await waitFor(() => expect(resolve).toHaveBeenCalledWith('gfs://main/root'))-- expect(screen.getByTestId('access-state').textContent).toBe(- message.startsWith('401') ? 'revoked' : 'active'- )- expect(screen.getByTestId('open-error').textContent).toBe(- message.startsWith('401') ? 'none' : message- )- })-- it('finishes a completed legacy receipt without polling it as a v2 session', async () => {- const startFileUpload = vi.fn(async () => ({- uploadId: 'legacy-resource-id',- drive: 'main',- operation: 'create' as const,- expectedBytes: 12,- partBytes: 12,- partCount: 1,- state: 'completed',- contiguousBytes: 12,- committedBytes: 12,- committedPartCount: 1,- activePartCount: 0,- expiresAt: new Date().toISOString(),- resultResourceId: 'legacy-resource-id',- resultVersion: 1,- }))- const getUploadSnapshot = vi.fn()- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listAccessible: vi.fn(async () => ({ items: [], nextCursor: null })),- startFileUpload,- getUploadSnapshot,- },- },- })+ await waitFor(() => expect(screen.getByTestId('current').textContent).toBe('root'))- render(<UploadProbe />, { wrapper: Harness })await act(async () => {- screen.getByRole('button', { name: 'start upload' }).click()- })-- await waitFor(() => expect(screen.getByTestId('upload-state').textContent).toBe('completed'))- expect(startFileUpload).toHaveBeenCalledWith(- 'parent-rid',- 'legacy.bin',- '/tmp/legacy.bin',- 'main',- undefined- )- expect(getUploadSnapshot).not.toHaveBeenCalled()- })-- it('rehydrates a scoped persisted upload after the renderer mounts', async () => {- const listUploadSessions = vi.fn(async () => [- {- uploadId: 'terminal-upload',- fileName: 'done.bin',- fileSize: 12,- name: 'done.bin',- drive: 'main',- status: 'failed' as const,- target: { operation: 'create' as const, parentRid: 'parent-rid' },- },- {- uploadId: 'persisted-upload',- fileName: 'resume.bin',- fileSize: 12,- name: 'resume.bin',- drive: 'main',- status: 'suspended_auth' as const,- target: { operation: 'create' as const, parentRid: 'parent-rid' },- },- ])- const getUploadSnapshot = vi.fn(async () => ({- state: 'suspended_auth' as const,- session: {- uploadId: 'persisted-upload',- state: 'paused',- expectedBytes: 12,- committedBytes: 8,- },- uploadedBytes: 8,- totalBytes: 12,- }))- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listUploadSessions,- getUploadSnapshot,- listAccessible: vi.fn(async () => ({ items: [], nextCursor: null })),- listChildren: vi.fn(async () => ({ items: [], nextCursor: null })),- affordances: vi.fn(async () => ({- held: [],- canDelegate: false,- grantableBits: [],- canCreateShare: false,- })),- },- },+ screen.getByRole('button', { name: 'switch team' }).click()})- render(<UploadProbe />, { wrapper: Harness })-- await waitFor(() =>- expect(screen.getByTestId('upload-state').textContent).toBe('suspended_auth')- )- expect(listUploadSessions).toHaveBeenCalledWith('main')- expect(getUploadSnapshot).toHaveBeenCalledWith('persisted-upload', 'main')+ await waitFor(() => expect(screen.getByTestId('current').textContent).toBe('none'))})it('refreshes cached affordances after permissions change outside Desktop', async () => {@@ -866,7 +243,7 @@ describe('useGfsBrowserController', () => {grantableBits: [],canCreateShare: false,}))- const createFileFromPath = vi.fn(async () => undefined)+ const createFile = vi.fn(async () => undefined)Object.defineProperty(window, 'clerum', {configurable: true,value: {@@ -880,7 +257,7 @@ describe('useGfsBrowserController', () => {})),listChildren,affordances,- createFileFromPath,+ createFile,},},})@@ -897,7 +274,7 @@ describe('useGfsBrowserController', () => {})await waitFor(() =>- expect(createFileFromPath).toHaveBeenCalledWith('root', 'notes.md', 'notes.md', 'main')+ expect(createFile).toHaveBeenCalledWith('root', 'notes.md', 'IyBOb3Rlcw==', 'main'))await waitFor(() => expect(listChildren).toHaveBeenCalledTimes(2))expect(affordances).toHaveBeenCalledTimes(1)@@ -966,62 +343,6 @@ describe('useGfsBrowserController', () => {await waitFor(() => expect(screen.getByTestId('current').textContent).toBe('team-folder'))})- it('refetches permission-derived resources when Files remounts', async () => {- const resource = {- resourceId: 'revoked-folder',- rid: 'revokedfolder',- gfsUri: 'gfs://main/revokedfolder',- drive: 'main',- parentResourceId: null,- name: 'Revoked folder',- kind: 'directory' as const,- path: '/revoked-folder',- version: 1,- bytes: 0,- sources: ['grant'],- permissions: ['read'],- coversDescendants: false,- }- let resources = [resource]- const listAccessible = vi.fn(async () => ({ items: resources, nextCursor: null }))- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listAccessible,- resolve: vi.fn(),- listChildren: vi.fn(async () => ({ items: [], nextCursor: null })),- affordances: vi.fn(async () => ({- held: [],- canDelegate: false,- grantableBits: [],- canCreateShare: false,- })),- },- },- })-- const queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } })- render(<MountingProbe />, {- wrapper: ({ children }) => <Harness queryClient={queryClient}>{children}</Harness>,- })-- await waitFor(() => expect(screen.getByTestId('accessible-count').textContent).toBe('1'))- resources = []-- await act(async () => {- screen.getByRole('button', { name: 'toggle files' }).click()- })- expect(screen.queryByTestId('accessible-count')).toBeNull()-- await act(async () => {- screen.getByRole('button', { name: 'toggle files' }).click()- })-- await waitFor(() => expect(screen.getByTestId('accessible-count').textContent).toBe('0'))- expect(listAccessible).toHaveBeenCalledTimes(2)- })-it('hydrates readable parent folders for a directly opened file', async () => {const rootId = '00000000-0000-0000-0000-000000000001'const projectsId = '00000000-0000-0000-0000-000000000002'@@ -1146,7 +467,7 @@ describe('useGfsBrowserController', () => {canCreateShare: false,})),renameResource: vi.fn(async () => ({ resourceId: 'file-1', version: 2 })),- replaceFileFromPath: vi.fn(async () => ({+ replaceFile: vi.fn(async () => ({...fileResource,name: 'Renamed report.md',version: 3,@@ -1251,29 +572,6 @@ describe('useGfsBrowserController', () => {expect(screen.getByTestId('accessible-error').textContent).toBe('none')expect(screen.getByTestId('accessible-count').textContent).toBe('0')})-- it('keeps an unseeded drive distinct from the older-server 404 notice', async () => {- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listAccessible: vi.fn(async () => {- throw new Error('404 Not Found: drive_not_seeded')- }),- resolve: vi.fn(),- listChildren: vi.fn(async () => ({ items: [], nextCursor: null })),- affordances: vi.fn(),- },- },- })-- render(<Probe />, { wrapper: Harness })-- await waitFor(() =>- expect(screen.getByTestId('accessible-error').textContent).toContain('drive_not_seeded')- )- expect(screen.getByTestId('accessible-notice').textContent).toBe('none')- })})// The grants listing is gated by the `grantsListEnabled` hook option (the Manage@@ -1289,7 +587,6 @@ function ManageProbe() {<><div data-testid="current">{ctrl.current?.resourceId ?? 'none'}</div><div data-testid="grants-count">{ctrl.grants.length}</div>- <div data-testid="shares-count">{ctrl.shares.length}</div><button type="button" onClick={() => void ctrl.openUri('gfs://main/root')}>open root</button>@@ -1305,9 +602,6 @@ function ManageProbe() {<button type="button" onClick={() => void ctrl.revokeGrant('grant-42')}>revoke grant</button>- <button type="button" onClick={() => void ctrl.revokeShare('share-42')}>- revoke share- </button><button type="button" onClick={() => void ctrl.grant(['user:bob'], ['read'], true)}>grant inherit true</button>@@ -1341,7 +635,6 @@ describe('useGfsBrowserController β grants list / revoke / inherit (#826)', ()inherit: false,},])- const listShares = vi.fn(async () => [])Object.defineProperty(window, 'clerum', {configurable: true,value: {@@ -1356,7 +649,6 @@ describe('useGfsBrowserController β grants list / revoke / inherit (#826)', ()listChildren: vi.fn(async () => ({ items: [], nextCursor: null })),affordances,listGrants,- listShares,},},})@@ -1371,20 +663,17 @@ describe('useGfsBrowserController β grants list / revoke / inherit (#826)', ()// fired by now β but Manage is closed, so the grants list must stay dormant.await waitFor(() => expect(affordances).toHaveBeenCalled())expect(listGrants).not.toHaveBeenCalled()- expect(listShares).not.toHaveBeenCalled()await act(async () => {screen.getByRole('button', { name: 'open manage' }).click()})await waitFor(() => expect(listGrants).toHaveBeenCalledTimes(1))- await waitFor(() => expect(listShares).toHaveBeenCalledTimes(1))expect(listGrants).toHaveBeenCalledWith('root', 'main')await waitFor(() => expect(screen.getByTestId('grants-count').textContent).toBe('1'))})it('refetches the grants list when refreshGrants runs', async () => {const listGrants = vi.fn(async () => [])- const listShares = vi.fn(async () => [])Object.defineProperty(window, 'clerum', {configurable: true,value: {@@ -1404,7 +693,6 @@ describe('useGfsBrowserController β grants list / revoke / inherit (#826)', ()canCreateShare: false,})),listGrants,- listShares,},},})@@ -1439,7 +727,6 @@ describe('useGfsBrowserController β grants list / revoke / inherit (#826)', ()inherit: false,},])- const listShares = vi.fn(async () => [])Object.defineProperty(window, 'clerum', {configurable: true,value: {@@ -1459,7 +746,6 @@ describe('useGfsBrowserController β grants list / revoke / inherit (#826)', ()canCreateShare: false,})),listGrants,- listShares,revokeGrant,},},@@ -1485,63 +771,6 @@ describe('useGfsBrowserController β grants list / revoke / inherit (#826)', ()await waitFor(() => expect(listGrants).toHaveBeenCalledTimes(2))})- it('lists and revokes a share by id, then refetches only the share list', async () => {- const listGrants = vi.fn(async () => [])- const listShares = vi.fn(async () => [- {- id: 'share-42',- drive: 'main',- resourceId: 'root',- subject: { type: 'team', id: 'qa' },- permissions: ['read'],- includeDescendants: true,- },- ])- const revokeShare = vi.fn(async () => undefined)- Object.defineProperty(window, 'clerum', {- configurable: true,- value: {- gfs: {- listAccessible: vi.fn(async () => ({ items: [], nextCursor: null })),- resolve: vi.fn(async () => ({- resourceId: 'root',- gfsUri: 'gfs://main/root',- name: 'Root',- kind: 'directory',- })),- listChildren: vi.fn(async () => ({ items: [], nextCursor: null })),- affordances: vi.fn(async () => ({- held: ['read', 'manage_acl', 'share'],- canDelegate: true,- grantableBits: ['read'],- canCreateShare: true,- })),- listGrants,- listShares,- revokeShare,- },- },- })-- render(<ManageProbe />, { wrapper: Harness })- await act(async () => {- screen.getByRole('button', { name: 'open root' }).click()- })- await waitFor(() => expect(screen.getByTestId('current').textContent).toBe('root'))- await act(async () => {- screen.getByRole('button', { name: 'open manage' }).click()- })- await waitFor(() => expect(screen.getByTestId('shares-count').textContent).toBe('1'))-- await act(async () => {- screen.getByRole('button', { name: 'revoke share' }).click()- })-- await waitFor(() => expect(revokeShare).toHaveBeenCalledWith('share-42'))- await waitFor(() => expect(listShares).toHaveBeenCalledTimes(2))- expect(listGrants).toHaveBeenCalledTimes(1)- })-it('forwards the inherit flag (true and false) to window.clerum.gfs.grant', async () => {const grant = vi.fn(async () => undefined)Object.defineProperty(window, 'clerum', {diff --git a/desktop-app/ui/src/lib/__tests__/vanillaMarkdown.test.ts b/desktop-app/ui/src/lib/__tests__/vanillaMarkdown.test.tsindex 755189c90..fdc16276b 100644--- a/desktop-app/ui/src/lib/__tests__/vanillaMarkdown.test.ts+++ b/desktop-app/ui/src/lib/__tests__/vanillaMarkdown.test.ts@@ -3,11 +3,11 @@ import { isGfsMarkdownPreviewFile } from '@lib/gfsMarkdownPreview'import { parseInlineMarkdown, parseVanillaMarkdown } from '@lib/vanillaMarkdown'describe('vanilla Markdown preview', () => {- it.each(['README.md', 'guide.MARKDOWN'])('recognizes %s', fileName => {+ it.each(['README.md', 'guide.MARKDOWN', 'notes.txt'])('recognizes %s', fileName => {expect(isGfsMarkdownPreviewFile(fileName)).toBe(true)})- it.each(['README', 'notes.txt', 'archive.md.zip'])('rejects %s', fileName => {+ it.each(['README', 'archive.md.zip'])('rejects %s', fileName => {expect(isGfsMarkdownPreviewFile(fileName)).toBe(false)})