Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(frontend): r6-b1 complete navigable table rows

Josuéd7ccaa174aba
diff --git a/control-ui/components/CommunicationChannelsTable.tsx b/control-ui/components/CommunicationChannelsTable.tsx
index e780fc6bd..17cf90695 100644
--- a/control-ui/components/CommunicationChannelsTable.tsx
+++ b/control-ui/components/CommunicationChannelsTable.tsx
@@ -1,7 +1,7 @@
'use client'
-import React, { useMemo, useState } from 'react'
-import { DataTable, useTableSort } from '@clerum/frontend-table-system'
+import { useMemo, useState } from 'react'
+import { DataTable, TableRow, useTableSort } from '@clerum/frontend-table-system'
import {
COMMUNICATION_CHANNEL_PROVIDERS,
type CommunicationChannelProvider,
@@ -267,58 +267,59 @@ export function CommunicationChannelsTable({
configuredProviderTypes.has(provider)
)
return (
- <React.Fragment key={key}>
- <tr>
- <td>
- <button
- type="button"
- className="cu-channel-table__name"
- onClick={() => onOpenChannel?.(name)}
- disabled={!onOpenChannel}
- >
- {name}
- </button>
- </td>
- <td>
- <span className="cu-table__cell-muted">{spec.hostRef || '-'}</span>
- </td>
- <td>
- {providerTypes.map(communicationChannelProviderLabel).join(', ') || '-'}
- </td>
- <td>
- <div className="cu-table-actions">
- <RowActionsMenu
- ariaLabel={`Actions for channel ${name}`}
- horizontalTrigger
- actions={[
- ...(onEditChannel
- ? [
- {
- key: 'edit',
- label: 'Edit',
- onClick: () => onEditChannel(name),
- },
- ]
- : []),
- ...copyTargetsForChannel(item).map(provider => ({
- key: `copy-${provider}`,
- label: `Copy config into ${communicationChannelProviderLabel(provider)}`,
- onClick: () => onCopyChannel?.(name, provider),
- disabled: !onCopyChannel,
- })),
- {
- key: 'delete',
- label: deletingKey === key ? 'Deleting…' : 'Delete',
- danger: true,
- disabled: deletingKey === key,
- onClick: () => void deleteRow(item),
- },
- ]}
- />
- </div>
- </td>
- </tr>
- </React.Fragment>
+ <TableRow
+ key={key}
+ onNavigate={onOpenChannel ? () => onOpenChannel(name) : undefined}
+ >
+ <td className="cu-channel-table__name">{name}</td>
+ <td>
+ <span className="cu-table__cell-muted">{spec.hostRef || '-'}</span>
+ </td>
+ <td>
+ {providerTypes.map(communicationChannelProviderLabel).join(', ') || '-'}
+ </td>
+ <td>
+ <div className="cu-table-actions">
+ <RowActionsMenu
+ ariaLabel={`Actions for channel ${name}`}
+ horizontalTrigger
+ actions={[
+ ...(onOpenChannel
+ ? [
+ {
+ key: 'view',
+ label: 'View details',
+ onClick: () => onOpenChannel(name),
+ },
+ ]
+ : []),
+ ...(onEditChannel
+ ? [
+ {
+ key: 'edit',
+ label: 'Edit',
+ onClick: () => onEditChannel(name),
+ },
+ ]
+ : []),
+ ...copyTargetsForChannel(item).map(provider => ({
+ key: `copy-${provider}`,
+ label: `Copy config into ${communicationChannelProviderLabel(provider)}`,
+ onClick: () => onCopyChannel?.(name, provider),
+ disabled: !onCopyChannel,
+ })),
+ {
+ key: 'delete',
+ label: deletingKey === key ? 'Deleting…' : 'Delete',
+ danger: true,
+ disabled: deletingKey === key,
+ onClick: () => void deleteRow(item),
+ },
+ ]}
+ />
+ </div>
+ </td>
+ </TableRow>
)
})}
</tbody>
diff --git a/control-ui/components/LlmPriceTable.tsx b/control-ui/components/LlmPriceTable.tsx
index b6bff59bf..64439ecfe 100644
--- a/control-ui/components/LlmPriceTable.tsx
+++ b/control-ui/components/LlmPriceTable.tsx
@@ -1,7 +1,7 @@
'use client'
import React, { useMemo, useState } from 'react'
-import { DataTable, useTableSort } from '@clerum/frontend-table-system'
+import { DataTable, TableRow, useTableSort } from '@clerum/frontend-table-system'
import type { LlmModelPrice, UnpricedModel } from '@lib/api'
import { getProviderDisplayLabel } from '@lib/llm'
import type { LlmPriceTableProps } from './LlmPriceTable.types'
@@ -276,7 +276,11 @@ export function LlmPriceTable({
)
const providerLabel = getProviderDisplayLabel(price.provider)
return (
- <tr key={price.id} className="cu-table__row">
+ <TableRow
+ key={price.id}
+ className="cu-table__row"
+ onNavigate={() => onEdit(price.id)}
+ >
<td>
<span className="cu-px-provider">
<LlmProviderIcon provider={price.provider} label={providerLabel} />
@@ -331,7 +335,7 @@ export function LlmPriceTable({
]}
/>
</td>
- </tr>
+ </TableRow>
)
})}
</tbody>
diff --git a/control-ui/components/TokenBudgetTable.tsx b/control-ui/components/TokenBudgetTable.tsx
index 22288cd14..205aefa54 100644
--- a/control-ui/components/TokenBudgetTable.tsx
+++ b/control-ui/components/TokenBudgetTable.tsx
@@ -1,7 +1,7 @@
'use client'
import React, { useMemo, useState } from 'react'
-import { DataTable, useTableSort } from '@clerum/frontend-table-system'
+import { DataTable, TableRow, useTableSort } from '@clerum/frontend-table-system'
import type { TokenBudget } from '@lib/api'
import {
budgetProgressPercent,
@@ -216,7 +216,7 @@ function BudgetRow({
const limitText = formatBudgetAmount(limit, budget.unit, budget.currency)
return (
- <tr className="cu-table__row">
+ <TableRow className="cu-table__row" onNavigate={() => onEdit(budget.id)}>
<td className="cu-tb-name">{budget.name}</td>
<td>
{segments.length === 0 ? (
@@ -312,6 +312,6 @@ function BudgetRow({
]}
/>
</td>
- </tr>
+ </TableRow>
)
}
diff --git a/control-ui/components/__tests__/CommunicationChannelsTable.test.tsx b/control-ui/components/__tests__/CommunicationChannelsTable.test.tsx
index d9a075eb0..40a1cff2b 100644
--- a/control-ui/components/__tests__/CommunicationChannelsTable.test.tsx
+++ b/control-ui/components/__tests__/CommunicationChannelsTable.test.tsx
@@ -29,6 +29,35 @@ function renderTable({
}
describe('CommunicationChannelsTable', () => {
+ it('navigates the durable record row without activating from its action menu', () => {
+ const onOpenChannel = vi.fn()
+ render(
+ <ToastProvider>
+ <CommunicationChannelsTable
+ items={[
+ {
+ metadata: { name: 'channel-a', namespace: 'channels' },
+ spec: { hostRef: 'agent-a' },
+ },
+ ]}
+ onChanged={vi.fn().mockResolvedValue(undefined)}
+ onOpenChannel={onOpenChannel}
+ />
+ </ToastProvider>
+ )
+
+ const row = screen.getByText('channel-a').closest('tr')
+ expect(row).toHaveAttribute('tabindex', '0')
+ fireEvent.click(row!)
+ fireEvent.keyDown(row!, { key: 'Enter' })
+ fireEvent.keyDown(row!, { key: ' ' })
+ expect(onOpenChannel).toHaveBeenCalledTimes(3)
+
+ fireEvent.click(screen.getByRole('button', { name: 'Actions for channel channel-a' }))
+ expect(onOpenChannel).toHaveBeenCalledTimes(3)
+ expect(screen.getAllByRole('menuitem')[0]).toHaveTextContent('View details')
+ })
+
it('shows configured provider types in one column', () => {
renderTable({
items: [
diff --git a/control-ui/components/__tests__/LlmPriceTable.test.tsx b/control-ui/components/__tests__/LlmPriceTable.test.tsx
index aa9ad4b6a..2b4fe45af 100644
--- a/control-ui/components/__tests__/LlmPriceTable.test.tsx
+++ b/control-ui/components/__tests__/LlmPriceTable.test.tsx
@@ -38,6 +38,23 @@ function renderTable(overrides: Partial<React.ComponentProps<typeof LlmPriceTabl
}
describe('LlmPriceTable', () => {
+ it('navigates priced rows by pointer and keyboard without activating from the menu trigger', () => {
+ const onEdit = vi.fn()
+ renderTable({ onEdit })
+
+ const row = screen.getByText('claude-sonnet-4-6').closest('tr')
+ expect(row).toHaveAttribute('tabindex', '0')
+ fireEvent.click(row!)
+ fireEvent.keyDown(row!, { key: 'Enter' })
+ fireEvent.keyDown(row!, { key: ' ' })
+ expect(onEdit).toHaveBeenCalledTimes(3)
+
+ fireEvent.click(
+ screen.getByRole('button', { name: 'Actions for price claude/claude-sonnet-4-6' })
+ )
+ expect(onEdit).toHaveBeenCalledTimes(3)
+ })
+
it('renders a priced row with the provider label and prices', () => {
renderTable()
expect(screen.getByText('Anthropic')).toBeInTheDocument()
diff --git a/control-ui/components/__tests__/TokenBudgetTable.test.tsx b/control-ui/components/__tests__/TokenBudgetTable.test.tsx
index d9404d079..47f347ce3 100644
--- a/control-ui/components/__tests__/TokenBudgetTable.test.tsx
+++ b/control-ui/components/__tests__/TokenBudgetTable.test.tsx
@@ -44,6 +44,24 @@ function renderTable(overrides: Partial<React.ComponentProps<typeof TokenBudgetT
}
describe('TokenBudgetTable', () => {
+ it('navigates budget rows by pointer and keyboard while isolating row controls', () => {
+ const onEdit = vi.fn()
+ const onToggle = vi.fn().mockResolvedValue(undefined)
+ renderTable({ onEdit, onToggle })
+
+ const row = screen.getByText('Monthly OpenAI cap').closest('tr')
+ expect(row).toHaveAttribute('tabindex', '0')
+ fireEvent.click(row!)
+ fireEvent.keyDown(row!, { key: 'Enter' })
+ fireEvent.keyDown(row!, { key: ' ' })
+ expect(onEdit).toHaveBeenCalledTimes(3)
+
+ fireEvent.click(screen.getByRole('button', { name: 'Disable budget Monthly OpenAI cap' }))
+ fireEvent.click(screen.getByRole('button', { name: 'Actions for budget Monthly OpenAI cap' }))
+ expect(onToggle).toHaveBeenCalledWith(budgets[0])
+ expect(onEdit).toHaveBeenCalledTimes(3)
+ })
+
it('renders a budget row with readable scope, unit, and period', () => {
renderTable()
expect(screen.getByText('Monthly OpenAI cap')).toBeInTheDocument()
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 22293e674..2895399da 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.502",
+ "version": "0.1.503",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.502",
+ "version": "0.1.503",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-table-system": "file:../packages/frontend-table-system",
diff --git a/control-ui/package.json b/control-ui/package.json
index 7c674608f..2d737826c 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.502",
+ "version": "0.1.503",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",