Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

test(profile-ui): r3-m6 use approval label contract

Josuéd98035fdfa08
diff --git a/profile-ui/app/components/__tests__/ApprovalChannelsPage.test.tsx b/profile-ui/app/components/__tests__/ApprovalChannelsPage.test.tsx
index 4e283b17e..e30acf491 100644
--- a/profile-ui/app/components/__tests__/ApprovalChannelsPage.test.tsx
+++ b/profile-ui/app/components/__tests__/ApprovalChannelsPage.test.tsx
@@ -2,6 +2,7 @@ import type { ReactNode } from 'react'
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import '@testing-library/jest-dom/vitest'
import { cleanup, fireEvent, render, screen, waitFor, within } from '@testing-library/react'
+import { preferredAccountOptionLabel } from '@lib/approvalChannels'
import type {
ApprovalChannelTarget,
WorkflowApprovalMediumAccount,
@@ -79,13 +80,10 @@ vi.mock('@lib/api', () => ({
updateNotificationPreferences: mocks.updateNotificationPreferences,
}))
-vi.mock('@lib/approvalChannels', () => ({
- activeApprovalAccounts: (accounts: WorkflowApprovalMediumAccount[]) =>
- accounts.filter(account => !account.disabledAt),
- listWorkflowApprovalMediums: mocks.listWorkflowApprovalMediums,
- preferredAccountOptionLabel: (account: WorkflowApprovalMediumAccount) =>
- `${account.displayName} · Slack`,
-}))
+vi.mock('@lib/approvalChannels', async importOriginal => {
+ const original = await importOriginal<typeof import('@lib/approvalChannels')>()
+ return { ...original, listWorkflowApprovalMediums: mocks.listWorkflowApprovalMediums }
+})
function renderPage() {
return render(<ApprovalChannelsPage />)
@@ -111,7 +109,8 @@ describe('ApprovalChannelsPage preferred channel editing', () => {
mocks.updateNotificationPreferences.mockResolvedValue(automaticPreferences)
renderPage()
- expect(await screen.findByText('Operations · Slack')).toBeInTheDocument()
+ const expectedLabel = preferredAccountOptionLabel(slackAccount)
+ expect(await screen.findByText(expectedLabel)).toBeInTheDocument()
expect(screen.queryByRole('combobox', { name: 'Preferred channel' })).toBeNull()
fireEvent.click(screen.getByRole('button', { name: 'Edit preferred channel' }))
@@ -123,7 +122,7 @@ describe('ApprovalChannelsPage preferred channel editing', () => {
expect(mocks.updateNotificationPreferences).not.toHaveBeenCalled()
expect(
screen.getByRole('button', { name: 'Edit preferred channel' }).parentElement
- ).toHaveTextContent('Operations · Slack')
+ ).toHaveTextContent(expectedLabel)
fireEvent.click(within(dialog).getByRole('button', { name: 'Save' }))
await waitFor(() =>
@@ -144,7 +143,8 @@ describe('ApprovalChannelsPage preferred channel editing', () => {
mocks.updateNotificationPreferences.mockRejectedValue(new Error('preferred_account_not_found'))
renderPage()
- await screen.findByText('Operations · Slack')
+ const expectedLabel = preferredAccountOptionLabel(slackAccount)
+ await screen.findByText(expectedLabel)
fireEvent.click(screen.getByRole('button', { name: 'Edit preferred channel' }))
const dialog = await screen.findByRole('dialog', { name: 'Edit preferred approval channel' })
const select = within(dialog).getByRole('combobox', { name: 'Preferred channel' })
@@ -157,7 +157,7 @@ describe('ApprovalChannelsPage preferred channel editing', () => {
expect(select).toHaveValue('')
fireEvent.click(within(dialog).getByRole('button', { name: 'Cancel' }))
expect(screen.queryByRole('dialog', { name: 'Edit preferred approval channel' })).toBeNull()
- expect(screen.getByText('Operations · Slack')).toBeInTheDocument()
+ expect(screen.getByText(expectedLabel)).toBeInTheDocument()
fireEvent.click(screen.getByRole('button', { name: 'Edit preferred channel' }))
expect(await screen.findByRole('combobox', { name: 'Preferred channel' })).toHaveValue(
diff --git a/profile-ui/package-lock.json b/profile-ui/package-lock.json
index c6ea97be5..33e4c55cd 100644
--- a/profile-ui/package-lock.json
+++ b/profile-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-profile-ui",
- "version": "0.1.142",
+ "version": "0.1.143",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-profile-ui",
- "version": "0.1.142",
+ "version": "0.1.143",
"dependencies": {
"@clerum/desktop-app-links": "file:../packages/desktop-app-links",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/profile-ui/package.json b/profile-ui/package.json
index c4c142c9f..ded59f1aa 100644
--- a/profile-ui/package.json
+++ b/profile-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-profile-ui",
- "version": "0.1.142",
+ "version": "0.1.143",
"private": true,
"scripts": {
"dev": "next dev",