Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): r4-h2 narrow table package context

Josuédbed8e70580a
diff --git a/control-ui/Dockerfile.dockerignore b/control-ui/Dockerfile.dockerignore
index 6f5d47dff..1a1aac8e2 100644
--- a/control-ui/Dockerfile.dockerignore
+++ b/control-ui/Dockerfile.dockerignore
@@ -5,7 +5,10 @@
!packages/display-field/
!packages/display-field/**
!packages/frontend-table-system/
-!packages/frontend-table-system/**
+!packages/frontend-table-system/package.json
+!packages/frontend-table-system/src/
+!packages/frontend-table-system/src/index.tsx
+!packages/frontend-table-system/styles.css
packages/frontend-table-system/node_modules/
!packages/llm-providers/
!packages/llm-providers/**
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 09346ac87..197b7305a 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.499",
+ "version": "0.1.500",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.499",
+ "version": "0.1.500",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-table-system": "file:../packages/frontend-table-system",
diff --git a/control-ui/package.json b/control-ui/package.json
index bf538f135..063a94fb9 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.499",
+ "version": "0.1.500",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",
diff --git a/scripts/tests/test-dockerfile-local-packages.sh b/scripts/tests/test-dockerfile-local-packages.sh
index 1e5c682c5..26524e2e0 100755
--- a/scripts/tests/test-dockerfile-local-packages.sh
+++ b/scripts/tests/test-dockerfile-local-packages.sh
@@ -101,15 +101,85 @@ assert_dockerignore_allows() {
assert_dockerignore_excludes_generated_dependencies() {
local file="$1"
local package="$2"
- local ignore="$REPO_ROOT/$file"
+ local ignore="$file"
local allow_line exclude_line
- allow_line="$(line_of_last "$ignore" "!packages/$package/**")"
- exclude_line="$(line_of_last "$ignore" "packages/$package/node_modules/")"
+ if [[ "$ignore" != /* ]]; then
+ ignore="$REPO_ROOT/$file"
+ fi
+ allow_line="$(
+ awk -v pattern="!packages/$package/" \
+ '$0 == pattern { line=NR } END { if (line) print line }' "$ignore"
+ )"
+ exclude_line="$(
+ awk -v pattern="packages/$package/node_modules/" \
+ '$0 == pattern { line=NR } END { if (line) print line }' "$ignore"
+ )"
if [[ -z "$allow_line" || -z "$exclude_line" || "$exclude_line" -le "$allow_line" ]]; then
fail "$file must exclude packages/$package/node_modules from its Docker context"
fi
}
+assert_dockerignore_narrow_package() {
+ local file="$1"
+ local package="$2"
+ local ignore="$file"
+ local expected actual
+ if [[ "$ignore" != /* ]]; then
+ ignore="$REPO_ROOT/$file"
+ fi
+ expected="$(printf '%s\n' \
+ "!packages/$package/" \
+ "!packages/$package/package.json" \
+ "!packages/$package/src/" \
+ "!packages/$package/src/index.tsx" \
+ "!packages/$package/styles.css")"
+ actual="$(awk -v prefix="!packages/$package/" 'index($0, prefix) == 1 { print }' "$ignore")"
+ if [[ "$actual" != "$expected" ]]; then
+ fail "$file must allow exactly the tracked packages/$package build files"
+ fi
+}
+
+assert_dockerignore_mutations_rejected() {
+ local fixture_dir negated_node_modules extra_secret
+ fixture_dir="$(mktemp -d "${TMPDIR:-/tmp}/evenfire-dockerignore-contract.XXXXXX")"
+ negated_node_modules="$fixture_dir/negated-node-modules"
+ extra_secret="$fixture_dir/extra-secret"
+
+ printf '%s\n' \
+ '!packages/frontend-table-system/' \
+ '!packages/frontend-table-system/package.json' \
+ '!packages/frontend-table-system/src/' \
+ '!packages/frontend-table-system/src/index.tsx' \
+ '!packages/frontend-table-system/styles.css' \
+ '!packages/frontend-table-system/node_modules/' > "$negated_node_modules"
+ local before="$failures"
+ assert_dockerignore_excludes_generated_dependencies \
+ "$negated_node_modules" frontend-table-system 2>/dev/null
+ if [[ "$failures" -eq "$before" ]]; then
+ fail 'Docker context contract must reject a negated node_modules rule'
+ else
+ failures="$before"
+ fi
+
+ printf '%s\n' \
+ '!packages/frontend-table-system/' \
+ '!packages/frontend-table-system/package.json' \
+ '!packages/frontend-table-system/src/' \
+ '!packages/frontend-table-system/src/index.tsx' \
+ '!packages/frontend-table-system/styles.css' \
+ '!packages/frontend-table-system/.env' \
+ 'packages/frontend-table-system/node_modules/' > "$extra_secret"
+ before="$failures"
+ assert_dockerignore_narrow_package "$extra_secret" frontend-table-system 2>/dev/null
+ if [[ "$failures" -eq "$before" ]]; then
+ fail 'Docker context contract must reject an extra package-scoped allow rule'
+ else
+ failures="$before"
+ fi
+
+ rm -rf -- "$fixture_dir"
+}
+
# Direct consumers. The first four are Node services; profile-ui and
# control-ui are Next.js consumers and therefore also require materialization.
assert_copy_before_every_ci control-api/Dockerfile \
@@ -144,10 +214,11 @@ assert_materialized profile-ui/Dockerfile frontend-table-system
assert_dockerignore_allows control-api/Dockerfile.dockerignore display-field
assert_dockerignore_allows control-api/Dockerfile.dockerignore llm-providers
assert_dockerignore_allows control-ui/Dockerfile.dockerignore display-field
-assert_dockerignore_allows control-ui/Dockerfile.dockerignore frontend-table-system
assert_dockerignore_allows control-ui/Dockerfile.dockerignore llm-providers
+assert_dockerignore_narrow_package control-ui/Dockerfile.dockerignore frontend-table-system
assert_dockerignore_excludes_generated_dependencies \
control-ui/Dockerfile.dockerignore frontend-table-system
+assert_dockerignore_mutations_rejected
if (( failures > 0 )); then
echo "$failures Docker local-package contract failure(s)" >&2