Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(ci): r10-m5 validate suite contents through one descriptor

Josuédd3ce113dfad
diff --git a/scripts/ci/password-recovery-suite-contract.mjs b/scripts/ci/password-recovery-suite-contract.mjs
index 9967a5d9e..1e81f8b06 100644
--- a/scripts/ci/password-recovery-suite-contract.mjs
+++ b/scripts/ci/password-recovery-suite-contract.mjs
@@ -1,5 +1,5 @@
#!/usr/bin/env node
-import { readFileSync, readdirSync, statSync } from 'node:fs'
+import { closeSync, constants, fstatSync, openSync, readFileSync, readdirSync } from 'node:fs'
import { dirname, relative, resolve } from 'node:path'
import { fileURLToPath, pathToFileURL } from 'node:url'
import { pinnedSuiteViolations } from './assert-pinned-vitest-suites.mjs'
@@ -35,8 +35,13 @@ export function verifySuiteManifest(root, manifest) {
)
throw new Error('Invalid recovery suite path')
const path = resolve(root, entry)
- if (!statSync(path).isFile() || !readFileSync(path, 'utf8').trim())
- throw new Error(`Missing or empty recovery suite: ${entry}`)
+ const descriptor = openSync(path, constants.O_RDONLY | constants.O_NONBLOCK)
+ try {
+ if (!fstatSync(descriptor).isFile() || !readFileSync(descriptor, 'utf8').trim())
+ throw new Error(`Missing or empty recovery suite: ${entry}`)
+ } finally {
+ closeSync(descriptor)
+ }
}
function collect(directory) {
return readdirSync(directory, { withFileTypes: true }).flatMap(entry => {
diff --git a/scripts/tests/password-recovery-suite-contract.test.mjs b/scripts/tests/password-recovery-suite-contract.test.mjs
index 4aba81148..6d51ec816 100644
--- a/scripts/tests/password-recovery-suite-contract.test.mjs
+++ b/scripts/tests/password-recovery-suite-contract.test.mjs
@@ -1,6 +1,8 @@
import assert from 'node:assert/strict'
import { spawnSync } from 'node:child_process'
+import fs from 'node:fs'
import { copyFileSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs'
+import { syncBuiltinESMExports } from 'node:module'
import { join } from 'node:path'
import test from 'node:test'
import { fileURLToPath } from 'node:url'
@@ -28,6 +30,53 @@ test('exact checked-in census and full reporter pass', () => {
assert.equal(verifySuiteManifest(root, manifest), manifest)
assert.deepEqual(reportViolations(root, manifest, 'publicPostgres', green()), [])
})
+test('pathname replacement cannot substitute nonempty contents after a suite is opened', () => {
+ const scratchRoot = process.env.CODEX_SCRATCH_ROOT
+ assert.ok(scratchRoot, 'CODEX_SCRATCH_ROOT is required for manifest fixtures')
+ const repositoryScratch = join(scratchRoot, 'evenfire')
+ mkdirSync(repositoryScratch, { recursive: true })
+ const fixture = mkdtempSync(join(repositoryScratch, 'recovery-manifest-'))
+ const selection = {
+ version: 1,
+ publicPostgres: ['control-api/test/public.realPostgres.test.ts'],
+ privatePostgres: {
+ local: 'control-api/test/local.realPostgres.test.ts',
+ configured: 'control-api/test/configured.realPostgres.test.ts',
+ },
+ composedContract: ['control-api/test/contract.test.ts'],
+ consumer: ['external-rest-api/test/consumer.test.ts'],
+ }
+ const originalRead = fs.readFileSync
+ try {
+ for (const directory of ['control-api/test', 'external-rest-api/test'])
+ mkdirSync(join(fixture, directory), { recursive: true })
+ for (const entry of [
+ ...selection.publicPostgres,
+ ...Object.values(selection.privatePostgres),
+ ...selection.composedContract,
+ ...selection.consumer,
+ ])
+ writeFileSync(join(fixture, entry), '// fixture\n')
+ const selected = join(fixture, selection.publicPostgres[0])
+ writeFileSync(selected, '')
+ let replaced = false
+ fs.readFileSync = (...args) => {
+ if (!replaced) {
+ replaced = true
+ fs.renameSync(selected, join(fixture, 'original-empty-suite'))
+ writeFileSync(selected, '// replacement\n')
+ }
+ return originalRead(...args)
+ }
+ syncBuiltinESMExports()
+ assert.throws(() => verifySuiteManifest(fixture, selection), /Missing or empty recovery suite/)
+ assert.equal(replaced, true)
+ } finally {
+ fs.readFileSync = originalRead
+ syncBuiltinESMExports()
+ rmSync(fixture, { recursive: true, force: true })
+ }
+})
for (const [label, mutate] of [
[
'unknown schema',