Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

refactor(desktop-app): l6 rename deepLinkOverlayOpen -> deepLinkShellOverlayOpen

Diego Zacariasdf2f7832c8f0
diff --git a/desktop-app/ui/src/App.tsx b/desktop-app/ui/src/App.tsx
index 0d7d9025a..e2f4c81b8 100644
--- a/desktop-app/ui/src/App.tsx
+++ b/desktop-app/ui/src/App.tsx
@@ -1881,7 +1881,7 @@ export function App() {
}
sidebarShellOverlayOpen={sidebarSettingsMenuOpen}
toastShellOverlayOpen={vm.toasts.length > 0}
- deepLinkOverlayOpen={sandboxUiDeepLinkDialog !== null}
+ deepLinkShellOverlayOpen={sandboxUiDeepLinkDialog !== null}
shortcutApp={activeSandboxUiApp}
shortcutOpenRequestId={sandboxUiShortcutOpenRequestId}
localSearchRequestId={sandboxLocalSearchRequestId}
diff --git a/desktop-app/ui/src/__tests__/App.deepLinks.test.tsx b/desktop-app/ui/src/__tests__/App.deepLinks.test.tsx
index 2f7334abd..266b53b88 100644
--- a/desktop-app/ui/src/__tests__/App.deepLinks.test.tsx
+++ b/desktop-app/ui/src/__tests__/App.deepLinks.test.tsx
@@ -37,7 +37,7 @@ const sidebarHarness = vi.hoisted(() => ({
const sandboxUiPageHarness = vi.hoisted(() => ({
props: null as null | {
headerShellOverlayOpen?: boolean
- deepLinkOverlayOpen?: boolean
+ deepLinkShellOverlayOpen?: boolean
shortcutOpenRequestId?: number
localSearchRequestId?: number
actionRequest?: {
@@ -633,7 +633,7 @@ describe('App deep-link orchestration', () => {
await waitFor(() => expect(sandboxUiPageHarness.props).not.toBeNull())
// The native WebContentsView paints above renderer DOM, so the overlay
// signal must stay off until a deep-link dialog actually needs to show.
- expect(sandboxUiPageHarness.props?.deepLinkOverlayOpen).toBeFalsy()
+ expect(sandboxUiPageHarness.props?.deepLinkShellOverlayOpen).toBeFalsy()
await waitFor(() => expect(emitDeepLink).not.toBeNull())
act(() => {
@@ -641,12 +641,12 @@ describe('App deep-link orchestration', () => {
})
await waitFor(() => expect(confirmDialogHarness.props?.title).toBe('Open app link?'))
- expect(sandboxUiPageHarness.props?.deepLinkOverlayOpen).toBe(true)
+ expect(sandboxUiPageHarness.props?.deepLinkShellOverlayOpen).toBe(true)
await confirmPendingAppLink()
await reportShortcutOpenResult()
await waitFor(() => expect(acknowledgeDeepLink).toHaveBeenCalledWith(1))
- await waitFor(() => expect(sandboxUiPageHarness.props?.deepLinkOverlayOpen).toBe(false))
+ await waitFor(() => expect(sandboxUiPageHarness.props?.deepLinkShellOverlayOpen).toBe(false))
})
it('keeps the deep-link overlay signal raised while the failure dialog is open', async () => {
@@ -677,7 +677,7 @@ describe('App deep-link orchestration', () => {
await waitFor(() =>
expect(confirmDialogHarness.props?.title).toBe('App link could not be opened')
)
- expect(sandboxUiPageHarness.props?.deepLinkOverlayOpen).toBe(true)
+ expect(sandboxUiPageHarness.props?.deepLinkShellOverlayOpen).toBe(true)
await act(async () => {
confirmDialogHarness.props?.onCancel()
@@ -685,7 +685,7 @@ describe('App deep-link orchestration', () => {
})
await waitFor(() => expect(acknowledgeDeepLink).toHaveBeenCalledWith(1))
- await waitFor(() => expect(sandboxUiPageHarness.props?.deepLinkOverlayOpen).toBe(false))
+ await waitFor(() => expect(sandboxUiPageHarness.props?.deepLinkShellOverlayOpen).toBe(false))
})
it('does not duplicate an authenticated confirmation for the same link id', async () => {
diff --git a/desktop-app/ui/src/pages/SandboxUiPage.tsx b/desktop-app/ui/src/pages/SandboxUiPage.tsx
index 8264906ed..ebc97f505 100644
--- a/desktop-app/ui/src/pages/SandboxUiPage.tsx
+++ b/desktop-app/ui/src/pages/SandboxUiPage.tsx
@@ -156,7 +156,7 @@ export function SandboxUiPage({
headerShellOverlayOpen = false,
sidebarShellOverlayOpen = false,
toastShellOverlayOpen = false,
- deepLinkOverlayOpen = false,
+ deepLinkShellOverlayOpen = false,
shortcutApp = null,
shortcutOpenRequestId = 0,
localSearchRequestId = 0,
@@ -192,7 +192,7 @@ export function SandboxUiPage({
headerShellOverlayOpen ||
sidebarShellOverlayOpen ||
toastShellOverlayOpen ||
- deepLinkOverlayOpen
+ deepLinkShellOverlayOpen
const reload = useCallback(async () => {
setError(null)
diff --git a/desktop-app/ui/src/pages/SandboxUiPage.types.ts b/desktop-app/ui/src/pages/SandboxUiPage.types.ts
index 69c420c13..f9016a163 100644
--- a/desktop-app/ui/src/pages/SandboxUiPage.types.ts
+++ b/desktop-app/ui/src/pages/SandboxUiPage.types.ts
@@ -26,7 +26,7 @@ export type SandboxUiPageProps = {
headerShellOverlayOpen?: boolean
sidebarShellOverlayOpen?: boolean
toastShellOverlayOpen?: boolean
- deepLinkOverlayOpen?: boolean
+ deepLinkShellOverlayOpen?: boolean
shortcutApp?: ActiveSandboxUiApp | null
shortcutOpenRequestId?: number
localSearchRequestId?: number
diff --git a/desktop-app/ui/src/pages/__tests__/SandboxUiPage.test.tsx b/desktop-app/ui/src/pages/__tests__/SandboxUiPage.test.tsx
index a029c9051..565ac8659 100644
--- a/desktop-app/ui/src/pages/__tests__/SandboxUiPage.test.tsx
+++ b/desktop-app/ui/src/pages/__tests__/SandboxUiPage.test.tsx
@@ -877,7 +877,7 @@ describe('SandboxUiPage', () => {
// The "Open app link?" / "App link could not be opened" dialogs live in the
// renderer DOM; without hiding the WebContentsView they render behind the
// embedded app and the user can never reach the confirm/dismiss buttons.
- rerender(<SandboxUiPage deepLinkOverlayOpen />)
+ rerender(<SandboxUiPage deepLinkShellOverlayOpen />)
await waitFor(() => {
expect(screen.getByTestId('sandbox-ui-embed-preview')).toBeTruthy()