Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(frontend): consume registry create signals once

Josuédf7715ddb979
diff --git a/control-ui/components/RegistryApiKeysPanel.tsx b/control-ui/components/RegistryApiKeysPanel.tsx
index e69792626..df6d14484 100644
--- a/control-ui/components/RegistryApiKeysPanel.tsx
+++ b/control-ui/components/RegistryApiKeysPanel.tsx
@@ -1,6 +1,6 @@
'use client'
-import { useCallback, useEffect, useMemo, useState } from 'react'
+import { useCallback, useEffect, useMemo, useRef, useState } from 'react'
import Link from 'next/link'
import { DataTable, TableStateRow, TableViewport, useTableSort } from '@clerum/frontend-components'
import { CONTROL_ROUTES } from '@constants/routes'
@@ -67,6 +67,7 @@ export default function RegistryApiKeysPanel({
const [view, setView] = useState<View>({ kind: 'loading' })
const [creating, setCreating] = useState(false)
const [revealed, setRevealed] = useState<CreatedRegistryApiKey | null>(null)
+ const consumedCreateSignalRef = useRef(0)
const normalizedSearch = search.trim().toLowerCase()
const visibleKeys = useMemo(
() =>
@@ -173,7 +174,14 @@ export default function RegistryApiKeysPanel({
}, [load, refreshSignal])
useEffect(() => {
- if (createSignal > 0 && view.kind === 'ready') setCreating(true)
+ if (
+ createSignal > 0 &&
+ createSignal !== consumedCreateSignalRef.current &&
+ view.kind === 'ready'
+ ) {
+ consumedCreateSignalRef.current = createSignal
+ setCreating(true)
+ }
}, [createSignal, view.kind])
useEffect(() => {
diff --git a/control-ui/components/__tests__/RegistryApiKeysPanel.test.tsx b/control-ui/components/__tests__/RegistryApiKeysPanel.test.tsx
index 88b76727c..cda60dde5 100644
--- a/control-ui/components/__tests__/RegistryApiKeysPanel.test.tsx
+++ b/control-ui/components/__tests__/RegistryApiKeysPanel.test.tsx
@@ -216,6 +216,33 @@ describe('RegistryApiKeysPanel', () => {
expect(await screen.findByText(/100-key limit/i)).toBeInTheDocument()
})
+ it('consumes an external create signal once across error to ready transitions', async () => {
+ vi.mocked(api.listRegistryApiKeys)
+ .mockResolvedValueOnce({ org: 'acme', keys: [] })
+ .mockRejectedValueOnce(Object.assign(new Error('Network failure'), { status: 500 }))
+ .mockResolvedValueOnce({ org: 'acme', keys: [] })
+
+ const view = render(<RegistryApiKeysPanel createSignal={1} refreshSignal={0} />)
+
+ fireEvent.click(await screen.findByRole('button', { name: 'Cancel' }))
+ expect(screen.queryByRole('dialog', { name: /create api key/i })).toBeNull()
+
+ view.rerender(
+ <ToastProvider>
+ <RegistryApiKeysPanel createSignal={1} refreshSignal={1} />
+ </ToastProvider>
+ )
+ expect(await screen.findByText(/could not load api keys/i)).toBeInTheDocument()
+
+ view.rerender(
+ <ToastProvider>
+ <RegistryApiKeysPanel createSignal={1} refreshSignal={2} />
+ </ToastProvider>
+ )
+ expect(await screen.findByText(/no api keys yet/i)).toBeInTheDocument()
+ expect(screen.queryByRole('dialog', { name: /create api key/i })).toBeNull()
+ })
+
it('default sort: two keys with different created_at render newest-first', async () => {
const olderKey = {
...key,
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index f559d2d8a..a209eef3c 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.561",
+ "version": "0.1.562",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.561",
+ "version": "0.1.562",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index c099da0e6..170ac7647 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.561",
+ "version": "0.1.562",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",