Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): r1-m1 restore relationship action context

Josuée1bc925e7c75
diff --git a/control-ui/components/ControlAdminsPanel/index.tsx b/control-ui/components/ControlAdminsPanel/index.tsx
index ec095a248..b0bcea7b7 100644
--- a/control-ui/components/ControlAdminsPanel/index.tsx
+++ b/control-ui/components/ControlAdminsPanel/index.tsx
@@ -390,6 +390,7 @@ export function ControlAdminsPanel({
const memberCreationUnavailable = !admin.email || admin.passwordPending
const memberAccessDisabled = !admin.memberId && memberCreationUnavailable
const canCreateMember = !admin.memberId && !memberCreationUnavailable
+ const memberAccessLabel = `${memberAccessActionLabel(admin)} for admin ${label}`
return (
<tr
key={admin.id}
@@ -448,7 +449,7 @@ export function ControlAdminsPanel({
className="cu-btn cu-btn--icon cu-btn--toolbar"
disabled={memberAccessDisabled}
onClick={() => openMemberAccess(admin)}
- aria-label={memberAccessActionLabel(admin)}
+ aria-label={memberAccessLabel}
title={memberAccessActionLabel(admin)}
>
<IconUsers createBadge={canCreateMember} relationshipRole="member" />
diff --git a/control-ui/components/ProfileAdminHome.tsx b/control-ui/components/ProfileAdminHome.tsx
index 584c7dc26..b338a4948 100644
--- a/control-ui/components/ProfileAdminHome.tsx
+++ b/control-ui/components/ProfileAdminHome.tsx
@@ -927,7 +927,9 @@ export function ProfileAdminHome({ activeTab, highlightedAdminId = '' }: Profile
}}
onKeyDown={event => event.stopPropagation()}
disabled={busy && !loaded}
- aria-label={user.controlAdminId ? 'View admin' : 'Create admin'}
+ aria-label={`${
+ user.controlAdminId ? 'View admin' : 'Create admin'
+ } for member ${user.name || user.email}`}
title={user.controlAdminId ? 'View admin' : 'Create admin'}
>
<IconShield
diff --git a/control-ui/components/__tests__/ControlAdminsPanel.gfsOperatorLink.test.tsx b/control-ui/components/__tests__/ControlAdminsPanel.gfsOperatorLink.test.tsx
index 52408a157..67b832a20 100644
--- a/control-ui/components/__tests__/ControlAdminsPanel.gfsOperatorLink.test.tsx
+++ b/control-ui/components/__tests__/ControlAdminsPanel.gfsOperatorLink.test.tsx
@@ -166,7 +166,9 @@ describe('ControlAdminsPanel GFS operator link lifecycle', () => {
it('views the matching member from an admin with the destination-role SVG', async () => {
render(<ControlAdminsPanel />)
- const viewMemberButton = await screen.findByRole('button', { name: 'View member' })
+ const viewMemberButton = await screen.findByRole('button', {
+ name: 'View member for admin initial-admin ([email protected])',
+ })
expect(viewMemberButton).toHaveAttribute('title', 'View member')
expect(viewMemberButton.querySelector('svg')).toHaveAttribute(
'data-relationship-role',
@@ -198,7 +200,9 @@ describe('ControlAdminsPanel GFS operator link lifecycle', () => {
})
render(<ControlAdminsPanel />)
- const createMemberButton = await screen.findByRole('button', { name: 'Create member' })
+ const createMemberButton = await screen.findByRole('button', {
+ name: 'Create member for admin create-member ([email protected])',
+ })
expect(createMemberButton).toHaveAttribute('title', 'Create member')
expect(createMemberButton.querySelector('svg')).toHaveAttribute(
'data-relationship-role',
@@ -231,7 +235,7 @@ describe('ControlAdminsPanel GFS operator link lifecycle', () => {
render(<ControlAdminsPanel />)
const createMemberButton = await screen.findByRole('button', {
- name: 'Email required to create member',
+ name: 'Email required to create member for admin email-missing',
})
expect(createMemberButton).toBeDisabled()
expect(createMemberButton).toHaveAttribute('title', 'Email required to create member')
diff --git a/control-ui/components/__tests__/ProfileAdminHome.test.tsx b/control-ui/components/__tests__/ProfileAdminHome.test.tsx
index 596e5b0ab..e8beece45 100644
--- a/control-ui/components/__tests__/ProfileAdminHome.test.tsx
+++ b/control-ui/components/__tests__/ProfileAdminHome.test.tsx
@@ -164,7 +164,9 @@ describe('ProfileAdminHome — members invitations', () => {
await screen.findByLabelText('Open member Accepted Invitee')
- const createAdminButton = screen.getByRole('button', { name: 'Create admin' })
+ const createAdminButton = screen.getByRole('button', {
+ name: 'Create admin for member Accepted Invitee',
+ })
expect(createAdminButton).toHaveAttribute('title', 'Create admin')
expect(createAdminButton.querySelector('svg')).toHaveAttribute(
'data-relationship-role',
@@ -199,7 +201,9 @@ describe('ProfileAdminHome — members invitations', () => {
})
renderProfileAdminHome()
- const viewAdminButton = await screen.findByRole('button', { name: 'View admin' })
+ const viewAdminButton = await screen.findByRole('button', {
+ name: 'View admin for member Member',
+ })
expect(viewAdminButton).toHaveAttribute('title', 'View admin')
expect(viewAdminButton.querySelector('svg')).toHaveAttribute('data-relationship-role', 'admin')
expect(viewAdminButton.querySelector('svg')).not.toHaveAttribute('data-create-badge')
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index d78e06eee..c0a66e25a 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.437",
+ "version": "0.1.438",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.437",
+ "version": "0.1.438",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/llm-providers": "file:../packages/llm-providers",
diff --git a/control-ui/package.json b/control-ui/package.json
index 40f7fe21e..2f28c607f 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.437",
+ "version": "0.1.438",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",